[INFO] updating cached repository SwagColoredKitteh/shiny-pancake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SwagColoredKitteh/shiny-pancake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SwagColoredKitteh/shiny-pancake" "work/ex/clippy-test-run/sources/stable/gh/SwagColoredKitteh/shiny-pancake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SwagColoredKitteh/shiny-pancake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SwagColoredKitteh/shiny-pancake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SwagColoredKitteh/shiny-pancake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SwagColoredKitteh/shiny-pancake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ba8d91fac8d353d870dc89695bc162f023a71499 [INFO] sha for GitHub repo SwagColoredKitteh/shiny-pancake: ba8d91fac8d353d870dc89695bc162f023a71499 [INFO] validating manifest of SwagColoredKitteh/shiny-pancake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SwagColoredKitteh/shiny-pancake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SwagColoredKitteh/shiny-pancake [INFO] finished frobbing SwagColoredKitteh/shiny-pancake [INFO] frobbed toml for SwagColoredKitteh/shiny-pancake written to work/ex/clippy-test-run/sources/stable/gh/SwagColoredKitteh/shiny-pancake/Cargo.toml [INFO] started frobbing SwagColoredKitteh/shiny-pancake [INFO] finished frobbing SwagColoredKitteh/shiny-pancake [INFO] frobbed toml for SwagColoredKitteh/shiny-pancake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SwagColoredKitteh/shiny-pancake/Cargo.toml [INFO] crate SwagColoredKitteh/shiny-pancake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SwagColoredKitteh/shiny-pancake against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SwagColoredKitteh/shiny-pancake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63c8ff80713289ecabb7543adc355127decd5981097c9e1059b7a78b030648e9 [INFO] running `"docker" "start" "-a" "63c8ff80713289ecabb7543adc355127decd5981097c9e1059b7a78b030648e9"` [INFO] [stderr] Compiling rand v0.3.14 [INFO] [stderr] Compiling xml-rs v0.3.4 [INFO] [stderr] Checking clap v2.19.0 [INFO] [stderr] Checking gfx v0.12.1 [INFO] [stderr] Checking tempfile v2.1.4 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Compiling phf_generator v0.7.20 [INFO] [stderr] Compiling wayland-scanner v0.7.6 [INFO] [stderr] Compiling gl_generator v0.5.2 [INFO] [stderr] Compiling phf_codegen v0.7.20 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling wayland-client v0.7.6 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Compiling glutin v0.7.0 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Checking piston-gfx_texture v0.18.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.33.1 [INFO] [stderr] Checking gfx_device_gl v0.11.2 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.6 [INFO] [stderr] Checking wayland-window v0.4.2 [INFO] [stderr] Checking wayland-kbd v0.6.2 [INFO] [stderr] Checking winit v0.5.6 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston_window v0.58.0 [INFO] [stderr] Checking shiny-pancake v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `zero` [INFO] [stderr] --> src/vec2.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn zero() -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current_frame_mut` [INFO] [stderr] --> src/render_state.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn current_frame_mut(&mut self) -> &mut Frame { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `last_frame` [INFO] [stderr] --> src/render_state.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn last_frame(&self) -> &Frame { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/context.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | let mut sp = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:6:11 [INFO] [stderr] | [INFO] [stderr] 6 | [ self.0 as f32 / 255. [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | , self.1 as f32 / 255. [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:8:11 [INFO] [stderr] | [INFO] [stderr] 8 | , self.2 as f32 / 255. [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:9:11 [INFO] [stderr] | [INFO] [stderr] 9 | , self.3 as f32 / 255. ] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/renderer.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | (vp.draw_size[0] as i64, vp.draw_size[1] as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(vp.draw_size[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/renderer.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | (vp.draw_size[0] as i64, vp.draw_size[1] as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(vp.draw_size[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/renderer.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | let t = new_timer.duration_since(timer).subsec_nanos() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(new_timer.duration_since(timer).subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | let mut sp = param.split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: method is never used: `zero` [INFO] [stderr] --> src/vec2.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn zero() -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current_frame_mut` [INFO] [stderr] --> src/render_state.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn current_frame_mut(&mut self) -> &mut Frame { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `last_frame` [INFO] [stderr] --> src/render_state.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn last_frame(&self) -> &Frame { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/context.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | let mut sp = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:6:11 [INFO] [stderr] | [INFO] [stderr] 6 | [ self.0 as f32 / 255. [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | , self.1 as f32 / 255. [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:8:11 [INFO] [stderr] | [INFO] [stderr] 8 | , self.2 as f32 / 255. [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:9:11 [INFO] [stderr] | [INFO] [stderr] 9 | , self.3 as f32 / 255. ] [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/renderer.rs:37:18 [INFO] [stderr] | [INFO] [stderr] 37 | (vp.draw_size[0] as i64, vp.draw_size[1] as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(vp.draw_size[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/renderer.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | (vp.draw_size[0] as i64, vp.draw_size[1] as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(vp.draw_size[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/renderer.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | let t = new_timer.duration_since(timer).subsec_nanos() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(new_timer.duration_since(timer).subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | let mut sp = param.split("x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 56.34s [INFO] running `"docker" "inspect" "63c8ff80713289ecabb7543adc355127decd5981097c9e1059b7a78b030648e9"` [INFO] running `"docker" "rm" "-f" "63c8ff80713289ecabb7543adc355127decd5981097c9e1059b7a78b030648e9"` [INFO] [stdout] 63c8ff80713289ecabb7543adc355127decd5981097c9e1059b7a78b030648e9