[INFO] updating cached repository Svedrin/ruggers [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Svedrin/ruggers [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Svedrin/ruggers" "work/ex/clippy-test-run/sources/stable/gh/Svedrin/ruggers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Svedrin/ruggers'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Svedrin/ruggers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Svedrin/ruggers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Svedrin/ruggers'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 42748dc29770d5a2cc409a6c5bcd5f36cf5dba15 [INFO] sha for GitHub repo Svedrin/ruggers: 42748dc29770d5a2cc409a6c5bcd5f36cf5dba15 [INFO] validating manifest of Svedrin/ruggers on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Svedrin/ruggers on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Svedrin/ruggers [INFO] finished frobbing Svedrin/ruggers [INFO] frobbed toml for Svedrin/ruggers written to work/ex/clippy-test-run/sources/stable/gh/Svedrin/ruggers/Cargo.toml [INFO] started frobbing Svedrin/ruggers [INFO] finished frobbing Svedrin/ruggers [INFO] frobbed toml for Svedrin/ruggers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Svedrin/ruggers/Cargo.toml [INFO] crate Svedrin/ruggers has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Svedrin/ruggers against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Svedrin/ruggers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97200d2b6c6f87fa218e675f3d0a5387ce35019f4dd3589b085ad85d2abb4b75 [INFO] running `"docker" "start" "-a" "97200d2b6c6f87fa218e675f3d0a5387ce35019f4dd3589b085ad85d2abb4b75"` [INFO] [stderr] Checking ruggers v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ruggers.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | birth_gen: birth_gen, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `birth_gen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ruggers.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | key: key, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ruggers.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ruggers.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | birth_gen: birth_gen, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `birth_gen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ruggers.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | key: key, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ruggers.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ruggers.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const GEN_MASK: u64 = 0xFFFFFFFFFFFFFFF0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFF0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ruggers.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | const GEN_MASK: u64 = 0xFFFFFFFFFFFFFFF0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFF0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ruggers.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | this_gen: node_id as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(node_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruggers.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn get(&self, key: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruggers.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn store(&self, key: &String, value: &String) -> RuggedGeneration { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruggers.rs:68:46 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn store(&self, key: &String, value: &String) -> RuggedGeneration { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> src/ruggers.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | 1 + (16 * 1), String::from("Hallo1"), String::from("omfg1") [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> src/ruggers.rs:185:21 [INFO] [stderr] | [INFO] [stderr] 185 | 1 + (16 * 1), String::from("Hallo1"), String::from("omfg1") [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> src/ruggers.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | 1 + (16 * 1), String::from("Hallo1"), String::from("omfg1") [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ruggers.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | this_gen: node_id as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(node_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruggers.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn get(&self, key: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruggers.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn store(&self, key: &String, value: &String) -> RuggedGeneration { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ruggers.rs:68:46 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn store(&self, key: &String, value: &String) -> RuggedGeneration { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> src/ruggers.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | 2 + (16 * 1), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> src/ruggers.rs:291:21 [INFO] [stderr] | [INFO] [stderr] 291 | 1 + (16 * 1), String::from("Hallo1"), String::from("omfg1") [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `16` [INFO] [stderr] --> src/ruggers.rs:344:21 [INFO] [stderr] | [INFO] [stderr] 344 | 1 + (16 * 1), String::from("Hallo1"), String::from("omfg1") [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.37s [INFO] running `"docker" "inspect" "97200d2b6c6f87fa218e675f3d0a5387ce35019f4dd3589b085ad85d2abb4b75"` [INFO] running `"docker" "rm" "-f" "97200d2b6c6f87fa218e675f3d0a5387ce35019f4dd3589b085ad85d2abb4b75"` [INFO] [stdout] 97200d2b6c6f87fa218e675f3d0a5387ce35019f4dd3589b085ad85d2abb4b75