[INFO] updating cached repository SvantjeJung/battleship [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SvantjeJung/battleship [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SvantjeJung/battleship" "work/ex/clippy-test-run/sources/stable/gh/SvantjeJung/battleship"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SvantjeJung/battleship'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SvantjeJung/battleship" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SvantjeJung/battleship"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SvantjeJung/battleship'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2e3b1c01abd3ec5c589da875097848bbee85b6cc [INFO] sha for GitHub repo SvantjeJung/battleship: 2e3b1c01abd3ec5c589da875097848bbee85b6cc [INFO] validating manifest of SvantjeJung/battleship on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SvantjeJung/battleship on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SvantjeJung/battleship [INFO] finished frobbing SvantjeJung/battleship [INFO] frobbed toml for SvantjeJung/battleship written to work/ex/clippy-test-run/sources/stable/gh/SvantjeJung/battleship/Cargo.toml [INFO] started frobbing SvantjeJung/battleship [INFO] finished frobbing SvantjeJung/battleship [INFO] frobbed toml for SvantjeJung/battleship written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SvantjeJung/battleship/Cargo.toml [INFO] crate SvantjeJung/battleship has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SvantjeJung/battleship against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SvantjeJung/battleship:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8dda6ae167a6a6316b01026ef477eaced83b8f92dfea61048ce3a15dff7eb81 [INFO] running `"docker" "start" "-a" "d8dda6ae167a6a6316b01026ef477eaced83b8f92dfea61048ce3a15dff7eb81"` [INFO] [stderr] Checking serde v0.9.6 [INFO] [stderr] Checking term-painter v0.2.3 [INFO] [stderr] Compiling serde_codegen_internals v0.13.0 [INFO] [stderr] Checking chan v0.1.19 [INFO] [stderr] Checking clap v2.20.3 [INFO] [stderr] Checking ctrlc v3.0.0 [INFO] [stderr] Compiling serde_derive v0.9.6 [INFO] [stderr] Checking bincode v1.0.0-alpha1 [INFO] [stderr] Checking battleship v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/client/mod.rs:100:45 [INFO] [stderr] | [INFO] [stderr] 100 | "please restart the ship placement.") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | println!("\n{}{}", "------------------ O W N B O A R D ------------------", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | "-------------------------- O P P O N E N T ---------------"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/model/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/model/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | println!("{}{}", " A B C D E F G H I J", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | " A B C D E F G H I J"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/model/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | println!("{}{}", "----------------------------------------------------", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | "-------------------------------------------------------------"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/model/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:560:53 [INFO] [stderr] | [INFO] [stderr] 560 | p.name, i.name, i.size, " fields)."); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:567:45 [INFO] [stderr] | [INFO] [stderr] 567 | "please choose another coordinate."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:869:9 [INFO] [stderr] | [INFO] [stderr] 869 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/client/mod.rs:100:45 [INFO] [stderr] | [INFO] [stderr] 100 | "please restart the ship placement.") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | println!("\n{}{}", "------------------ O W N B O A R D ------------------", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | "-------------------------- O P P O N E N T ---------------"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/model/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/model/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | println!("{}{}", " A B C D E F G H I J", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | " A B C D E F G H I J"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/model/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | println!("{}{}", "----------------------------------------------------", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | "-------------------------------------------------------------"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/model/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:560:53 [INFO] [stderr] | [INFO] [stderr] 560 | p.name, i.name, i.size, " fields)."); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/model/mod.rs:567:45 [INFO] [stderr] | [INFO] [stderr] 567 | "please choose another coordinate."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/mod.rs:869:9 [INFO] [stderr] | [INFO] [stderr] 869 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] error: missing fragment specifier [INFO] [stderr] --> <::clap::macros::clap_app macros>:87:47 [INFO] [stderr] | [INFO] [stderr] 87 | @ arg ( $ arg : expr ) $ modes : tt ! $ ident $ ( $ tail : tt ) * ) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(missing_fragment_specifier)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #40107 [INFO] [stderr] [INFO] [stderr] error: missing fragment specifier [INFO] [stderr] --> <::clap::macros::clap_app macros>:87:47 [INFO] [stderr] | [INFO] [stderr] 87 | @ arg ( $ arg : expr ) $ modes : tt ! $ ident $ ( $ tail : tt ) * ) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(missing_fragment_specifier)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #40107 [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:550:12 [INFO] [stderr] | [INFO] [stderr] 550 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 551 | | if p.capacity == 0 { [INFO] [stderr] 552 | | [INFO] [stderr] 553 | | print_boards(&p); [INFO] [stderr] ... | [INFO] [stderr] 578 | | } [INFO] [stderr] 579 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 550 | } else if p.capacity == 0 { [INFO] [stderr] 551 | [INFO] [stderr] 552 | print_boards(&p); [INFO] [stderr] 553 | [INFO] [stderr] 554 | // Asks the human player to place the ships. [INFO] [stderr] 555 | for i in ships.iter() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/mod.rs:685:13 [INFO] [stderr] | [INFO] [stderr] 685 | return types::SubField::Miss [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `types::SubField::Miss` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/mod.rs:692:13 [INFO] [stderr] | [INFO] [stderr] 692 | return types::SubField::Hit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `types::SubField::Hit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/mod.rs:696:13 [INFO] [stderr] | [INFO] [stderr] 696 | return types::SubField::Hit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `types::SubField::Hit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/mod.rs:700:13 [INFO] [stderr] | [INFO] [stderr] 700 | return types::SubField::Miss [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `types::SubField::Miss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:724:28 [INFO] [stderr] | [INFO] [stderr] 724 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 725 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 726 | | target = 10; [INFO] [stderr] 727 | | } [INFO] [stderr] 728 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 724 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 725 | target = 10; [INFO] [stderr] 726 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:733:32 [INFO] [stderr] | [INFO] [stderr] 733 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 734 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 735 | | target = 10 + col; [INFO] [stderr] 736 | | } [INFO] [stderr] 737 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 733 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 734 | target = 10 + col; [INFO] [stderr] 735 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:742:28 [INFO] [stderr] | [INFO] [stderr] 742 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 743 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 744 | | target = 10 + col; [INFO] [stderr] 745 | | } [INFO] [stderr] 746 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 742 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 743 | target = 10 + col; [INFO] [stderr] 744 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:751:32 [INFO] [stderr] | [INFO] [stderr] 751 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 752 | | if attacker.op_board[row][col + 1] == types::SubField::Water { [INFO] [stderr] 753 | | target = (row * 10) + 1; [INFO] [stderr] 754 | | } [INFO] [stderr] 755 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 751 | } else if attacker.op_board[row][col + 1] == types::SubField::Water { [INFO] [stderr] 752 | target = (row * 10) + 1; [INFO] [stderr] 753 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:760:28 [INFO] [stderr] | [INFO] [stderr] 760 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 761 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 762 | | target = (row + 1) * 10; [INFO] [stderr] 763 | | } [INFO] [stderr] 764 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 760 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 761 | target = (row + 1) * 10; [INFO] [stderr] 762 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:768:28 [INFO] [stderr] | [INFO] [stderr] 768 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 769 | | if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 770 | | target = (row - 1) * 10 + col; [INFO] [stderr] 771 | | } [INFO] [stderr] 772 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 768 | } else if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 769 | target = (row - 1) * 10 + col; [INFO] [stderr] 770 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:778:28 [INFO] [stderr] | [INFO] [stderr] 778 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 779 | | if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 780 | | target = (row - 1) * 10 + col; [INFO] [stderr] 781 | | } [INFO] [stderr] 782 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 778 | } else if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 779 | target = (row - 1) * 10 + col; [INFO] [stderr] 780 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:794:24 [INFO] [stderr] | [INFO] [stderr] 794 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 795 | | if attacker.op_board[row][col - 1] == types::SubField::Water { [INFO] [stderr] 796 | | target = row * 10 + col - 1; [INFO] [stderr] 797 | | } else if attacker.op_board[row][col + 1] == types::SubField::Water { [INFO] [stderr] ... | [INFO] [stderr] 805 | | } [INFO] [stderr] 806 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 794 | } else if attacker.op_board[row][col - 1] == types::SubField::Water { [INFO] [stderr] 795 | target = row * 10 + col - 1; [INFO] [stderr] 796 | } else if attacker.op_board[row][col + 1] == types::SubField::Water { [INFO] [stderr] 797 | target = row * 10 + col + 1; [INFO] [stderr] 798 | } else if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 799 | target = (row - 1) * 10 + col; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:788:28 [INFO] [stderr] | [INFO] [stderr] 788 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 789 | | if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 790 | | target = (row - 1) * 10 + col; [INFO] [stderr] 791 | | } [INFO] [stderr] 792 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 788 | } else if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 789 | target = (row - 1) * 10 + col; [INFO] [stderr] 790 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:801:28 [INFO] [stderr] | [INFO] [stderr] 801 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 802 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 803 | | target = (row + 1) * 10 + col; [INFO] [stderr] 804 | | } [INFO] [stderr] 805 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 801 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 802 | target = (row + 1) * 10 + col; [INFO] [stderr] 803 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/net/types.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | pub const LOCALHOST: &'static str = "127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | /// Command Line Interface /// [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | /// Start /// [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:550:12 [INFO] [stderr] | [INFO] [stderr] 550 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 551 | | if p.capacity == 0 { [INFO] [stderr] 552 | | [INFO] [stderr] 553 | | print_boards(&p); [INFO] [stderr] ... | [INFO] [stderr] 578 | | } [INFO] [stderr] 579 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 550 | } else if p.capacity == 0 { [INFO] [stderr] 551 | [INFO] [stderr] 552 | print_boards(&p); [INFO] [stderr] 553 | [INFO] [stderr] 554 | // Asks the human player to place the ships. [INFO] [stderr] 555 | for i in ships.iter() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/mod.rs:685:13 [INFO] [stderr] | [INFO] [stderr] 685 | return types::SubField::Miss [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `types::SubField::Miss` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/mod.rs:692:13 [INFO] [stderr] | [INFO] [stderr] 692 | return types::SubField::Hit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `types::SubField::Hit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/mod.rs:696:13 [INFO] [stderr] | [INFO] [stderr] 696 | return types::SubField::Hit [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `types::SubField::Hit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/mod.rs:700:13 [INFO] [stderr] | [INFO] [stderr] 700 | return types::SubField::Miss [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `types::SubField::Miss` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:724:28 [INFO] [stderr] | [INFO] [stderr] 724 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 725 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 726 | | target = 10; [INFO] [stderr] 727 | | } [INFO] [stderr] 728 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 724 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 725 | target = 10; [INFO] [stderr] 726 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:733:32 [INFO] [stderr] | [INFO] [stderr] 733 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 734 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 735 | | target = 10 + col; [INFO] [stderr] 736 | | } [INFO] [stderr] 737 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 733 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 734 | target = 10 + col; [INFO] [stderr] 735 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:742:28 [INFO] [stderr] | [INFO] [stderr] 742 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 743 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 744 | | target = 10 + col; [INFO] [stderr] 745 | | } [INFO] [stderr] 746 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 742 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 743 | target = 10 + col; [INFO] [stderr] 744 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:751:32 [INFO] [stderr] | [INFO] [stderr] 751 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 752 | | if attacker.op_board[row][col + 1] == types::SubField::Water { [INFO] [stderr] 753 | | target = (row * 10) + 1; [INFO] [stderr] 754 | | } [INFO] [stderr] 755 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 751 | } else if attacker.op_board[row][col + 1] == types::SubField::Water { [INFO] [stderr] 752 | target = (row * 10) + 1; [INFO] [stderr] 753 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:760:28 [INFO] [stderr] | [INFO] [stderr] 760 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 761 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 762 | | target = (row + 1) * 10; [INFO] [stderr] 763 | | } [INFO] [stderr] 764 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 760 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 761 | target = (row + 1) * 10; [INFO] [stderr] 762 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:768:28 [INFO] [stderr] | [INFO] [stderr] 768 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 769 | | if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 770 | | target = (row - 1) * 10 + col; [INFO] [stderr] 771 | | } [INFO] [stderr] 772 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 768 | } else if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 769 | target = (row - 1) * 10 + col; [INFO] [stderr] 770 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:778:28 [INFO] [stderr] | [INFO] [stderr] 778 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 779 | | if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 780 | | target = (row - 1) * 10 + col; [INFO] [stderr] 781 | | } [INFO] [stderr] 782 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 778 | } else if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 779 | target = (row - 1) * 10 + col; [INFO] [stderr] 780 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:794:24 [INFO] [stderr] | [INFO] [stderr] 794 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 795 | | if attacker.op_board[row][col - 1] == types::SubField::Water { [INFO] [stderr] 796 | | target = row * 10 + col - 1; [INFO] [stderr] 797 | | } else if attacker.op_board[row][col + 1] == types::SubField::Water { [INFO] [stderr] ... | [INFO] [stderr] 805 | | } [INFO] [stderr] 806 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 794 | } else if attacker.op_board[row][col - 1] == types::SubField::Water { [INFO] [stderr] 795 | target = row * 10 + col - 1; [INFO] [stderr] 796 | } else if attacker.op_board[row][col + 1] == types::SubField::Water { [INFO] [stderr] 797 | target = row * 10 + col + 1; [INFO] [stderr] 798 | } else if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 799 | target = (row - 1) * 10 + col; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:788:28 [INFO] [stderr] | [INFO] [stderr] 788 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 789 | | if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 790 | | target = (row - 1) * 10 + col; [INFO] [stderr] 791 | | } [INFO] [stderr] 792 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 788 | } else if attacker.op_board[row - 1][col] == types::SubField::Water { [INFO] [stderr] 789 | target = (row - 1) * 10 + col; [INFO] [stderr] 790 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/model/mod.rs:801:28 [INFO] [stderr] | [INFO] [stderr] 801 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 802 | | if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 803 | | target = (row + 1) * 10 + col; [INFO] [stderr] 804 | | } [INFO] [stderr] 805 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 801 | } else if attacker.op_board[row + 1][col] == types::SubField::Water { [INFO] [stderr] 802 | target = (row + 1) * 10 + col; [INFO] [stderr] 803 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/net/types.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | pub const LOCALHOST: &'static str = "127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | /// Command Line Interface /// [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | /// Start /// [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `battleship`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `battleship`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d8dda6ae167a6a6316b01026ef477eaced83b8f92dfea61048ce3a15dff7eb81"` [INFO] running `"docker" "rm" "-f" "d8dda6ae167a6a6316b01026ef477eaced83b8f92dfea61048ce3a15dff7eb81"` [INFO] [stdout] d8dda6ae167a6a6316b01026ef477eaced83b8f92dfea61048ce3a15dff7eb81