[INFO] updating cached repository Sustrak/LuL [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Sustrak/LuL [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Sustrak/LuL" "work/ex/clippy-test-run/sources/stable/gh/Sustrak/LuL"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Sustrak/LuL'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Sustrak/LuL" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sustrak/LuL"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sustrak/LuL'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6496b5712741dbf76397d9013e8c300aa4480811 [INFO] sha for GitHub repo Sustrak/LuL: 6496b5712741dbf76397d9013e8c300aa4480811 [INFO] validating manifest of Sustrak/LuL on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Sustrak/LuL on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Sustrak/LuL [INFO] finished frobbing Sustrak/LuL [INFO] frobbed toml for Sustrak/LuL written to work/ex/clippy-test-run/sources/stable/gh/Sustrak/LuL/Cargo.toml [INFO] started frobbing Sustrak/LuL [INFO] finished frobbing Sustrak/LuL [INFO] frobbed toml for Sustrak/LuL written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sustrak/LuL/Cargo.toml [INFO] crate Sustrak/LuL has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Sustrak/LuL against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Sustrak/LuL:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6896d7b4da8c33ef416633a5b4b600e8ba2312bd3c8255313c6bae6991db579 [INFO] running `"docker" "start" "-a" "c6896d7b4da8c33ef416633a5b4b600e8ba2312bd3c8255313c6bae6991db579"` [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking LUL v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | return url; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ret` [INFO] [stderr] --> src/main.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | let (ret, json) = get(url, &client); [INFO] [stderr] | ^^^ help: consider using `_ret` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ret` [INFO] [stderr] --> src/main.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | let (ret, json) = get(url, &client); [INFO] [stderr] | ^^^ help: consider using `_ret` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `url` is never read [INFO] [stderr] --> src/main.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | let mut url = String::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `LUL` should have a snake case name such as `lul` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | io::stdin().read_line(&mut summ_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | io::stdin().read_line(&mut aux); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | io::stdin().read_line(&mut aux); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if json["participants"][i]["teamId"].to_string() == "100" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `json["participants"][i]["teamId"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | io::stdin().read_line(&mut aux); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | fn build_url(name: &String, token: &str, id: &str, league: bool) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:123:15 [INFO] [stderr] | [INFO] [stderr] 123 | url = "https://euw.api.pvp.net/api/lol/euw/v1.4/summoner/by-name/".to_string() [INFO] [stderr] | _______________^ [INFO] [stderr] 124 | | + name + "?api_key=" + &token; [INFO] [stderr] | |______________________________________-----^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:128:15 [INFO] [stderr] | [INFO] [stderr] 128 | url = "https://euw.api.pvp.net/api/lol/euw/v2.5/league/by-summoner/".to_string() [INFO] [stderr] | _______________^ [INFO] [stderr] 129 | | + id + "?api_key=" + &token; [INFO] [stderr] | |____________________________________-----^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:133:15 [INFO] [stderr] | [INFO] [stderr] 133 | url = "https://euw.api.pvp.net/observer-mode/rest/consumer/getSpectatorGameInfo/EUW1/".to_string() [INFO] [stderr] | _______________^ [INFO] [stderr] 134 | | + id + "?api_key=" + &token; [INFO] [stderr] | |____________________________________-----^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | return url; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ret` [INFO] [stderr] --> src/main.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | let (ret, json) = get(url, &client); [INFO] [stderr] | ^^^ help: consider using `_ret` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ret` [INFO] [stderr] --> src/main.rs:80:14 [INFO] [stderr] | [INFO] [stderr] 80 | let (ret, json) = get(url, &client); [INFO] [stderr] | ^^^ help: consider using `_ret` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `url` is never read [INFO] [stderr] --> src/main.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | let mut url = String::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `LUL` should have a snake case name such as `lul` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | io::stdin().read_line(&mut summ_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | io::stdin().read_line(&mut aux); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | io::stdin().read_line(&mut aux); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if json["participants"][i]["teamId"].to_string() == "100" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `json["participants"][i]["teamId"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | io::stdin().read_line(&mut aux); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | fn build_url(name: &String, token: &str, id: &str, league: bool) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:123:15 [INFO] [stderr] | [INFO] [stderr] 123 | url = "https://euw.api.pvp.net/api/lol/euw/v1.4/summoner/by-name/".to_string() [INFO] [stderr] | _______________^ [INFO] [stderr] 124 | | + name + "?api_key=" + &token; [INFO] [stderr] | |______________________________________-----^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:128:15 [INFO] [stderr] | [INFO] [stderr] 128 | url = "https://euw.api.pvp.net/api/lol/euw/v2.5/league/by-summoner/".to_string() [INFO] [stderr] | _______________^ [INFO] [stderr] 129 | | + id + "?api_key=" + &token; [INFO] [stderr] | |____________________________________-----^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:133:15 [INFO] [stderr] | [INFO] [stderr] 133 | url = "https://euw.api.pvp.net/observer-mode/rest/consumer/getSpectatorGameInfo/EUW1/".to_string() [INFO] [stderr] | _______________^ [INFO] [stderr] 134 | | + id + "?api_key=" + &token; [INFO] [stderr] | |____________________________________-----^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.09s [INFO] running `"docker" "inspect" "c6896d7b4da8c33ef416633a5b4b600e8ba2312bd3c8255313c6bae6991db579"` [INFO] running `"docker" "rm" "-f" "c6896d7b4da8c33ef416633a5b4b600e8ba2312bd3c8255313c6bae6991db579"` [INFO] [stdout] c6896d7b4da8c33ef416633a5b4b600e8ba2312bd3c8255313c6bae6991db579