[INFO] updating cached repository SunDoge/prettytoml [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SunDoge/prettytoml [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SunDoge/prettytoml" "work/ex/clippy-test-run/sources/stable/gh/SunDoge/prettytoml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SunDoge/prettytoml'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SunDoge/prettytoml" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SunDoge/prettytoml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SunDoge/prettytoml'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 09210d808548a4b104c28f4de22ac50ad2d037fe [INFO] sha for GitHub repo SunDoge/prettytoml: 09210d808548a4b104c28f4de22ac50ad2d037fe [INFO] validating manifest of SunDoge/prettytoml on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SunDoge/prettytoml on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SunDoge/prettytoml [INFO] finished frobbing SunDoge/prettytoml [INFO] frobbed toml for SunDoge/prettytoml written to work/ex/clippy-test-run/sources/stable/gh/SunDoge/prettytoml/Cargo.toml [INFO] started frobbing SunDoge/prettytoml [INFO] finished frobbing SunDoge/prettytoml [INFO] frobbed toml for SunDoge/prettytoml written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SunDoge/prettytoml/Cargo.toml [INFO] crate SunDoge/prettytoml has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SunDoge/prettytoml against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SunDoge/prettytoml:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3d7f99b47a970a002a1955afc5ed773f39a467bcde0d963d2fa5e6e8e4315e2 [INFO] running `"docker" "start" "-a" "f3d7f99b47a970a002a1955afc5ed773f39a467bcde0d963d2fa5e6e8e4315e2"` [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking prettytoml v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `crate::tokens::*` [INFO] [stderr] --> src/lexer/mod.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | use crate::tokens::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `token_stream` [INFO] [stderr] --> src/parser/parser.rs:3:27 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn toml_file_elements(token_stream: TokenStream) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_token_stream` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `token_stream` [INFO] [stderr] --> src/parser/mod.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | fn parse_token_stream(token_stream: TokenStream) {} [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_token_stream` instead [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: function is never used: `toml_file_elements` [INFO] [stderr] --> src/parser/parser.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn toml_file_elements(token_stream: TokenStream) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `head_index` [INFO] [stderr] --> src/parser/tokenstream.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | head_index: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tokens` [INFO] [stderr] --> src/parser/tokenstream.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | tokens: &'a Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `head` [INFO] [stderr] --> src/parser/tokenstream.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn head(&self) -> Option<&Token> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tail` [INFO] [stderr] --> src/parser/tokenstream.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn tail(&self) -> TokenStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `offset` [INFO] [stderr] --> src/parser/tokenstream.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn offset(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `at_end` [INFO] [stderr] --> src/parser/tokenstream.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn at_end(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/parser/tokenstream.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Capture` [INFO] [stderr] --> src/parser/recdesc.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct Capture<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser/recdesc.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn new(token_stream: TokenStream) -> Capture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pending_tokens` [INFO] [stderr] --> src/parser/recdesc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn pending_tokens(&self) -> &TokenStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lexer/mod.rs:78:42 [INFO] [stderr] | [INFO] [stderr] 78 | if is_top_level && !source.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/tokenstream.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(tokens: &Vec) -> TokenStream { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _elements =` [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | let _elements = parse_tokens(tokens); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: unused variable: `token_stream` [INFO] [stderr] --> src/parser/parser.rs:3:27 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn toml_file_elements(token_stream: TokenStream) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_token_stream` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `token_stream` [INFO] [stderr] --> src/parser/mod.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | fn parse_token_stream(token_stream: TokenStream) {} [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_token_stream` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `toml_file_elements` [INFO] [stderr] --> src/parser/parser.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn toml_file_elements(token_stream: TokenStream) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `head_index` [INFO] [stderr] --> src/parser/tokenstream.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | head_index: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tokens` [INFO] [stderr] --> src/parser/tokenstream.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | tokens: &'a Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `head` [INFO] [stderr] --> src/parser/tokenstream.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn head(&self) -> Option<&Token> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tail` [INFO] [stderr] --> src/parser/tokenstream.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn tail(&self) -> TokenStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `offset` [INFO] [stderr] --> src/parser/tokenstream.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn offset(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `at_end` [INFO] [stderr] --> src/parser/tokenstream.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn at_end(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/parser/tokenstream.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Capture` [INFO] [stderr] --> src/parser/recdesc.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub struct Capture<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/parser/recdesc.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn new(token_stream: TokenStream) -> Capture { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pending_tokens` [INFO] [stderr] --> src/parser/recdesc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn pending_tokens(&self) -> &TokenStream { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lexer/mod.rs:78:42 [INFO] [stderr] | [INFO] [stderr] 78 | if is_top_level && !source.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/tokenstream.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(tokens: &Vec) -> TokenStream { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _elements =` [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | let _elements = parse_tokens(tokens); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.03s [INFO] running `"docker" "inspect" "f3d7f99b47a970a002a1955afc5ed773f39a467bcde0d963d2fa5e6e8e4315e2"` [INFO] running `"docker" "rm" "-f" "f3d7f99b47a970a002a1955afc5ed773f39a467bcde0d963d2fa5e6e8e4315e2"` [INFO] [stdout] f3d7f99b47a970a002a1955afc5ed773f39a467bcde0d963d2fa5e6e8e4315e2