[INFO] updating cached repository Stuv7CB/icfp2006-um [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Stuv7CB/icfp2006-um [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Stuv7CB/icfp2006-um" "work/ex/clippy-test-run/sources/stable/gh/Stuv7CB/icfp2006-um"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Stuv7CB/icfp2006-um'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Stuv7CB/icfp2006-um" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stuv7CB/icfp2006-um"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stuv7CB/icfp2006-um'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce6c5a675f7fbb83dd4abcbd9c5cff19a76a9b0d [INFO] sha for GitHub repo Stuv7CB/icfp2006-um: ce6c5a675f7fbb83dd4abcbd9c5cff19a76a9b0d [INFO] validating manifest of Stuv7CB/icfp2006-um on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Stuv7CB/icfp2006-um on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Stuv7CB/icfp2006-um [INFO] finished frobbing Stuv7CB/icfp2006-um [INFO] frobbed toml for Stuv7CB/icfp2006-um written to work/ex/clippy-test-run/sources/stable/gh/Stuv7CB/icfp2006-um/Cargo.toml [INFO] started frobbing Stuv7CB/icfp2006-um [INFO] finished frobbing Stuv7CB/icfp2006-um [INFO] frobbed toml for Stuv7CB/icfp2006-um written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stuv7CB/icfp2006-um/Cargo.toml [INFO] crate Stuv7CB/icfp2006-um has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Stuv7CB/icfp2006-um against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Stuv7CB/icfp2006-um:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 20e1769f99356079f1b36b9a17177f46518d2229d9e213560b6533804cc928ea [INFO] running `"docker" "start" "-a" "20e1769f99356079f1b36b9a17177f46518d2229d9e213560b6533804cc928ea"` [INFO] [stderr] Checking vm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plate.rs:115:35 [INFO] [stderr] | [INFO] [stderr] 115 | let plate_a = Plate::from(0xFFFFFFFF); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plate.rs:121:35 [INFO] [stderr] | [INFO] [stderr] 121 | let plate_a = Plate::from(0x0F0F0F0F); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0F0F_0F0F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/plate.rs:122:35 [INFO] [stderr] | [INFO] [stderr] 122 | let plate_b = Plate::from(0xF0F0F0F0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF0F0_F0F0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/machine.rs:138:45 [INFO] [stderr] | [INFO] [stderr] 138 | let halt_program = vec![Plate::from(0x70000000)]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plate.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn get_operator_data(&self) -> Operator { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plate.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn unwrap(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plate.rs:27:30 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn get_operator_data(&self) -> Operator { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/plate.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn unwrap(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "20e1769f99356079f1b36b9a17177f46518d2229d9e213560b6533804cc928ea"` [INFO] running `"docker" "rm" "-f" "20e1769f99356079f1b36b9a17177f46518d2229d9e213560b6533804cc928ea"` [INFO] [stdout] 20e1769f99356079f1b36b9a17177f46518d2229d9e213560b6533804cc928ea