[INFO] updating cached repository Stuv7CB/guessing-game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Stuv7CB/guessing-game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Stuv7CB/guessing-game" "work/ex/clippy-test-run/sources/stable/gh/Stuv7CB/guessing-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Stuv7CB/guessing-game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Stuv7CB/guessing-game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stuv7CB/guessing-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stuv7CB/guessing-game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 79e7e7cc602f5ecb3224056c5dfd7f7225971db2 [INFO] sha for GitHub repo Stuv7CB/guessing-game: 79e7e7cc602f5ecb3224056c5dfd7f7225971db2 [INFO] validating manifest of Stuv7CB/guessing-game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Stuv7CB/guessing-game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Stuv7CB/guessing-game [INFO] finished frobbing Stuv7CB/guessing-game [INFO] frobbed toml for Stuv7CB/guessing-game written to work/ex/clippy-test-run/sources/stable/gh/Stuv7CB/guessing-game/Cargo.toml [INFO] started frobbing Stuv7CB/guessing-game [INFO] finished frobbing Stuv7CB/guessing-game [INFO] frobbed toml for Stuv7CB/guessing-game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stuv7CB/guessing-game/Cargo.toml [INFO] crate Stuv7CB/guessing-game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Stuv7CB/guessing-game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Stuv7CB/guessing-game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c3dacacb7124111ce22e38520c83a5f6d4c25bde012d229d2d300bef91628a8 [INFO] running `"docker" "start" "-a" "0c3dacacb7124111ce22e38520c83a5f6d4c25bde012d229d2d300bef91628a8"` [INFO] [stderr] Checking num-bigint v0.1.43 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking rusttype v0.4.1 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking glium v0.20.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking conrod v0.58.0 [INFO] [stderr] Checking guessing-game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/app.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | font_path [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/app.rs:103:21 [INFO] [stderr] | [INFO] [stderr] 103 | let font_path = fonts.join(font); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/app.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | font_path [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/app.rs:103:21 [INFO] [stderr] | [INFO] [stderr] 103 | let font_path = fonts.join(font); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/logic.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn update(ref mut ui: conrod::UiCell, ids: &Ids, game: &mut GameData, data: &mut AppData) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | let mut ui = conrod::UiBuilder::new([data.width as f64, data.height as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:104:61 [INFO] [stderr] | [INFO] [stderr] 104 | let mut ui = conrod::UiBuilder::new([data.width as f64, data.height as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/logic.rs:9:15 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn update(ref mut ui: conrod::UiCell, ids: &Ids, game: &mut GameData, data: &mut AppData) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:104:42 [INFO] [stderr] | [INFO] [stderr] 104 | let mut ui = conrod::UiBuilder::new([data.width as f64, data.height as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:104:61 [INFO] [stderr] | [INFO] [stderr] 104 | let mut ui = conrod::UiBuilder::new([data.width as f64, data.height as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(data.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.16s [INFO] running `"docker" "inspect" "0c3dacacb7124111ce22e38520c83a5f6d4c25bde012d229d2d300bef91628a8"` [INFO] running `"docker" "rm" "-f" "0c3dacacb7124111ce22e38520c83a5f6d4c25bde012d229d2d300bef91628a8"` [INFO] [stdout] 0c3dacacb7124111ce22e38520c83a5f6d4c25bde012d229d2d300bef91628a8