[INFO] updating cached repository StreakyCobra/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/StreakyCobra/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/StreakyCobra/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/StreakyCobra/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/StreakyCobra/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/StreakyCobra/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StreakyCobra/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StreakyCobra/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d23f981d7e7ec6261874bfde8f09cbaa5d4fc26 [INFO] sha for GitHub repo StreakyCobra/advent-of-code-2018: 2d23f981d7e7ec6261874bfde8f09cbaa5d4fc26 [INFO] validating manifest of StreakyCobra/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of StreakyCobra/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing StreakyCobra/advent-of-code-2018 [INFO] finished frobbing StreakyCobra/advent-of-code-2018 [INFO] frobbed toml for StreakyCobra/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/StreakyCobra/advent-of-code-2018/Cargo.toml [INFO] started frobbing StreakyCobra/advent-of-code-2018 [INFO] finished frobbing StreakyCobra/advent-of-code-2018 [INFO] frobbed toml for StreakyCobra/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StreakyCobra/advent-of-code-2018/Cargo.toml [INFO] crate StreakyCobra/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting StreakyCobra/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/StreakyCobra/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cdf0a59bf3dcfd652cfb88e0f96984f74f2de93ec3960bc45ababcad90d3e3c1 [INFO] running `"docker" "start" "-a" "cdf0a59bf3dcfd652cfb88e0f96984f74f2de93ec3960bc45ababcad90d3e3c1"` [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_04.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | guard: guard, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_04.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | event: event, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_10.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_10.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_10.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | dx: dx, [INFO] [stderr] | ^^^^^^ help: replace it with: `dx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_10.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | dy: dy, [INFO] [stderr] | ^^^^^^ help: replace it with: `dy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob_10.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob_10.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob_12.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_04.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | guard: guard, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `guard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_04.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | event: event, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_10.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_10.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_10.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | dx: dx, [INFO] [stderr] | ^^^^^^ help: replace it with: `dx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob_10.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | dy: dy, [INFO] [stderr] | ^^^^^^ help: replace it with: `dy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob_10.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob_10.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob_12.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_01.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return changes.iter().sum(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `changes.iter().sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_02.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return two * three; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `two * three` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_03.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_03.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_03.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / return fabric [INFO] [stderr] 92 | | .iter() [INFO] [stderr] 93 | | .map(|row| { [INFO] [stderr] 94 | | row.iter() [INFO] [stderr] 95 | | .map(|&val| if val > 1 { 1 } else { 0 } as u64) [INFO] [stderr] 96 | | .sum::() [INFO] [stderr] 97 | | }).sum(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 91 | fabric [INFO] [stderr] 92 | .iter() [INFO] [stderr] 93 | .map(|row| { [INFO] [stderr] 94 | row.iter() [INFO] [stderr] 95 | .map(|&val| if val > 1 { 1 } else { 0 } as u64) [INFO] [stderr] 96 | .sum::() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_04.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return records; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_04.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return maxguard * maxtime as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `maxguard * maxtime as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_04.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return max.0 * max.1 as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max.0 * max.1 as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_05.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return chars.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chars.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_05.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return min; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return centroids; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `centroids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return ((x2 - x1).abs() + (y2 - y1).abs()) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((x2 - x1).abs() + (y2 - y1).abs()) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return counts; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return *result; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `*result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return grid.iter().flat_map(|row| row.iter()).filter(|&v| v < &limit).count() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `grid.iter().flat_map(|row| row.iter()).filter(|&v| v < &limit).count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_07.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return dependencies; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dependencies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_07.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_07.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return clock - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `clock - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return values; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return sum_first_part(&mut values_copy.iter()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum_first_part(&mut values_copy.iter())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return sum_second_part(&mut values_copy.iter()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum_second_part(&mut values_copy.iter())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_09.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return (num_players, last_marble + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(num_players, last_marble + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_09.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return scores.iter().max().unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `scores.iter().max().unwrap().clone() as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return nom::is_digit(chr) || nom::is_space(chr) || chr == b'-'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `nom::is_digit(chr) || nom::is_space(chr) || chr == b'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return points; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return (width, height, min_x, min_y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(width, height, min_x, min_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return w * h; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `w * h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return (points, i - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(points, i - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_11.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return content.lines().next().unwrap().parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `content.lines().next().unwrap().parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_11.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return power_level; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `power_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_11.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return (max_pos.1 + 1, max_pos.0 + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(max_pos.1 + 1, max_pos.0 + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_11.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return (max_pos.1 + 1, max_pos.0 + 1, max_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(max_pos.1 + 1, max_pos.0 + 1, max_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_12.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return (initial, rules); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(initial, rules)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_12.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / return curr [INFO] [stderr] 80 | | .iter() [INFO] [stderr] 81 | | .enumerate() [INFO] [stderr] 82 | | .map(|(i, v)| if *v { i - OFFSET } else { 0 }) [INFO] [stderr] 83 | | .sum(); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 79 | curr [INFO] [stderr] 80 | .iter() [INFO] [stderr] 81 | .enumerate() [INFO] [stderr] 82 | .map(|(i, v)| if *v { i - OFFSET } else { 0 }) [INFO] [stderr] 83 | .sum() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_12.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / return "Solved with a calculator \\o/ I noticed that after a while the [INFO] [stderr] 88 | | \tpattern keep getting the same, only shifting to the right. So by looking [INFO] [stderr] 89 | | \tat the increase at each step and doing some maths I got to the right answer."; [INFO] [stderr] | |____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 87 | "Solved with a calculator \\o/ I noticed that after a while the [INFO] [stderr] 88 | \tpattern keep getting the same, only shifting to the right. So by looking [INFO] [stderr] 89 | \tat the increase at each step and doing some maths I got to the right answer." [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_13.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return self.x.cmp(&other.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x.cmp(&other.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_13.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return self.y.cmp(&other.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y.cmp(&other.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_13.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return (grid, carts); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(grid, carts)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_13.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_14.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return content.lines().nth(0).unwrap().trim().parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `content.lines().nth(0).unwrap().trim().parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_14.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / return recipes [INFO] [stderr] 37 | | .iter() [INFO] [stderr] 38 | | .skip(number) [INFO] [stderr] 39 | | .take(10) [INFO] [stderr] 40 | | .map(|d| char::from_digit((*d) as u32, 10).unwrap()) [INFO] [stderr] 41 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | recipes [INFO] [stderr] 37 | .iter() [INFO] [stderr] 38 | .skip(number) [INFO] [stderr] 39 | .take(10) [INFO] [stderr] 40 | .map(|d| char::from_digit((*d) as u32, 10).unwrap()) [INFO] [stderr] 41 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return content; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_01.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return changes.iter().sum(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `changes.iter().sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_02.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return two * three; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `two * three` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_03.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_03.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_03.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / return fabric [INFO] [stderr] 92 | | .iter() [INFO] [stderr] 93 | | .map(|row| { [INFO] [stderr] 94 | | row.iter() [INFO] [stderr] 95 | | .map(|&val| if val > 1 { 1 } else { 0 } as u64) [INFO] [stderr] 96 | | .sum::() [INFO] [stderr] 97 | | }).sum(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 91 | fabric [INFO] [stderr] 92 | .iter() [INFO] [stderr] 93 | .map(|row| { [INFO] [stderr] 94 | row.iter() [INFO] [stderr] 95 | .map(|&val| if val > 1 { 1 } else { 0 } as u64) [INFO] [stderr] 96 | .sum::() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_04.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | return records; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_04.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | return maxguard * maxtime as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `maxguard * maxtime as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_04.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | return max.0 * max.1 as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max.0 * max.1 as u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_05.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return chars.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chars.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_05.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return min; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return centroids; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `centroids` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return ((x2 - x1).abs() + (y2 - y1).abs()) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((x2 - x1).abs() + (y2 - y1).abs()) as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return counts; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | return *result; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `*result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_06.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return grid.iter().flat_map(|row| row.iter()).filter(|&v| v < &limit).count() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `grid.iter().flat_map(|row| row.iter()).filter(|&v| v < &limit).count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_07.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return dependencies; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dependencies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_07.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_07.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return clock - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `clock - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return values; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return sum_first_part(&mut values_copy.iter()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum_first_part(&mut values_copy.iter())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return sum_second_part(&mut values_copy.iter()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum_second_part(&mut values_copy.iter())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_08.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_09.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return (num_players, last_marble + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(num_players, last_marble + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_09.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return scores.iter().max().unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `scores.iter().max().unwrap().clone() as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prob_09.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | 146373 [INFO] [stderr] | ^^^^^^ help: consider: `146_373` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return nom::is_digit(chr) || nom::is_space(chr) || chr == b'-'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `nom::is_digit(chr) || nom::is_space(chr) || chr == b'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return points; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return (width, height, min_x, min_y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(width, height, min_x, min_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return w * h; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `w * h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_10.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return (points, i - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(points, i - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_11.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return content.lines().next().unwrap().parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `content.lines().next().unwrap().parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_11.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return power_level; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `power_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_11.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return (max_pos.1 + 1, max_pos.0 + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(max_pos.1 + 1, max_pos.0 + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_11.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return (max_pos.1 + 1, max_pos.0 + 1, max_size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(max_pos.1 + 1, max_pos.0 + 1, max_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_12.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return (initial, rules); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(initial, rules)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_12.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / return curr [INFO] [stderr] 80 | | .iter() [INFO] [stderr] 81 | | .enumerate() [INFO] [stderr] 82 | | .map(|(i, v)| if *v { i - OFFSET } else { 0 }) [INFO] [stderr] 83 | | .sum(); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 79 | curr [INFO] [stderr] 80 | .iter() [INFO] [stderr] 81 | .enumerate() [INFO] [stderr] 82 | .map(|(i, v)| if *v { i - OFFSET } else { 0 }) [INFO] [stderr] 83 | .sum() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_12.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / return "Solved with a calculator \\o/ I noticed that after a while the [INFO] [stderr] 88 | | \tpattern keep getting the same, only shifting to the right. So by looking [INFO] [stderr] 89 | | \tat the increase at each step and doing some maths I got to the right answer."; [INFO] [stderr] | |____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 87 | "Solved with a calculator \\o/ I noticed that after a while the [INFO] [stderr] 88 | \tpattern keep getting the same, only shifting to the right. So by looking [INFO] [stderr] 89 | \tat the increase at each step and doing some maths I got to the right answer." [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_13.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return self.x.cmp(&other.x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x.cmp(&other.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_13.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return self.y.cmp(&other.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.y.cmp(&other.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_13.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return (grid, carts); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(grid, carts)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_13.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_14.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return content.lines().nth(0).unwrap().trim().parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `content.lines().nth(0).unwrap().trim().parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob_14.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / return recipes [INFO] [stderr] 37 | | .iter() [INFO] [stderr] 38 | | .skip(number) [INFO] [stderr] 39 | | .take(10) [INFO] [stderr] 40 | | .map(|d| char::from_digit((*d) as u32, 10).unwrap()) [INFO] [stderr] 41 | | .collect(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | recipes [INFO] [stderr] 37 | .iter() [INFO] [stderr] 38 | .skip(number) [INFO] [stderr] 39 | .take(10) [INFO] [stderr] 40 | .map(|d| char::from_digit((*d) as u32, 10).unwrap()) [INFO] [stderr] 41 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return content; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_01.rs:16:30 [INFO] [stderr] | [INFO] [stderr] 16 | fn solve_first_part(changes: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_01.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | fn solve_second_part(changes: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_02.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | fn solve_first_part(boxs: &Vec<&str>) -> u64 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/prob_02.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / if count.contains_key(&chr) { [INFO] [stderr] 23 | | let current = count.get(&chr).unwrap().clone(); [INFO] [stderr] 24 | | count.insert(chr, current + 1); [INFO] [stderr] 25 | | } else { [INFO] [stderr] 26 | | count.insert(chr, 1); [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____________^ help: consider using: `count.entry(chr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_02.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | let current = count.get(&chr).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*count.get(&chr).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prob_02.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | let current = count.get(&chr).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count[&chr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_02.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | fn solve_second_part(boxs: &Vec<&str>) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `boxs`. [INFO] [stderr] --> src/prob_02.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for j in i..boxs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in boxs.iter().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `fabric`. [INFO] [stderr] --> src/prob_03.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | for j in self.top..self.top + self.height { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 42 | for in fabric.iter_mut().skip(self.top).take(self.height) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/prob_03.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for (_id, square) in squares { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 88 | for square in squares.values() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/prob_04.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_04.rs:75:30 [INFO] [stderr] | [INFO] [stderr] 75 | fn solve_first_part(records: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Record]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob_04.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | Event::Sleep => from = record.datetime.minute() as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(record.datetime.minute())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob_04.rs:83:35 [INFO] [stderr] | [INFO] [stderr] 83 | let length: u64 = record.datetime.minute() as u64 - from; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(record.datetime.minute())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/prob_04.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | / if totals.contains_key(&record.guard) { [INFO] [stderr] 85 | | let total = totals.get(&record.guard).unwrap().clone(); [INFO] [stderr] 86 | | totals.insert(record.guard, total + length); [INFO] [stderr] 87 | | } else { [INFO] [stderr] 88 | | totals.insert(record.guard, length); [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________________^ help: consider using: `totals.entry(record.guard)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_04.rs:85:33 [INFO] [stderr] | [INFO] [stderr] 85 | let total = totals.get(&record.guard).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*totals.get(&record.guard).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prob_04.rs:85:33 [INFO] [stderr] | [INFO] [stderr] 85 | let total = totals.get(&record.guard).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&totals[&record.guard]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob_04.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | Event::Sleep => from = record.datetime.minute() as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(record.datetime.minute())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob_04.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | let to: u64 = record.datetime.minute() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(record.datetime.minute())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `minutes`. [INFO] [stderr] --> src/prob_04.rs:104:26 [INFO] [stderr] | [INFO] [stderr] 104 | for i in from as usize..to as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for in minutes.iter_mut().take(to as usize).skip(from as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_04.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | fn solve_second_part(records: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Record]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/prob_04.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | / if !stats.contains_key(&record.guard) { [INFO] [stderr] 125 | | let mut minutes = [0; 60]; [INFO] [stderr] 126 | | stats.insert(record.guard, minutes); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________________^ help: consider using: `stats.entry(record.guard)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `minutes` [INFO] [stderr] --> src/prob_04.rs:129:26 [INFO] [stderr] | [INFO] [stderr] 129 | for i in from..to { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 129 | for (i, ) in minutes.iter_mut().enumerate().take(to).skip(from) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_06.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | let count = counts.get(&value).unwrap_or(&0).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*counts.get(&value).unwrap_or(&0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_06.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | fn solve_first_part(centroids: &Vec<(usize, usize)>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `grid`. [INFO] [stderr] --> src/prob_06.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | for j in 0..grid.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in &mut grid { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_06.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | fn solve_second_part(centroids: &Vec<(usize, usize)>, limit: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `grid`. [INFO] [stderr] --> src/prob_06.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | for j in 0..grid.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 75 | for in &mut grid { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/prob_06.rs:84:63 [INFO] [stderr] | [INFO] [stderr] 84 | return grid.iter().flat_map(|row| row.iter()).filter(|&v| v < &limit).count() [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/prob_07.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | dependencies.entry(a).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/prob_07.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | dependencies.entry(b).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prob_07.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | .filter(|&(_, d)| d.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_07.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|(c, _)| c.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prob_07.rs:79:31 [INFO] [stderr] | [INFO] [stderr] 79 | .filter(|&(_, d)| d.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_07.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | .map(|(c, _)| c.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_08.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | fn solve_first_part(values: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 20 | fn solve_first_part(values: &[u8]) -> usize { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `values.clone()` to [INFO] [stderr] | [INFO] [stderr] 21 | let values_copy = values.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let nchd: usize = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | let nval: usize = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:36:19 [INFO] [stderr] | [INFO] [stderr] 36 | let val = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_08.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | fn solve_second_part(values: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 42 | fn solve_second_part(values: &[u8]) -> usize { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `values.clone()` to [INFO] [stderr] | [INFO] [stderr] 43 | let values_copy = values.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | let nchd: usize = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | let nval: usize = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `subtree`. [INFO] [stderr] --> src/prob_08.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for n in 0..nchd { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for in subtree.iter_mut().take(nchd) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | let val = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_09.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | return scores.iter().max().unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*scores.iter().max().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/prob_10.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / if let Some((_, a)) = light(line.trim().as_bytes()).ok() { [INFO] [stderr] 39 | | let ((x, y), (dx, dy)) = a; [INFO] [stderr] 40 | | let x: i64 = str::from_utf8(x).unwrap().trim().parse().unwrap(); [INFO] [stderr] 41 | | let y: i64 = str::from_utf8(y).unwrap().trim().parse().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 49 | | }) [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok((_, a))` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_10.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | fn dimension(points: &Vec) -> (i64, i64, i64, i64) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_10.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | fn entropy(points: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_10.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | fn print(points: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_10.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | fn solve_points(points: &Vec) -> (Vec, i64) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 103 | fn solve_points(points: &[Point]) -> (Vec, i64) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: change `points.clone()` to [INFO] [stderr] | [INFO] [stderr] 104 | let mut points = points.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `grid` [INFO] [stderr] --> src/prob_11.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..grid.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 31 | for (i, ) in grid.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `grid` [INFO] [stderr] --> src/prob_11.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | for i in 0..grid.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for (i, ) in grid.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/prob_12.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | let outcome = if chars[9] == '#' { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `chars[9] == '#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_12.rs:56:68 [INFO] [stderr] | [INFO] [stderr] 56 | fn generation(curr: &[bool; SIZE], next: &mut [bool; SIZE], rules: &Vec<([bool; 5], bool)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[([bool; 5], bool)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_12.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | let mut curr: [bool; SIZE] = initial.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_12.rs:74:34 [INFO] [stderr] | [INFO] [stderr] 74 | let mut next: [bool; SIZE] = initial.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:132:15 [INFO] [stderr] | [INFO] [stderr] 132 | fn step(grid: &Grid, cart: &mut Cart) -> bool { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:180:27 [INFO] [stderr] | [INFO] [stderr] 180 | fn solve_first_part(grid: &Grid, carts: &Vec) -> (usize, usize) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:180:41 [INFO] [stderr] | [INFO] [stderr] 180 | fn solve_first_part(grid: &Grid, carts: &Vec) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Cart]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:198:28 [INFO] [stderr] | [INFO] [stderr] 198 | fn solve_second_part(grid: &Grid, carts: &Vec) -> (usize, usize) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:198:42 [INFO] [stderr] | [INFO] [stderr] 198 | fn solve_second_part(grid: &Grid, carts: &Vec) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Cart]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_13.rs:210:31 [INFO] [stderr] | [INFO] [stderr] 210 | .map(|(i, _)| i.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/prob_14.rs:28:38 [INFO] [stderr] | [INFO] [stderr] 28 | recipes[len] = d as u8 - '0' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/prob_14.rs:40:35 [INFO] [stderr] | [INFO] [stderr] 40 | .map(|d| char::from_digit((*d) as u32, 10).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from((*d))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/prob_14.rs:45:60 [INFO] [stderr] | [INFO] [stderr] 45 | let digits: Vec = number.chars().map(|d| d as u8 - '0' as u8).collect(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/prob_14.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | recipes.push(d as u8 - '0' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_01.rs:16:30 [INFO] [stderr] | [INFO] [stderr] 16 | fn solve_first_part(changes: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_01.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | fn solve_second_part(changes: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_02.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | fn solve_first_part(boxs: &Vec<&str>) -> u64 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/prob_02.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / if count.contains_key(&chr) { [INFO] [stderr] 23 | | let current = count.get(&chr).unwrap().clone(); [INFO] [stderr] 24 | | count.insert(chr, current + 1); [INFO] [stderr] 25 | | } else { [INFO] [stderr] 26 | | count.insert(chr, 1); [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____________^ help: consider using: `count.entry(chr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_02.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | let current = count.get(&chr).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*count.get(&chr).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prob_02.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | let current = count.get(&chr).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&count[&chr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_02.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | fn solve_second_part(boxs: &Vec<&str>) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `boxs`. [INFO] [stderr] --> src/prob_02.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for j in i..boxs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in boxs.iter().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `fabric`. [INFO] [stderr] --> src/prob_03.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | for j in self.top..self.top + self.height { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 42 | for in fabric.iter_mut().skip(self.top).take(self.height) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/prob_03.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for (_id, square) in squares { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 88 | for square in squares.values() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/prob_04.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_04.rs:75:30 [INFO] [stderr] | [INFO] [stderr] 75 | fn solve_first_part(records: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Record]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob_04.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | Event::Sleep => from = record.datetime.minute() as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(record.datetime.minute())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob_04.rs:83:35 [INFO] [stderr] | [INFO] [stderr] 83 | let length: u64 = record.datetime.minute() as u64 - from; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(record.datetime.minute())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/prob_04.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | / if totals.contains_key(&record.guard) { [INFO] [stderr] 85 | | let total = totals.get(&record.guard).unwrap().clone(); [INFO] [stderr] 86 | | totals.insert(record.guard, total + length); [INFO] [stderr] 87 | | } else { [INFO] [stderr] 88 | | totals.insert(record.guard, length); [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________________^ help: consider using: `totals.entry(record.guard)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_04.rs:85:33 [INFO] [stderr] | [INFO] [stderr] 85 | let total = totals.get(&record.guard).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*totals.get(&record.guard).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/prob_04.rs:85:33 [INFO] [stderr] | [INFO] [stderr] 85 | let total = totals.get(&record.guard).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&totals[&record.guard]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob_04.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | Event::Sleep => from = record.datetime.minute() as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(record.datetime.minute())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob_04.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | let to: u64 = record.datetime.minute() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(record.datetime.minute())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `minutes`. [INFO] [stderr] --> src/prob_04.rs:104:26 [INFO] [stderr] | [INFO] [stderr] 104 | for i in from as usize..to as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for in minutes.iter_mut().take(to as usize).skip(from as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_04.rs:114:31 [INFO] [stderr] | [INFO] [stderr] 114 | fn solve_second_part(records: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Record]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/prob_04.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | / if !stats.contains_key(&record.guard) { [INFO] [stderr] 125 | | let mut minutes = [0; 60]; [INFO] [stderr] 126 | | stats.insert(record.guard, minutes); [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________________^ help: consider using: `stats.entry(record.guard)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `minutes` [INFO] [stderr] --> src/prob_04.rs:129:26 [INFO] [stderr] | [INFO] [stderr] 129 | for i in from..to { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 129 | for (i, ) in minutes.iter_mut().enumerate().take(to).skip(from) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_06.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | let count = counts.get(&value).unwrap_or(&0).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*counts.get(&value).unwrap_or(&0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_06.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | fn solve_first_part(centroids: &Vec<(usize, usize)>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `grid`. [INFO] [stderr] --> src/prob_06.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | for j in 0..grid.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in &mut grid { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_06.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | fn solve_second_part(centroids: &Vec<(usize, usize)>, limit: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `grid`. [INFO] [stderr] --> src/prob_06.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | for j in 0..grid.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 75 | for in &mut grid { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/prob_06.rs:84:63 [INFO] [stderr] | [INFO] [stderr] 84 | return grid.iter().flat_map(|row| row.iter()).filter(|&v| v < &limit).count() [INFO] [stderr] | ^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/prob_07.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | dependencies.entry(a).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/prob_07.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | dependencies.entry(b).or_insert(HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prob_07.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | .filter(|&(_, d)| d.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_07.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|(c, _)| c.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prob_07.rs:79:31 [INFO] [stderr] | [INFO] [stderr] 79 | .filter(|&(_, d)| d.len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `d.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_07.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | .map(|(c, _)| c.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_08.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | fn solve_first_part(values: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 20 | fn solve_first_part(values: &[u8]) -> usize { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `values.clone()` to [INFO] [stderr] | [INFO] [stderr] 21 | let values_copy = values.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let nchd: usize = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | let nval: usize = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:36:19 [INFO] [stderr] | [INFO] [stderr] 36 | let val = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_08.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | fn solve_second_part(values: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 42 | fn solve_second_part(values: &[u8]) -> usize { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `values.clone()` to [INFO] [stderr] | [INFO] [stderr] 43 | let values_copy = values.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | let nchd: usize = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | let nval: usize = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is only used to index `subtree`. [INFO] [stderr] --> src/prob_08.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for n in 0..nchd { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for in subtree.iter_mut().take(nchd) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_08.rs:59:19 [INFO] [stderr] | [INFO] [stderr] 59 | let val = values.next().unwrap().clone() as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*values.next().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_09.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | return scores.iter().max().unwrap().clone() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*scores.iter().max().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/prob_10.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / if let Some((_, a)) = light(line.trim().as_bytes()).ok() { [INFO] [stderr] 39 | | let ((x, y), (dx, dy)) = a; [INFO] [stderr] 40 | | let x: i64 = str::from_utf8(x).unwrap().trim().parse().unwrap(); [INFO] [stderr] 41 | | let y: i64 = str::from_utf8(y).unwrap().trim().parse().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 49 | | }) [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok((_, a))` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_10.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | fn dimension(points: &Vec) -> (i64, i64, i64, i64) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_10.rs:79:20 [INFO] [stderr] | [INFO] [stderr] 79 | fn entropy(points: &Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_10.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | fn print(points: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_10.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | fn solve_points(points: &Vec) -> (Vec, i64) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 103 | fn solve_points(points: &[Point]) -> (Vec, i64) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: change `points.clone()` to [INFO] [stderr] | [INFO] [stderr] 104 | let mut points = points.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `grid` [INFO] [stderr] --> src/prob_11.rs:31:14 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..grid.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 31 | for (i, ) in grid.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `grid` [INFO] [stderr] --> src/prob_11.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | for i in 0..grid.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for (i, ) in grid.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/prob_12.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | let outcome = if chars[9] == '#' { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `chars[9] == '#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_12.rs:56:68 [INFO] [stderr] | [INFO] [stderr] 56 | fn generation(curr: &[bool; SIZE], next: &mut [bool; SIZE], rules: &Vec<([bool; 5], bool)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[([bool; 5], bool)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_12.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | let mut curr: [bool; SIZE] = initial.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_12.rs:74:34 [INFO] [stderr] | [INFO] [stderr] 74 | let mut next: [bool; SIZE] = initial.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*initial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:132:15 [INFO] [stderr] | [INFO] [stderr] 132 | fn step(grid: &Grid, cart: &mut Cart) -> bool { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:180:27 [INFO] [stderr] | [INFO] [stderr] 180 | fn solve_first_part(grid: &Grid, carts: &Vec) -> (usize, usize) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:180:41 [INFO] [stderr] | [INFO] [stderr] 180 | fn solve_first_part(grid: &Grid, carts: &Vec) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Cart]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:198:28 [INFO] [stderr] | [INFO] [stderr] 198 | fn solve_second_part(grid: &Grid, carts: &Vec) -> (usize, usize) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/prob_13.rs:198:42 [INFO] [stderr] | [INFO] [stderr] 198 | fn solve_second_part(grid: &Grid, carts: &Vec) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Cart]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prob_13.rs:210:31 [INFO] [stderr] | [INFO] [stderr] 210 | .map(|(i, _)| i.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/prob_14.rs:28:38 [INFO] [stderr] | [INFO] [stderr] 28 | recipes[len] = d as u8 - '0' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/prob_14.rs:40:35 [INFO] [stderr] | [INFO] [stderr] 40 | .map(|d| char::from_digit((*d) as u32, 10).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from((*d))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/prob_14.rs:45:60 [INFO] [stderr] | [INFO] [stderr] 45 | let digits: Vec = number.chars().map(|d| d as u8 - '0' as u8).collect(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/prob_14.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | recipes.push(d as u8 - '0' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.45s [INFO] running `"docker" "inspect" "cdf0a59bf3dcfd652cfb88e0f96984f74f2de93ec3960bc45ababcad90d3e3c1"` [INFO] running `"docker" "rm" "-f" "cdf0a59bf3dcfd652cfb88e0f96984f74f2de93ec3960bc45ababcad90d3e3c1"` [INFO] [stdout] cdf0a59bf3dcfd652cfb88e0f96984f74f2de93ec3960bc45ababcad90d3e3c1