[INFO] updating cached repository Stigjb/firetris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Stigjb/firetris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Stigjb/firetris" "work/ex/clippy-test-run/sources/stable/gh/Stigjb/firetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Stigjb/firetris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Stigjb/firetris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stigjb/firetris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stigjb/firetris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8de2ddcb1d85f7297cae70fb01aeb67b62cda1f [INFO] sha for GitHub repo Stigjb/firetris: f8de2ddcb1d85f7297cae70fb01aeb67b62cda1f [INFO] validating manifest of Stigjb/firetris on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Stigjb/firetris on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Stigjb/firetris [INFO] finished frobbing Stigjb/firetris [INFO] frobbed toml for Stigjb/firetris written to work/ex/clippy-test-run/sources/stable/gh/Stigjb/firetris/Cargo.toml [INFO] started frobbing Stigjb/firetris [INFO] finished frobbing Stigjb/firetris [INFO] frobbed toml for Stigjb/firetris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stigjb/firetris/Cargo.toml [INFO] crate Stigjb/firetris has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Stigjb/firetris against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Stigjb/firetris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a0ed63dc41d7312d2f3aacb1773cee316b0b633b9699134bb268b20444dc2500 [INFO] running `"docker" "start" "-a" "a0ed63dc41d7312d2f3aacb1773cee316b0b633b9699134bb268b20444dc2500"` [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.57.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking firetris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/firetris_controller.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | firetris: firetris, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `firetris` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/firetris_view.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | FiretrisView { settings: settings } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/firetris_controller.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | firetris: firetris, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `firetris` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/firetris_view.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | FiretrisView { settings: settings } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `firetris::Firetris` [INFO] [stderr] --> src/firetris.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new() -> Firetris { [INFO] [stderr] 137 | | Firetris { [INFO] [stderr] 138 | | cells: [[None; WIDTH]; HEIGHT], [INFO] [stderr] 139 | | score: 0, [INFO] [stderr] ... | [INFO] [stderr] 143 | | } [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/firetris.rs:169:36 [INFO] [stderr] | [INFO] [stderr] 169 | let new_last_row = self.cells[i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cells[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/firetris_controller.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | possible_next.map(|p| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 73 | || if !self.collision(&p) { [INFO] [stderr] 74 | || self.firetris.active_piece = Some(p); [INFO] [stderr] 75 | || } [INFO] [stderr] 76 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(p) = possible_next { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `firetris_view::FiretrisViewSettings` [INFO] [stderr] --> src/firetris_view.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> FiretrisViewSettings { [INFO] [stderr] 22 | | FiretrisViewSettings { [INFO] [stderr] 23 | | position: [100.0, 20.0], [INFO] [stderr] 24 | | size: [128.0, 512.0], [INFO] [stderr] 25 | | background_color: [0.1, 0.1, 0.5, 1.0], [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/firetris_view.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/firetris_view.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | (block[0] + x) as f64 * cellsize + 0.5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(block[0] + x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/firetris_view.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | (block[1] + y) as f64 * cellsize + 0.5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(block[1] + y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/firetris_view.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | firetris.cells[row][col].as_ref().map(|color| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 83 | || let block_rect = [ [INFO] [stderr] 84 | || col as f64 * cellsize + 0.5, [INFO] [stderr] 85 | || row as f64 * cellsize + 0.5, [INFO] [stderr] ... || [INFO] [stderr] 89 | || Rectangle::new(color.clone()).draw(block_rect, &c.draw_state, c.transform, g); [INFO] [stderr] 90 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(color) = firetris.cells[row][col].as_ref() { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/firetris_view.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | Rectangle::new(color.clone()).draw(block_rect, &c.draw_state, c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `firetris::Firetris` [INFO] [stderr] --> src/firetris.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new() -> Firetris { [INFO] [stderr] 137 | | Firetris { [INFO] [stderr] 138 | | cells: [[None; WIDTH]; HEIGHT], [INFO] [stderr] 139 | | score: 0, [INFO] [stderr] ... | [INFO] [stderr] 143 | | } [INFO] [stderr] 144 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/firetris.rs:169:36 [INFO] [stderr] | [INFO] [stderr] 169 | let new_last_row = self.cells[i].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cells[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/firetris_controller.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | possible_next.map(|p| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 73 | || if !self.collision(&p) { [INFO] [stderr] 74 | || self.firetris.active_piece = Some(p); [INFO] [stderr] 75 | || } [INFO] [stderr] 76 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(p) = possible_next { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `firetris_view::FiretrisViewSettings` [INFO] [stderr] --> src/firetris_view.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> FiretrisViewSettings { [INFO] [stderr] 22 | | FiretrisViewSettings { [INFO] [stderr] 23 | | position: [100.0, 20.0], [INFO] [stderr] 24 | | size: [128.0, 512.0], [INFO] [stderr] 25 | | background_color: [0.1, 0.1, 0.5, 1.0], [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/firetris_view.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/firetris_view.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | (block[0] + x) as f64 * cellsize + 0.5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(block[0] + x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/firetris_view.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | (block[1] + y) as f64 * cellsize + 0.5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(block[1] + y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/firetris_view.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | firetris.cells[row][col].as_ref().map(|color| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 83 | || let block_rect = [ [INFO] [stderr] 84 | || col as f64 * cellsize + 0.5, [INFO] [stderr] 85 | || row as f64 * cellsize + 0.5, [INFO] [stderr] ... || [INFO] [stderr] 89 | || Rectangle::new(color.clone()).draw(block_rect, &c.draw_state, c.transform, g); [INFO] [stderr] 90 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(color) = firetris.cells[row][col].as_ref() { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/firetris_view.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | Rectangle::new(color.clone()).draw(block_rect, &c.draw_state, c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.17s [INFO] running `"docker" "inspect" "a0ed63dc41d7312d2f3aacb1773cee316b0b633b9699134bb268b20444dc2500"` [INFO] running `"docker" "rm" "-f" "a0ed63dc41d7312d2f3aacb1773cee316b0b633b9699134bb268b20444dc2500"` [INFO] [stdout] a0ed63dc41d7312d2f3aacb1773cee316b0b633b9699134bb268b20444dc2500