[INFO] updating cached repository StephenAshmore/synth [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/StephenAshmore/synth [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/StephenAshmore/synth" "work/ex/clippy-test-run/sources/stable/gh/StephenAshmore/synth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/StephenAshmore/synth'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/StephenAshmore/synth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StephenAshmore/synth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StephenAshmore/synth'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b24f7a1a1c2b5157a2c8fa5c511e623d4c43901 [INFO] sha for GitHub repo StephenAshmore/synth: 9b24f7a1a1c2b5157a2c8fa5c511e623d4c43901 [INFO] validating manifest of StephenAshmore/synth on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of StephenAshmore/synth on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing StephenAshmore/synth [INFO] finished frobbing StephenAshmore/synth [INFO] frobbed toml for StephenAshmore/synth written to work/ex/clippy-test-run/sources/stable/gh/StephenAshmore/synth/Cargo.toml [INFO] started frobbing StephenAshmore/synth [INFO] finished frobbing StephenAshmore/synth [INFO] frobbed toml for StephenAshmore/synth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StephenAshmore/synth/Cargo.toml [INFO] crate StephenAshmore/synth has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting StephenAshmore/synth against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/StephenAshmore/synth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32f4438d9944740bef1fe65b7d0f2ee0a4d326994bc00ee4b03084fc01809149 [INFO] running `"docker" "start" "-a" "32f4438d9944740bef1fe65b7d0f2ee0a4d326994bc00ee4b03084fc01809149"` [INFO] [stderr] Checking terminal_size v0.1.7 [INFO] [stderr] Checking synth v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/cli/display.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | print!("\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/cli/display.rs:92:41 [INFO] [stderr] | [INFO] [stderr] 92 | print!("{}[{};{}f", 27 as char, 1, 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/cli/display.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | print!("{}[{};{}f", 27 as char, 1, 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/cli/display.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | print!("\r\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/cli/display.rs:92:41 [INFO] [stderr] | [INFO] [stderr] 92 | print!("{}[{};{}f", 27 as char, 1, 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/cli/display.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | print!("{}[{};{}f", 27 as char, 1, 1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `Sender` [INFO] [stderr] --> src/main.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use std::sync::mpsc::{Sender, Receiver}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc` [INFO] [stderr] --> src/cli/interface.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::sync::mpsc; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli/interface.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return stdin.lock().lines().next().unwrap().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `stdin.lock().lines().next().unwrap().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufRead` [INFO] [stderr] --> src/cli/display.rs:1:28 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{self, Write, BufRead}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli/display.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Receiver`, `Sender` [INFO] [stderr] --> src/main.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | use std::sync::mpsc::{Sender, Receiver}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc` [INFO] [stderr] --> src/cli/interface.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::sync::mpsc; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli/interface.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return stdin.lock().lines().next().unwrap().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `stdin.lock().lines().next().unwrap().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufRead` [INFO] [stderr] --> src/cli/display.rs:1:28 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{self, Write, BufRead}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli/display.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `error` [INFO] [stderr] --> src/cli/display.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | Err(error) => String::from(""), [INFO] [stderr] | ^^^^^ help: consider using `_error` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer_pointer` [INFO] [stderr] --> src/cli/display.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let mut buffer_pointer = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_buffer_pointer` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let mut user_finished = false; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] warning: unused variable: `error` [INFO] [stderr] --> src/cli/display.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | Err(error) => String::from(""), [INFO] [stderr] | ^^^^^ help: consider using `_error` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buffer_pointer` [INFO] [stderr] --> src/cli/display.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let mut buffer_pointer = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_buffer_pointer` instead [INFO] [stderr] [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cli/display.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut buffer_pointer = 0; [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let mut user_finished = false; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: field is never used: `m_sender` [INFO] [stderr] --> src/cli/interface.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | m_sender: Sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/cli/display.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut buffer_pointer = 0; [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `m_sender` [INFO] [stderr] --> src/cli/interface.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | m_sender: Sender, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cli/display.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match cmd.as_str() { [INFO] [stderr] 45 | | "exit" => self.m_user_finished = true, [INFO] [stderr] 46 | | _ => (), [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "exit" = cmd.as_str() { self.m_user_finished = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cli/display.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | } else if x == self.m_terminal_width - 1 { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 68 | | print!("|") [INFO] [stderr] 69 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cli/display.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | if x == 0 { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 66 | | print!("|") [INFO] [stderr] 67 | | } else if x == self.m_terminal_width - 1 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/cli/display.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cli/display.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / match cmd.as_str() { [INFO] [stderr] 45 | | "exit" => self.m_user_finished = true, [INFO] [stderr] 46 | | _ => (), [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ help: try this: `if let "exit" = cmd.as_str() { self.m_user_finished = true }` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cli/display.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | } else if x == self.m_terminal_width - 1 { [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 68 | | print!("|") [INFO] [stderr] 69 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cli/display.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | if x == 0 { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 66 | | print!("|") [INFO] [stderr] 67 | | } else if x == self.m_terminal_width - 1 { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/cli/display.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:27:11 [INFO] [stderr] | [INFO] [stderr] 27 | while !user_finished { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:27:11 [INFO] [stderr] | [INFO] [stderr] 27 | while !user_finished { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: Could not compile `synth`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `synth`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "32f4438d9944740bef1fe65b7d0f2ee0a4d326994bc00ee4b03084fc01809149"` [INFO] running `"docker" "rm" "-f" "32f4438d9944740bef1fe65b7d0f2ee0a4d326994bc00ee4b03084fc01809149"` [INFO] [stdout] 32f4438d9944740bef1fe65b7d0f2ee0a4d326994bc00ee4b03084fc01809149