[INFO] updating cached repository StephanDollberg/PingPong [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/StephanDollberg/PingPong [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/StephanDollberg/PingPong" "work/ex/clippy-test-run/sources/stable/gh/StephanDollberg/PingPong"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/StephanDollberg/PingPong'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/StephanDollberg/PingPong" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StephanDollberg/PingPong"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StephanDollberg/PingPong'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5b05c035855cd772b8dbf973cbba1890e97bfb63 [INFO] sha for GitHub repo StephanDollberg/PingPong: 5b05c035855cd772b8dbf973cbba1890e97bfb63 [INFO] validating manifest of StephanDollberg/PingPong on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of StephanDollberg/PingPong on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing StephanDollberg/PingPong [INFO] finished frobbing StephanDollberg/PingPong [INFO] frobbed toml for StephanDollberg/PingPong written to work/ex/clippy-test-run/sources/stable/gh/StephanDollberg/PingPong/Cargo.toml [INFO] started frobbing StephanDollberg/PingPong [INFO] finished frobbing StephanDollberg/PingPong [INFO] frobbed toml for StephanDollberg/PingPong written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StephanDollberg/PingPong/Cargo.toml [INFO] crate StephanDollberg/PingPong has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting StephanDollberg/PingPong against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/StephanDollberg/PingPong:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1935504cf3fc064ca237001487e57fe624731f1f730e765c24bae827d20d5c90 [INFO] running `"docker" "start" "-a" "1935504cf3fc064ca237001487e57fe624731f1f730e765c24bae827d20d5c90"` [INFO] [stderr] Checking pingpong v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / return Settings{ [INFO] [stderr] 66 | | non_blocking: matches.is_present("non_blocking"), [INFO] [stderr] 67 | | warm_up_count: matches.value_of("warmup_messages").unwrap_or("1000").parse::().unwrap(), [INFO] [stderr] 68 | | msg_count: matches.value_of("messages").unwrap_or("1000").parse::().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 73 | | udp: matches.is_present("udp"), [INFO] [stderr] 74 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | Settings{ [INFO] [stderr] 66 | non_blocking: matches.is_present("non_blocking"), [INFO] [stderr] 67 | warm_up_count: matches.value_of("warmup_messages").unwrap_or("1000").parse::().unwrap(), [INFO] [stderr] 68 | msg_count: matches.value_of("messages").unwrap_or("1000").parse::().unwrap(), [INFO] [stderr] 69 | sleep_time: matches.value_of("sleep_time").unwrap_or("0").parse::().unwrap(), [INFO] [stderr] 70 | ponger_addr: matches.value_of("remote").unwrap_or("localhost:10000").to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.write(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.write(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return self.read(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return self.send(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.send(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return self.recv(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.recv(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / return Settings{ [INFO] [stderr] 66 | | non_blocking: matches.is_present("non_blocking"), [INFO] [stderr] 67 | | warm_up_count: matches.value_of("warmup_messages").unwrap_or("1000").parse::().unwrap(), [INFO] [stderr] 68 | | msg_count: matches.value_of("messages").unwrap_or("1000").parse::().unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 73 | | udp: matches.is_present("udp"), [INFO] [stderr] 74 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | Settings{ [INFO] [stderr] 66 | non_blocking: matches.is_present("non_blocking"), [INFO] [stderr] 67 | warm_up_count: matches.value_of("warmup_messages").unwrap_or("1000").parse::().unwrap(), [INFO] [stderr] 68 | msg_count: matches.value_of("messages").unwrap_or("1000").parse::().unwrap(), [INFO] [stderr] 69 | sleep_time: matches.value_of("sleep_time").unwrap_or("0").parse::().unwrap(), [INFO] [stderr] 70 | ponger_addr: matches.value_of("remote").unwrap_or("localhost:10000").to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.write(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.write(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return self.read(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.read(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return self.send(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.send(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return self.recv(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.recv(buf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/ponger.rs:25:52 [INFO] [stderr] | [INFO] [stderr] 25 | let acceptor = std::net::TcpListener::bind(format!("{}", settings.ponger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.ponger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/ponger.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | let sock = std::net::UdpSocket::bind(format!("{}", settings.ponger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.ponger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/ponger.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | sock.connect(format!("{}", settings.pinger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.pinger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/pinger.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return pingpong::read_busy_until_some(client, recv_buf).expect("Receiving pong failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pingpong::read_busy_until_some(client, recv_buf).expect("Receiving pong failed")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/pinger.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return times; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `times` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/pinger.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | let msg: &[u8] = "Hello pong".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello pong"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/pinger.rs:65:51 [INFO] [stderr] | [INFO] [stderr] 65 | let client = std::net::TcpStream::connect(format!("{}", settings.ponger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.ponger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/pinger.rs:71:48 [INFO] [stderr] | [INFO] [stderr] 71 | let client = std::net::UdpSocket::bind(format!("{}", settings.pinger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.pinger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/pinger.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | client.connect(format!("{}", settings.ponger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.ponger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/ponger.rs:25:52 [INFO] [stderr] | [INFO] [stderr] 25 | let acceptor = std::net::TcpListener::bind(format!("{}", settings.ponger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.ponger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/ponger.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | let sock = std::net::UdpSocket::bind(format!("{}", settings.ponger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.ponger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/ponger.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | sock.connect(format!("{}", settings.pinger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.pinger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/pinger.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return pingpong::read_busy_until_some(client, recv_buf).expect("Receiving pong failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pingpong::read_busy_until_some(client, recv_buf).expect("Receiving pong failed")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/pinger.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return times; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `times` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bin/pinger.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | let msg: &[u8] = "Hello pong".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello pong"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/pinger.rs:65:51 [INFO] [stderr] | [INFO] [stderr] 65 | let client = std::net::TcpStream::connect(format!("{}", settings.ponger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.ponger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/pinger.rs:71:48 [INFO] [stderr] | [INFO] [stderr] 71 | let client = std::net::UdpSocket::bind(format!("{}", settings.pinger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.pinger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/pinger.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | client.connect(format!("{}", settings.ponger_addr)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `settings.ponger_addr.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.97s [INFO] running `"docker" "inspect" "1935504cf3fc064ca237001487e57fe624731f1f730e765c24bae827d20d5c90"` [INFO] running `"docker" "rm" "-f" "1935504cf3fc064ca237001487e57fe624731f1f730e765c24bae827d20d5c90"` [INFO] [stdout] 1935504cf3fc064ca237001487e57fe624731f1f730e765c24bae827d20d5c90