[INFO] updating cached repository StelarCF/slancf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/StelarCF/slancf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/StelarCF/slancf" "work/ex/clippy-test-run/sources/stable/gh/StelarCF/slancf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/StelarCF/slancf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/StelarCF/slancf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StelarCF/slancf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StelarCF/slancf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2832a239d91bf7ebb7caf74b3792c9c19308b03d [INFO] sha for GitHub repo StelarCF/slancf: 2832a239d91bf7ebb7caf74b3792c9c19308b03d [INFO] validating manifest of StelarCF/slancf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of StelarCF/slancf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing StelarCF/slancf [INFO] finished frobbing StelarCF/slancf [INFO] frobbed toml for StelarCF/slancf written to work/ex/clippy-test-run/sources/stable/gh/StelarCF/slancf/Cargo.toml [INFO] started frobbing StelarCF/slancf [INFO] finished frobbing StelarCF/slancf [INFO] frobbed toml for StelarCF/slancf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/StelarCF/slancf/Cargo.toml [INFO] crate StelarCF/slancf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting StelarCF/slancf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/StelarCF/slancf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35c45c7368c75cfbf470dd45661ed7dc9f24b993838cbb3bb4d58060eb940281 [INFO] running `"docker" "start" "-a" "35c45c7368c75cfbf470dd45661ed7dc9f24b993838cbb3bb4d58060eb940281"` [INFO] [stderr] Checking slancf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/parser.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/parser.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(Literal::Float(f)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Literal::Float(f))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Literal::Integer(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Literal::Integer(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lexer.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 61 | | if crt_string == "false" || crt_string == "true" { [INFO] [stderr] 62 | | if crt_string == "false" { [INFO] [stderr] 63 | | res.push(Token::Literal(Literal::Boolean(false))); [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | } else if crt_string == "false" || crt_string == "true" { [INFO] [stderr] 61 | if crt_string == "false" { [INFO] [stderr] 62 | res.push(Token::Literal(Literal::Boolean(false))); [INFO] [stderr] 63 | } else { [INFO] [stderr] 64 | res.push(Token::Literal(Literal::Boolean(true))); [INFO] [stderr] 65 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | Ok(Type::Empty) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(Literal::Float(f)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Literal::Float(f))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(Literal::Integer(i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Literal::Integer(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lexer.rs:60:16 [INFO] [stderr] | [INFO] [stderr] 60 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 61 | | if crt_string == "false" || crt_string == "true" { [INFO] [stderr] 62 | | if crt_string == "false" { [INFO] [stderr] 63 | | res.push(Token::Literal(Literal::Boolean(false))); [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | } else if crt_string == "false" || crt_string == "true" { [INFO] [stderr] 61 | if crt_string == "false" { [INFO] [stderr] 62 | res.push(Token::Literal(Literal::Boolean(false))); [INFO] [stderr] 63 | } else { [INFO] [stderr] 64 | res.push(Token::Literal(Literal::Boolean(true))); [INFO] [stderr] 65 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | nr_parant = nr_parant + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nr_parant += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | nr_parant = nr_parant - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nr_parant -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | fn into_type(&mut self, token: Token) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | fn parse(&mut self, expression: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match parser.accept(tokens) { [INFO] [stderr] 49 | | Err(error) => { [INFO] [stderr] 50 | | printerr!("{}", error); [INFO] [stderr] 51 | | panic!("Interpreter error"); [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | _ => {} [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let Err(error) = parser.accept(tokens) { [INFO] [stderr] 49 | printerr!("{}", error); [INFO] [stderr] 50 | panic!("Interpreter error"); [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/parser.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | Ok(Type::Empty) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | nr_parant = nr_parant + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nr_parant += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | nr_parant = nr_parant - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nr_parant -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | fn into_type(&mut self, token: Token) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | fn parse(&mut self, expression: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Token]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match parser.accept(tokens) { [INFO] [stderr] 49 | | Err(error) => { [INFO] [stderr] 50 | | printerr!("{}", error); [INFO] [stderr] 51 | | panic!("Interpreter error"); [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | _ => {} [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let Err(error) = parser.accept(tokens) { [INFO] [stderr] 49 | printerr!("{}", error); [INFO] [stderr] 50 | panic!("Interpreter error"); [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "35c45c7368c75cfbf470dd45661ed7dc9f24b993838cbb3bb4d58060eb940281"` [INFO] running `"docker" "rm" "-f" "35c45c7368c75cfbf470dd45661ed7dc9f24b993838cbb3bb4d58060eb940281"` [INFO] [stdout] 35c45c7368c75cfbf470dd45661ed7dc9f24b993838cbb3bb4d58060eb940281