[INFO] updating cached repository SteffenSunde/cycle_counting [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SteffenSunde/cycle_counting [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SteffenSunde/cycle_counting" "work/ex/clippy-test-run/sources/stable/gh/SteffenSunde/cycle_counting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SteffenSunde/cycle_counting'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SteffenSunde/cycle_counting" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SteffenSunde/cycle_counting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SteffenSunde/cycle_counting'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 75d916024b292c8146e03d8148c4e4af5b758333 [INFO] sha for GitHub repo SteffenSunde/cycle_counting: 75d916024b292c8146e03d8148c4e4af5b758333 [INFO] validating manifest of SteffenSunde/cycle_counting on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SteffenSunde/cycle_counting on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SteffenSunde/cycle_counting [INFO] finished frobbing SteffenSunde/cycle_counting [INFO] frobbed toml for SteffenSunde/cycle_counting written to work/ex/clippy-test-run/sources/stable/gh/SteffenSunde/cycle_counting/Cargo.toml [INFO] started frobbing SteffenSunde/cycle_counting [INFO] finished frobbing SteffenSunde/cycle_counting [INFO] frobbed toml for SteffenSunde/cycle_counting written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SteffenSunde/cycle_counting/Cargo.toml [INFO] crate SteffenSunde/cycle_counting has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SteffenSunde/cycle_counting against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SteffenSunde/cycle_counting:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 736f207ff595cd70979ae64904af68940d44b433b13fecbf01f491aa4e133546 [INFO] running `"docker" "start" "-a" "736f207ff595cd70979ae64904af68940d44b433b13fecbf01f491aa4e133546"` [INFO] [stderr] Checking gnuplot v0.0.26 [INFO] [stderr] Checking approx v0.3.0 [INFO] [stderr] Checking cycle_counting v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::f64::consts::PI` [INFO] [stderr] --> src/rainflow.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::f64::consts::PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rainflow.rs:79:31 [INFO] [stderr] | [INFO] [stderr] 79 | let a = (self.value * 100000.0) as i64; [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rainflow.rs:80:32 [INFO] [stderr] | [INFO] [stderr] 80 | let b = (other.value * 100000.0) as i64; [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return number / number.abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `number / number.abs()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return 0.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | return ranges; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | return vector; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `vector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rainflow.rs:79:31 [INFO] [stderr] | [INFO] [stderr] 79 | let a = (self.value * 100000.0) as i64; [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rainflow.rs:80:32 [INFO] [stderr] | [INFO] [stderr] 80 | let b = (other.value * 100000.0) as i64; [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return number / number.abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `number / number.abs()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return 0.0; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | return ranges; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:182:5 [INFO] [stderr] | [INFO] [stderr] 182 | return vector; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `vector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `approx::*` [INFO] [stderr] --> src/rainflow.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | use approx::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/rainflow.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | / if !el.is_nan() { [INFO] [stderr] 287 | | if el > &maximum { [INFO] [stderr] 288 | | maximum = *el; [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 286 | if !el.is_nan() && el > &maximum { [INFO] [stderr] 287 | maximum = *el; [INFO] [stderr] 288 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rainflow.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/rainflow.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | / if a.is_normal() && b.is_normal() { [INFO] [stderr] 299 | | if (a - b).abs() < 0.01 { [INFO] [stderr] 300 | | return true; [INFO] [stderr] 301 | | } [INFO] [stderr] 302 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 298 | if a.is_normal() && b.is_normal() && (a - b).abs() < 0.01 { [INFO] [stderr] 299 | return true; [INFO] [stderr] 300 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Cycle` [INFO] [stderr] --> src/rainflow.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RainflowMatrix` [INFO] [stderr] --> src/rainflow.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub struct RainflowMatrix { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/rainflow.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add` [INFO] [stderr] --> src/rainflow.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fn add(&mut self, from: f64, to: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/rainflow.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn new(m: f64, a: f64) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sign` [INFO] [stderr] --> src/rainflow.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | fn sign(number: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `filter_noise` [INFO] [stderr] --> src/rainflow.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn filter_noise(lh: &Vec, limit: f64) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `filter_reversals` [INFO] [stderr] --> src/rainflow.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn filter_reversals(lh: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rainflow.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | el.2 = el.2 + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `el.2 += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rainflow.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn filter_noise(lh: &Vec, limit: f64) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rainflow.rs:107:29 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn filter_reversals(lh: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if sign(step) != sign(next_step) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(sign(step) - sign(next_step)).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if sign(step) != sign(next_step) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:126:51 [INFO] [stderr] | [INFO] [stderr] 126 | let position = ranges.iter().position(|ref x| x.value == range); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(x.value - range).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:126:51 [INFO] [stderr] | [INFO] [stderr] 126 | let position = ranges.iter().position(|ref x| x.value == range); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: variable `Y` should have a snake case name such as `y` [INFO] [stderr] --> src/rainflow.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | let Y = (load_history[i] - load_history[i+1]).abs(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `X` should have a snake case name such as `x` [INFO] [stderr] --> src/rainflow.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | let X = (load_history[i+1] - load_history[i+2]).abs(); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cycle_counting`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: struct is never constructed: `Cycle` [INFO] [stderr] --> src/rainflow.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct Cycle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RainflowMatrix` [INFO] [stderr] --> src/rainflow.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | pub struct RainflowMatrix { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/rainflow.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add` [INFO] [stderr] --> src/rainflow.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fn add(&mut self, from: f64, to: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/rainflow.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn new(m: f64, a: f64) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rainflow.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | el.2 = el.2 + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `el.2 += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rainflow.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn filter_noise(lh: &Vec, limit: f64) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rainflow.rs:107:29 [INFO] [stderr] | [INFO] [stderr] 107 | pub fn filter_reversals(lh: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if sign(step) != sign(next_step) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(sign(step) - sign(next_step)).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | if sign(step) != sign(next_step) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:126:51 [INFO] [stderr] | [INFO] [stderr] 126 | let position = ranges.iter().position(|ref x| x.value == range); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(x.value - range).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:126:51 [INFO] [stderr] | [INFO] [stderr] 126 | let position = ranges.iter().position(|ref x| x.value == range); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: variable `Y` should have a snake case name such as `y` [INFO] [stderr] --> src/rainflow.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | let Y = (load_history[i] - load_history[i+1]).abs(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `X` should have a snake case name such as `x` [INFO] [stderr] --> src/rainflow.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | let X = (load_history[i+1] - load_history[i+2]).abs(); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | assert_eq!(el.value, cycles[i].value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | assert_eq!(el.value, cycles[i].value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | assert_eq!(el.count, cycles[i].count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | assert_eq!(el.count, cycles[i].count); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | assert_eq!(float_max(&result), float_max(&answer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | assert_eq!(float_max(&result), float_max(&answer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | assert_eq!(el, &answer[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | assert_eq!(el, &answer[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(float_max(&result), float_max(&answer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(float_max(&result), float_max(&answer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | assert_eq!(el, &answer[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | assert_eq!(el, &answer[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | assert_eq!(float_max(&result), float_max(&answer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | assert_eq!(float_max(&result), float_max(&answer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rainflow.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | assert_eq!(el, &answer[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rainflow.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | assert_eq!(el, &answer[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rainflow.rs:282:27 [INFO] [stderr] | [INFO] [stderr] 282 | fn float_max(numbers: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cycle_counting`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "736f207ff595cd70979ae64904af68940d44b433b13fecbf01f491aa4e133546"` [INFO] running `"docker" "rm" "-f" "736f207ff595cd70979ae64904af68940d44b433b13fecbf01f491aa4e133546"` [INFO] [stdout] 736f207ff595cd70979ae64904af68940d44b433b13fecbf01f491aa4e133546