[INFO] updating cached repository Stateford/rust-graph [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Stateford/rust-graph [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Stateford/rust-graph" "work/ex/clippy-test-run/sources/stable/gh/Stateford/rust-graph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Stateford/rust-graph'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Stateford/rust-graph" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stateford/rust-graph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stateford/rust-graph'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9fd717504a2a2ff9f0e47593e82c4fdc009af82d [INFO] sha for GitHub repo Stateford/rust-graph: 9fd717504a2a2ff9f0e47593e82c4fdc009af82d [INFO] validating manifest of Stateford/rust-graph on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Stateford/rust-graph on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Stateford/rust-graph [INFO] finished frobbing Stateford/rust-graph [INFO] frobbed toml for Stateford/rust-graph written to work/ex/clippy-test-run/sources/stable/gh/Stateford/rust-graph/Cargo.toml [INFO] started frobbing Stateford/rust-graph [INFO] finished frobbing Stateford/rust-graph [INFO] frobbed toml for Stateford/rust-graph written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Stateford/rust-graph/Cargo.toml [INFO] crate Stateford/rust-graph has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Stateford/rust-graph against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Stateford/rust-graph:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c06e1acde3849afa301e6bb93c512dedb49b8f5790f4cdf3eb37fe4985cfdbd2 [INFO] running `"docker" "start" "-a" "c06e1acde3849afa301e6bb93c512dedb49b8f5790f4cdf3eb37fe4985cfdbd2"` [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking x11-dl v2.18.3 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking wayland-commons v0.21.4 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking wayland-client v0.21.4 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Checking wayland-protocols v0.21.4 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.54.0 [INFO] [stderr] Checking piston_window v0.85.0 [INFO] [stderr] Checking graph v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return Vector2f{ [INFO] [stderr] 25 | | x: x, [INFO] [stderr] 26 | | y: y [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | Vector2f{ [INFO] [stderr] 25 | x: x, [INFO] [stderr] 26 | y: y [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return Vector2f{ [INFO] [stderr] 41 | | x: x, [INFO] [stderr] 42 | | y: y [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | Vector2f{ [INFO] [stderr] 41 | x: x, [INFO] [stderr] 42 | y: y [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / return Color { [INFO] [stderr] 63 | | r: color[0], [INFO] [stderr] 64 | | b: color[1], [INFO] [stderr] 65 | | g: color[2], [INFO] [stderr] 66 | | a: color[3], [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | Color { [INFO] [stderr] 63 | r: color[0], [INFO] [stderr] 64 | b: color[1], [INFO] [stderr] 65 | g: color[2], [INFO] [stderr] 66 | a: color[3], [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return [self.r, self.b, self.g, self.a]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.r, self.b, self.g, self.a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / return Graph { [INFO] [stderr] 94 | | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | | position: Position::new(0.0, 0.0), [INFO] [stderr] 96 | | color: Color::new([0.0, 0.0, 0.0, 1.0]), [INFO] [stderr] 97 | | totalTime: 0.0, [INFO] [stderr] 98 | | switchTime: 1.0 [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 93 | Graph { [INFO] [stderr] 94 | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | position: Position::new(0.0, 0.0), [INFO] [stderr] 96 | color: Color::new([0.0, 0.0, 0.0, 1.0]), [INFO] [stderr] 97 | totalTime: 0.0, [INFO] [stderr] 98 | switchTime: 1.0 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return Point{ [INFO] [stderr] 14 | | x: 0.0, [INFO] [stderr] 15 | | y: 0.0, [INFO] [stderr] 16 | | position: 0 [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Point{ [INFO] [stderr] 14 | x: 0.0, [INFO] [stderr] 15 | y: 0.0, [INFO] [stderr] 16 | position: 0 [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / return GraphPoints { [INFO] [stderr] 47 | | points: Vec::new(), [INFO] [stderr] 48 | | size: 0, [INFO] [stderr] 49 | | max_size: 20, [INFO] [stderr] 50 | | graph_size: size.clone() [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 46 | GraphPoints { [INFO] [stderr] 47 | points: Vec::new(), [INFO] [stderr] 48 | size: 0, [INFO] [stderr] 49 | max_size: 20, [INFO] [stderr] 50 | graph_size: size.clone() [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return Vector2f{ [INFO] [stderr] 25 | | x: x, [INFO] [stderr] 26 | | y: y [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | Vector2f{ [INFO] [stderr] 25 | x: x, [INFO] [stderr] 26 | y: y [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return Vector2f{ [INFO] [stderr] 41 | | x: x, [INFO] [stderr] 42 | | y: y [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | Vector2f{ [INFO] [stderr] 41 | x: x, [INFO] [stderr] 42 | y: y [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / return Color { [INFO] [stderr] 63 | | r: color[0], [INFO] [stderr] 64 | | b: color[1], [INFO] [stderr] 65 | | g: color[2], [INFO] [stderr] 66 | | a: color[3], [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | Color { [INFO] [stderr] 63 | r: color[0], [INFO] [stderr] 64 | b: color[1], [INFO] [stderr] 65 | g: color[2], [INFO] [stderr] 66 | a: color[3], [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return [self.r, self.b, self.g, self.a]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.r, self.b, self.g, self.a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / return Graph { [INFO] [stderr] 94 | | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | | position: Position::new(0.0, 0.0), [INFO] [stderr] 96 | | color: Color::new([0.0, 0.0, 0.0, 1.0]), [INFO] [stderr] 97 | | totalTime: 0.0, [INFO] [stderr] 98 | | switchTime: 1.0 [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 93 | Graph { [INFO] [stderr] 94 | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | position: Position::new(0.0, 0.0), [INFO] [stderr] 96 | color: Color::new([0.0, 0.0, 0.0, 1.0]), [INFO] [stderr] 97 | totalTime: 0.0, [INFO] [stderr] 98 | switchTime: 1.0 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return Point{ [INFO] [stderr] 14 | | x: 0.0, [INFO] [stderr] 15 | | y: 0.0, [INFO] [stderr] 16 | | position: 0 [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Point{ [INFO] [stderr] 14 | x: 0.0, [INFO] [stderr] 15 | y: 0.0, [INFO] [stderr] 16 | position: 0 [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / return GraphPoints { [INFO] [stderr] 47 | | points: Vec::new(), [INFO] [stderr] 48 | | size: 0, [INFO] [stderr] 49 | | max_size: 20, [INFO] [stderr] 50 | | graph_size: size.clone() [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 46 | GraphPoints { [INFO] [stderr] 47 | points: Vec::new(), [INFO] [stderr] 48 | size: 0, [INFO] [stderr] 49 | max_size: 20, [INFO] [stderr] 50 | graph_size: size.clone() [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `shift` [INFO] [stderr] --> src/graph/point.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fn shift(&mut self, max_positions: i32, size: Vector2f) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `totalTime` should have a snake case name such as `total_time` [INFO] [stderr] --> src/graph/instance.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | totalTime: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `switchTime` should have a snake case name such as `switch_time` [INFO] [stderr] --> src/graph/instance.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | switchTime: f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graph::instance::Graph` [INFO] [stderr] --> src/graph/instance.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn new() -> Self { [INFO] [stderr] 93 | | return Graph { [INFO] [stderr] 94 | | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | | position: Position::new(0.0, 0.0), [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | impl Default for graph::instance::Graph { [INFO] [stderr] 91 | fn default() -> Self { [INFO] [stderr] 92 | Self::new() [INFO] [stderr] 93 | } [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | let x: f64 = (size.x / max_positions as f64) * position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_positions)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let x: f64 = (size.x / max_positions as f64) * self.position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_positions)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | let x: f64 = (size.x / max_positions as f64) * self.position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `graph::point::GraphPoints` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/graph/point.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl GraphPoints { [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | pub fn new(size: Vector2f) -> Self { [INFO] [stderr] 46 | | return GraphPoints { [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | graph_size: size.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | self.graph_size.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.graph_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: method is never used: `shift` [INFO] [stderr] --> src/graph/point.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fn shift(&mut self, max_positions: i32, size: Vector2f) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `totalTime` should have a snake case name such as `total_time` [INFO] [stderr] --> src/graph/instance.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | totalTime: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `switchTime` should have a snake case name such as `switch_time` [INFO] [stderr] --> src/graph/instance.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | switchTime: f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graph::instance::Graph` [INFO] [stderr] --> src/graph/instance.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn new() -> Self { [INFO] [stderr] 93 | | return Graph { [INFO] [stderr] 94 | | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | | position: Position::new(0.0, 0.0), [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 90 | impl Default for graph::instance::Graph { [INFO] [stderr] 91 | fn default() -> Self { [INFO] [stderr] 92 | Self::new() [INFO] [stderr] 93 | } [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | let x: f64 = (size.x / max_positions as f64) * position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_positions)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let x: f64 = (size.x / max_positions as f64) * self.position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_positions)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | let x: f64 = (size.x / max_positions as f64) * self.position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `graph::point::GraphPoints` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/graph/point.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / impl GraphPoints { [INFO] [stderr] 44 | | [INFO] [stderr] 45 | | pub fn new(size: Vector2f) -> Self { [INFO] [stderr] 46 | | return GraphPoints { [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | graph_size: size.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | self.graph_size.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.graph_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph/instance.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/lib.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | graph_points.add_point(i as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return Vector2f{ [INFO] [stderr] 25 | | x: x, [INFO] [stderr] 26 | | y: y [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | Vector2f{ [INFO] [stderr] 25 | x: x, [INFO] [stderr] 26 | y: y [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return Vector2f{ [INFO] [stderr] 41 | | x: x, [INFO] [stderr] 42 | | y: y [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | Vector2f{ [INFO] [stderr] 41 | x: x, [INFO] [stderr] 42 | y: y [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / return Color { [INFO] [stderr] 63 | | r: color[0], [INFO] [stderr] 64 | | b: color[1], [INFO] [stderr] 65 | | g: color[2], [INFO] [stderr] 66 | | a: color[3], [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | Color { [INFO] [stderr] 63 | r: color[0], [INFO] [stderr] 64 | b: color[1], [INFO] [stderr] 65 | g: color[2], [INFO] [stderr] 66 | a: color[3], [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return [self.r, self.b, self.g, self.a]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.r, self.b, self.g, self.a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / return Graph { [INFO] [stderr] 94 | | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | | position: Position::new(0.0, 0.0), [INFO] [stderr] 96 | | color: Color::new([0.0, 0.0, 0.0, 1.0]), [INFO] [stderr] 97 | | totalTime: 0.0, [INFO] [stderr] 98 | | switchTime: 1.0 [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 93 | Graph { [INFO] [stderr] 94 | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | position: Position::new(0.0, 0.0), [INFO] [stderr] 96 | color: Color::new([0.0, 0.0, 0.0, 1.0]), [INFO] [stderr] 97 | totalTime: 0.0, [INFO] [stderr] 98 | switchTime: 1.0 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return Point{ [INFO] [stderr] 14 | | x: 0.0, [INFO] [stderr] 15 | | y: 0.0, [INFO] [stderr] 16 | | position: 0 [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Point{ [INFO] [stderr] 14 | x: 0.0, [INFO] [stderr] 15 | y: 0.0, [INFO] [stderr] 16 | position: 0 [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / return GraphPoints { [INFO] [stderr] 47 | | points: Vec::new(), [INFO] [stderr] 48 | | size: 0, [INFO] [stderr] 49 | | max_size: 20, [INFO] [stderr] 50 | | graph_size: size.clone() [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 46 | GraphPoints { [INFO] [stderr] 47 | points: Vec::new(), [INFO] [stderr] 48 | size: 0, [INFO] [stderr] 49 | max_size: 20, [INFO] [stderr] 50 | graph_size: size.clone() [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `x` [INFO] [stderr] --> src/graph/point.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | x: f64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `y` [INFO] [stderr] --> src/graph/point.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | y: f64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `position` [INFO] [stderr] --> src/graph/point.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | position: i32 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graph/point.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_value` [INFO] [stderr] --> src/graph/point.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn set_value(&mut self, value: f64, max_positions: i32, position: usize, size: Vector2f) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `shift` [INFO] [stderr] --> src/graph/point.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fn shift(&mut self, max_positions: i32, size: Vector2f) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GraphPoints` [INFO] [stderr] --> src/graph/point.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | pub struct GraphPoints { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graph/point.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn new(size: Vector2f) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_max_size` [INFO] [stderr] --> src/graph/point.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn set_max_size(&mut self, size: i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/graph/point.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn len(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_point` [INFO] [stderr] --> src/graph/point.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn add_point(&mut self, value: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `totalTime` should have a snake case name such as `total_time` [INFO] [stderr] --> src/graph/instance.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | totalTime: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `switchTime` should have a snake case name such as `switch_time` [INFO] [stderr] --> src/graph/instance.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | switchTime: f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | let x: f64 = (size.x / max_positions as f64) * position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_positions)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let x: f64 = (size.x / max_positions as f64) * self.position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_positions)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | let x: f64 = (size.x / max_positions as f64) * self.position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | graph_size: size.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | self.graph_size.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.graph_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return Vector2f{ [INFO] [stderr] 25 | | x: x, [INFO] [stderr] 26 | | y: y [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | Vector2f{ [INFO] [stderr] 25 | x: x, [INFO] [stderr] 26 | y: y [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / return Vector2f{ [INFO] [stderr] 41 | | x: x, [INFO] [stderr] 42 | | y: y [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 40 | Vector2f{ [INFO] [stderr] 41 | x: x, [INFO] [stderr] 42 | y: y [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / return Color { [INFO] [stderr] 63 | | r: color[0], [INFO] [stderr] 64 | | b: color[1], [INFO] [stderr] 65 | | g: color[2], [INFO] [stderr] 66 | | a: color[3], [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 62 | Color { [INFO] [stderr] 63 | r: color[0], [INFO] [stderr] 64 | b: color[1], [INFO] [stderr] 65 | g: color[2], [INFO] [stderr] 66 | a: color[3], [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return [self.r, self.b, self.g, self.a]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.r, self.b, self.g, self.a]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/instance.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | / return Graph { [INFO] [stderr] 94 | | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | | position: Position::new(0.0, 0.0), [INFO] [stderr] 96 | | color: Color::new([0.0, 0.0, 0.0, 1.0]), [INFO] [stderr] 97 | | totalTime: 0.0, [INFO] [stderr] 98 | | switchTime: 1.0 [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 93 | Graph { [INFO] [stderr] 94 | size : Size::new(600.0, 200.0), [INFO] [stderr] 95 | position: Position::new(0.0, 0.0), [INFO] [stderr] 96 | color: Color::new([0.0, 0.0, 0.0, 1.0]), [INFO] [stderr] 97 | totalTime: 0.0, [INFO] [stderr] 98 | switchTime: 1.0 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / return Point{ [INFO] [stderr] 14 | | x: 0.0, [INFO] [stderr] 15 | | y: 0.0, [INFO] [stderr] 16 | | position: 0 [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 13 | Point{ [INFO] [stderr] 14 | x: 0.0, [INFO] [stderr] 15 | y: 0.0, [INFO] [stderr] 16 | position: 0 [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / return GraphPoints { [INFO] [stderr] 47 | | points: Vec::new(), [INFO] [stderr] 48 | | size: 0, [INFO] [stderr] 49 | | max_size: 20, [INFO] [stderr] 50 | | graph_size: size.clone() [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 46 | GraphPoints { [INFO] [stderr] 47 | points: Vec::new(), [INFO] [stderr] 48 | size: 0, [INFO] [stderr] 49 | max_size: 20, [INFO] [stderr] 50 | graph_size: size.clone() [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/point.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `x` [INFO] [stderr] --> src/graph/point.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | x: f64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `y` [INFO] [stderr] --> src/graph/point.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | y: f64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `position` [INFO] [stderr] --> src/graph/point.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | position: i32 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graph/point.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_value` [INFO] [stderr] --> src/graph/point.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn set_value(&mut self, value: f64, max_positions: i32, position: usize, size: Vector2f) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `shift` [INFO] [stderr] --> src/graph/point.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | fn shift(&mut self, max_positions: i32, size: Vector2f) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GraphPoints` [INFO] [stderr] --> src/graph/point.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | pub struct GraphPoints { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graph/point.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn new(size: Vector2f) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_max_size` [INFO] [stderr] --> src/graph/point.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn set_max_size(&mut self, size: i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `len` [INFO] [stderr] --> src/graph/point.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn len(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_point` [INFO] [stderr] --> src/graph/point.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn add_point(&mut self, value: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `totalTime` should have a snake case name such as `total_time` [INFO] [stderr] --> src/graph/instance.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | totalTime: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `switchTime` should have a snake case name such as `switch_time` [INFO] [stderr] --> src/graph/instance.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | switchTime: f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:23:32 [INFO] [stderr] | [INFO] [stderr] 23 | let x: f64 = (size.x / max_positions as f64) * position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_positions)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let x: f64 = (size.x / max_positions as f64) * self.position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_positions)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/graph/point.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | let x: f64 = (size.x / max_positions as f64) * self.position as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | graph_size: size.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph/point.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | self.graph_size.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.graph_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 51s [INFO] running `"docker" "inspect" "c06e1acde3849afa301e6bb93c512dedb49b8f5790f4cdf3eb37fe4985cfdbd2"` [INFO] running `"docker" "rm" "-f" "c06e1acde3849afa301e6bb93c512dedb49b8f5790f4cdf3eb37fe4985cfdbd2"` [INFO] [stdout] c06e1acde3849afa301e6bb93c512dedb49b8f5790f4cdf3eb37fe4985cfdbd2