[INFO] updating cached repository Srynetix/chip8 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Srynetix/chip8 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Srynetix/chip8" "work/ex/clippy-test-run/sources/stable/gh/Srynetix/chip8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Srynetix/chip8'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Srynetix/chip8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Srynetix/chip8"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Srynetix/chip8'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5928b8adcfbcd2c3f469e133c90c13447ef7cdc6 [INFO] sha for GitHub repo Srynetix/chip8: 5928b8adcfbcd2c3f469e133c90c13447ef7cdc6 [INFO] validating manifest of Srynetix/chip8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Srynetix/chip8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Srynetix/chip8 [INFO] finished frobbing Srynetix/chip8 [INFO] frobbed toml for Srynetix/chip8 written to work/ex/clippy-test-run/sources/stable/gh/Srynetix/chip8/Cargo.toml [INFO] started frobbing Srynetix/chip8 [INFO] finished frobbing Srynetix/chip8 [INFO] frobbed toml for Srynetix/chip8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Srynetix/chip8/Cargo.toml [INFO] crate Srynetix/chip8 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Srynetix/chip8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Srynetix/chip8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a4b96e76860282c4b4c0538d11733c0767747cb36256d173ba6ae40b2a029f8 [INFO] running `"docker" "start" "-a" "6a4b96e76860282c4b4c0538d11733c0767747cb36256d173ba6ae40b2a029f8"` [INFO] [stderr] Checking serde v1.0.35 [INFO] [stderr] Compiling sdl2-sys v0.31.0 [INFO] [stderr] Checking clap v2.31.0 [INFO] [stderr] Checking fern v0.4.4 [INFO] [stderr] Compiling serde_derive_internals v0.22.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Compiling serde_derive v1.0.35 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking bincode v1.0.0 [INFO] [stderr] Checking chip8 v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:421:29 [INFO] [stderr] | [INFO] [stderr] 421 | for ridx in 0..(reg + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=reg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:432:29 [INFO] [stderr] | [INFO] [stderr] 432 | for ridx in 0..(reg + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=reg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cartridge.rs:210:53 [INFO] [stderr] | [INFO] [stderr] 210 | let disasm_lines: Vec<_> = disasm_str.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:421:29 [INFO] [stderr] | [INFO] [stderr] 421 | for ridx in 0..(reg + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=reg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/cpu.rs:432:29 [INFO] [stderr] | [INFO] [stderr] 432 | for ridx in 0..(reg + 1) { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=reg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.20s [INFO] running `"docker" "inspect" "6a4b96e76860282c4b4c0538d11733c0767747cb36256d173ba6ae40b2a029f8"` [INFO] running `"docker" "rm" "-f" "6a4b96e76860282c4b4c0538d11733c0767747cb36256d173ba6ae40b2a029f8"` [INFO] [stdout] 6a4b96e76860282c4b4c0538d11733c0767747cb36256d173ba6ae40b2a029f8