[INFO] updating cached repository SrTobi/cubeage [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SrTobi/cubeage [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SrTobi/cubeage" "work/ex/clippy-test-run/sources/stable/gh/SrTobi/cubeage"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SrTobi/cubeage'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SrTobi/cubeage" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SrTobi/cubeage"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SrTobi/cubeage'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebead2acf8298f0424279834ecf2c39ef690c16b [INFO] sha for GitHub repo SrTobi/cubeage: ebead2acf8298f0424279834ecf2c39ef690c16b [INFO] validating manifest of SrTobi/cubeage on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SrTobi/cubeage on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SrTobi/cubeage [INFO] finished frobbing SrTobi/cubeage [INFO] frobbed toml for SrTobi/cubeage written to work/ex/clippy-test-run/sources/stable/gh/SrTobi/cubeage/Cargo.toml [INFO] started frobbing SrTobi/cubeage [INFO] finished frobbing SrTobi/cubeage [INFO] frobbed toml for SrTobi/cubeage written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SrTobi/cubeage/Cargo.toml [INFO] crate SrTobi/cubeage has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SrTobi/cubeage against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SrTobi/cubeage:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7742fe8a4659b35a9c1d5aefd986e4ad55baaf0cad292fd0892e2880458a4a56 [INFO] running `"docker" "start" "-a" "7742fe8a4659b35a9c1d5aefd986e4ad55baaf0cad292fd0892e2880458a4a56"` [INFO] [stderr] Checking fps_counter v1.0.0 [INFO] [stderr] Checking piston3d-cam v0.3.0 [INFO] [stderr] Compiling vek v0.9.5 [INFO] [stderr] Compiling syn v0.15.20 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking camera_controllers v0.24.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking cube_age v0.0.28 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | pipe: pipe, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pipe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | encoder: encoder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `encoder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | pipe: pipe, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pipe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | encoder: encoder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `encoder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chunk.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | pub const EMPTY_CHUNK: &'static Chunk = &Chunk { [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&Chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/shader.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | vbuf [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/shader.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | let vbuf = factory.create_vertex_buffer(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils/cube.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | pub const QUADS: &'static [[usize; 4]; 6] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[[usize; 4]; 6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils/cube.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | pub const VERTICES: &'static [Vec3; 8] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[Vec3; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/world/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod world; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:293:90 [INFO] [stderr] | [INFO] [stderr] 293 | end_duration.as_secs() as f64 + end_duration.subsec_nanos() as f64 / 1000_000_000.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:294:102 [INFO] [stderr] | [INFO] [stderr] 294 | frame_end_duration.as_secs() as f64 + frame_end_duration.subsec_nanos() as f64 / 1000_000_000.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chunk.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | pub const EMPTY_CHUNK: &'static Chunk = &Chunk { [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&Chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/shader.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | vbuf [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/shader.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | let vbuf = factory.create_vertex_buffer(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils/cube.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | pub const QUADS: &'static [[usize; 4]; 6] = &[ [INFO] [stderr] | -^^^^^^^---------------- help: consider removing `'static`: `&[[usize; 4]; 6]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/utils/cube.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | pub const VERTICES: &'static [Vec3; 8] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[Vec3; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/world/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod world; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:293:90 [INFO] [stderr] | [INFO] [stderr] 293 | end_duration.as_secs() as f64 + end_duration.subsec_nanos() as f64 / 1000_000_000.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/main.rs:294:102 [INFO] [stderr] | [INFO] [stderr] 294 | frame_end_duration.as_secs() as f64 + frame_end_duration.subsec_nanos() as f64 / 1000_000_000.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `World` [INFO] [stderr] --> src/world/world.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | struct World { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/world/world.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn new(width: usize, heigth: usize) -> World { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chunk::ChunkManager` [INFO] [stderr] --> src/chunk.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> ChunkManager { [INFO] [stderr] 61 | | ChunkManager { [INFO] [stderr] 62 | | chunk_columns: HashMap::new() [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/shader.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn clear<'a, 'b>(&mut self, target: &RenderOutput) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/shader.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn clear<'a, 'b>(&mut self, target: &RenderOutput) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/shader.rs:128:19 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn render<'a, 'b>(&mut self, target: &RenderOutput, transform: [[f32; 4]; 4], view: [[f32; 4]; 4], buffer: gfx::handle::Buffer) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/shader.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn render<'a, 'b>(&mut self, target: &RenderOutput, transform: [[f32; 4]; 4], view: [[f32; 4]; 4], buffer: gfx::handle::Buffer) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::cube::FaceIterator` [INFO] [stderr] --> src/utils/cube.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / pub fn new() -> Self { [INFO] [stderr] 156 | | FaceIterator(0) [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 151 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | let loading_title = format!( [INFO] [stderr] | _________________________^ [INFO] [stderr] 137 | | "CubeAge loading..." [INFO] [stderr] 138 | | ); [INFO] [stderr] | |_________^ help: consider using .to_string(): `"CubeAge loading...".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:171:44 [INFO] [stderr] | [INFO] [stderr] 171 | chunk_manager.add_chunk_column(cx as i32, cz as i32, chunk::ChunkColumn { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(cx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:171:55 [INFO] [stderr] | [INFO] [stderr] 171 | chunk_manager.add_chunk_column(cx as i32, cz as i32, chunk::ChunkColumn { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(cz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:211:16 [INFO] [stderr] | [INFO] [stderr] 211 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 212 | | // Apply the same y/z camera offset vanilla minecraft has. [INFO] [stderr] 213 | | let mut camera = first_person.camera(0.0); [INFO] [stderr] 214 | | camera.position[1] += 1.62; [INFO] [stderr] ... | [INFO] [stderr] 297 | | window.set_title(title); [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | / match buffer.borrow_mut().as_mut() { [INFO] [stderr] 242 | | Some(buffer) => { [INFO] [stderr] 243 | | num_total_chunks += 1; [INFO] [stderr] 244 | | [INFO] [stderr] ... | [INFO] [stderr] 280 | | None => {} [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 241 | if let Some(buffer) = buffer.borrow_mut().as_mut() { [INFO] [stderr] 242 | num_total_chunks += 1; [INFO] [stderr] 243 | [INFO] [stderr] 244 | let inf = INFINITY; [INFO] [stderr] 245 | let mut bb_min = [inf, inf, inf]; [INFO] [stderr] 246 | let mut bb_max = [-inf, -inf, -inf]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:266:29 [INFO] [stderr] | [INFO] [stderr] 266 | min.signum() == max.signum() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min.signum() - max.signum()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:266:29 [INFO] [stderr] | [INFO] [stderr] 266 | min.signum() == max.signum() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:293:53 [INFO] [stderr] | [INFO] [stderr] 293 | end_duration.as_secs() as f64 + end_duration.subsec_nanos() as f64 / 1000_000_000.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(end_duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:294:59 [INFO] [stderr] | [INFO] [stderr] 294 | frame_end_duration.as_secs() as f64 + frame_end_duration.subsec_nanos() as f64 / 1000_000_000.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frame_end_duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:300:16 [INFO] [stderr] | [INFO] [stderr] 300 | if let Some(_) = e.after_render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 301 | | window.device.cleanup(); [INFO] [stderr] 302 | | } [INFO] [stderr] | |_________- help: try this: `if e.after_render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:304:16 [INFO] [stderr] | [INFO] [stderr] 304 | if let Some(_) = e.update_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 305 | | use std::i32; [INFO] [stderr] 306 | | // HACK(eddyb) find the closest chunk to the player. [INFO] [stderr] 307 | | // The pending vector should be sorted instead. [INFO] [stderr] ... | [INFO] [stderr] 346 | | } [INFO] [stderr] 347 | | } [INFO] [stderr] | |_________- help: try this: `if e.update_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | / match pending { [INFO] [stderr] 330 | | Some((coords, buffer, chunks)) => { [INFO] [stderr] 331 | | fill_buffer( [INFO] [stderr] 332 | | &mut staging_buffer, [INFO] [stderr] ... | [INFO] [stderr] 345 | | None => {} [INFO] [stderr] 346 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 329 | if let Some((coords, buffer, chunks)) = pending { [INFO] [stderr] 330 | fill_buffer( [INFO] [stderr] 331 | &mut staging_buffer, [INFO] [stderr] 332 | Vec3::from(coords), chunks [INFO] [stderr] 333 | ); [INFO] [stderr] 334 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:349:16 [INFO] [stderr] | [INFO] [stderr] 349 | if let Some(_) = e.resize_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 350 | | let Size { width, height } = window.size(); [INFO] [stderr] 351 | | println!("Window size changed to {}, {}", width, height); [INFO] [stderr] 352 | | [INFO] [stderr] ... | [INFO] [stderr] 371 | | renderer.set_projection(projection_mat);*/ [INFO] [stderr] 372 | | } [INFO] [stderr] | |_________- help: try this: `if e.resize_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:382:16 [INFO] [stderr] | [INFO] [stderr] 382 | if let Some(_) = e.mouse_relative_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 383 | | if !capture_cursor { [INFO] [stderr] 384 | | // Don't send the mouse event to the FPS controller. [INFO] [stderr] 385 | | continue; [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_________- help: try this: `if e.mouse_relative_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cube_age`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: struct is never constructed: `World` [INFO] [stderr] --> src/world/world.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | struct World { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/world/world.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn new(width: usize, heigth: usize) -> World { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chunk::ChunkManager` [INFO] [stderr] --> src/chunk.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> ChunkManager { [INFO] [stderr] 61 | | ChunkManager { [INFO] [stderr] 62 | | chunk_columns: HashMap::new() [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/shader.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn clear<'a, 'b>(&mut self, target: &RenderOutput) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/shader.rs:113:18 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn clear<'a, 'b>(&mut self, target: &RenderOutput) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/shader.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn render<'a, 'b>(&mut self, target: &RenderOutput, transform: [[f32; 4]; 4], view: [[f32; 4]; 4], buffer: gfx::handle::Buffer) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/shader.rs:128:19 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn render<'a, 'b>(&mut self, target: &RenderOutput, transform: [[f32; 4]; 4], view: [[f32; 4]; 4], buffer: gfx::handle::Buffer) { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `utils::cube::FaceIterator` [INFO] [stderr] --> src/utils/cube.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / pub fn new() -> Self { [INFO] [stderr] 156 | | FaceIterator(0) [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 151 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | let loading_title = format!( [INFO] [stderr] | _________________________^ [INFO] [stderr] 137 | | "CubeAge loading..." [INFO] [stderr] 138 | | ); [INFO] [stderr] | |_________^ help: consider using .to_string(): `"CubeAge loading...".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:171:44 [INFO] [stderr] | [INFO] [stderr] 171 | chunk_manager.add_chunk_column(cx as i32, cz as i32, chunk::ChunkColumn { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(cx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:171:55 [INFO] [stderr] | [INFO] [stderr] 171 | chunk_manager.add_chunk_column(cx as i32, cz as i32, chunk::ChunkColumn { [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(cz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:211:16 [INFO] [stderr] | [INFO] [stderr] 211 | if let Some(_) = e.render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 212 | | // Apply the same y/z camera offset vanilla minecraft has. [INFO] [stderr] 213 | | let mut camera = first_person.camera(0.0); [INFO] [stderr] 214 | | camera.position[1] += 1.62; [INFO] [stderr] ... | [INFO] [stderr] 297 | | window.set_title(title); [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | / match buffer.borrow_mut().as_mut() { [INFO] [stderr] 242 | | Some(buffer) => { [INFO] [stderr] 243 | | num_total_chunks += 1; [INFO] [stderr] 244 | | [INFO] [stderr] ... | [INFO] [stderr] 280 | | None => {} [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 241 | if let Some(buffer) = buffer.borrow_mut().as_mut() { [INFO] [stderr] 242 | num_total_chunks += 1; [INFO] [stderr] 243 | [INFO] [stderr] 244 | let inf = INFINITY; [INFO] [stderr] 245 | let mut bb_min = [inf, inf, inf]; [INFO] [stderr] 246 | let mut bb_max = [-inf, -inf, -inf]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:266:29 [INFO] [stderr] | [INFO] [stderr] 266 | min.signum() == max.signum() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min.signum() - max.signum()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:266:29 [INFO] [stderr] | [INFO] [stderr] 266 | min.signum() == max.signum() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:293:53 [INFO] [stderr] | [INFO] [stderr] 293 | end_duration.as_secs() as f64 + end_duration.subsec_nanos() as f64 / 1000_000_000.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(end_duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:294:59 [INFO] [stderr] | [INFO] [stderr] 294 | frame_end_duration.as_secs() as f64 + frame_end_duration.subsec_nanos() as f64 / 1000_000_000.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frame_end_duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:300:16 [INFO] [stderr] | [INFO] [stderr] 300 | if let Some(_) = e.after_render_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 301 | | window.device.cleanup(); [INFO] [stderr] 302 | | } [INFO] [stderr] | |_________- help: try this: `if e.after_render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:304:16 [INFO] [stderr] | [INFO] [stderr] 304 | if let Some(_) = e.update_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 305 | | use std::i32; [INFO] [stderr] 306 | | // HACK(eddyb) find the closest chunk to the player. [INFO] [stderr] 307 | | // The pending vector should be sorted instead. [INFO] [stderr] ... | [INFO] [stderr] 346 | | } [INFO] [stderr] 347 | | } [INFO] [stderr] | |_________- help: try this: `if e.update_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | / match pending { [INFO] [stderr] 330 | | Some((coords, buffer, chunks)) => { [INFO] [stderr] 331 | | fill_buffer( [INFO] [stderr] 332 | | &mut staging_buffer, [INFO] [stderr] ... | [INFO] [stderr] 345 | | None => {} [INFO] [stderr] 346 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 329 | if let Some((coords, buffer, chunks)) = pending { [INFO] [stderr] 330 | fill_buffer( [INFO] [stderr] 331 | &mut staging_buffer, [INFO] [stderr] 332 | Vec3::from(coords), chunks [INFO] [stderr] 333 | ); [INFO] [stderr] 334 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:349:16 [INFO] [stderr] | [INFO] [stderr] 349 | if let Some(_) = e.resize_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 350 | | let Size { width, height } = window.size(); [INFO] [stderr] 351 | | println!("Window size changed to {}, {}", width, height); [INFO] [stderr] 352 | | [INFO] [stderr] ... | [INFO] [stderr] 371 | | renderer.set_projection(projection_mat);*/ [INFO] [stderr] 372 | | } [INFO] [stderr] | |_________- help: try this: `if e.resize_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:382:16 [INFO] [stderr] | [INFO] [stderr] 382 | if let Some(_) = e.mouse_relative_args() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 383 | | if !capture_cursor { [INFO] [stderr] 384 | | // Don't send the mouse event to the FPS controller. [INFO] [stderr] 385 | | continue; [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_________- help: try this: `if e.mouse_relative_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cube_age`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7742fe8a4659b35a9c1d5aefd986e4ad55baaf0cad292fd0892e2880458a4a56"` [INFO] running `"docker" "rm" "-f" "7742fe8a4659b35a9c1d5aefd986e4ad55baaf0cad292fd0892e2880458a4a56"` [INFO] [stdout] 7742fe8a4659b35a9c1d5aefd986e4ad55baaf0cad292fd0892e2880458a4a56