[INFO] updating cached repository Spooky-Action-Developers/Project-Ironclad
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Spooky-Action-Developers/Project-Ironclad
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Spooky-Action-Developers/Project-Ironclad" "work/ex/clippy-test-run/sources/stable/gh/Spooky-Action-Developers/Project-Ironclad"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Spooky-Action-Developers/Project-Ironclad'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Spooky-Action-Developers/Project-Ironclad" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Spooky-Action-Developers/Project-Ironclad"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Spooky-Action-Developers/Project-Ironclad'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a24e7ffefffb237fe46f8b93cb2427a499e45119
[INFO] sha for GitHub repo Spooky-Action-Developers/Project-Ironclad: a24e7ffefffb237fe46f8b93cb2427a499e45119
[INFO] validating manifest of Spooky-Action-Developers/Project-Ironclad on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Spooky-Action-Developers/Project-Ironclad on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Spooky-Action-Developers/Project-Ironclad
[INFO] finished frobbing Spooky-Action-Developers/Project-Ironclad
[INFO] frobbed toml for Spooky-Action-Developers/Project-Ironclad written to work/ex/clippy-test-run/sources/stable/gh/Spooky-Action-Developers/Project-Ironclad/Cargo.toml
[INFO] started frobbing Spooky-Action-Developers/Project-Ironclad
[INFO] finished frobbing Spooky-Action-Developers/Project-Ironclad
[INFO] frobbed toml for Spooky-Action-Developers/Project-Ironclad written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Spooky-Action-Developers/Project-Ironclad/Cargo.toml
[INFO] crate Spooky-Action-Developers/Project-Ironclad has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Spooky-Action-Developers/Project-Ironclad against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Spooky-Action-Developers/Project-Ironclad:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0a2373513fe08171303467d089c1b6ff9b4805837f35d894c8f8569784ddbbdc
[INFO] running `"docker" "start" "-a" "0a2373513fe08171303467d089c1b6ff9b4805837f35d894c8f8569784ddbbdc"`
[INFO] [stderr]     Checking bytes v0.4.7
[INFO] [stderr]     Checking tokio-io v0.1.6
[INFO] [stderr]     Checking tokio-reactor v0.1.1
[INFO] [stderr]     Checking tokio-fs v0.1.0
[INFO] [stderr]     Checking tokio-udp v0.1.0
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio v0.1.6
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper v0.11.27
[INFO] [stderr]     Checking hyper-tls v0.1.3
[INFO] [stderr]     Checking rusoto_credential v0.11.0
[INFO] [stderr]     Checking rusoto_core v0.32.0
[INFO] [stderr]     Checking rusoto_dynamodb v0.32.0
[INFO] [stderr]     Checking rusoto_iam v0.32.0
[INFO] [stderr]     Checking rusoto_kms v0.32.0
[INFO] [stderr]     Checking ironclad v0.4.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/secrets.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 encryption_context: encryption_context,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encryption_context`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/secrets.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 encryption_context: encryption_context,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encryption_context`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/secrets.rs:43:90
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub fn put_item(table_name: &str, secret_name: &str, secret: &str, version_number: &str) -> () {
[INFO] [stderr]    |                                                                                          ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/secrets.rs:87:76
[INFO] [stderr]    |
[INFO] [stderr] 87 | pub fn get_item(table_name: &str, secret_name: &str, version_number: &str) -> () {
[INFO] [stderr]    |                                                                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/secrets.rs:166:34
[INFO] [stderr]     |
[INFO] [stderr] 166 | pub fn get_all(table_name: &str) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/secrets.rs:199:78
[INFO] [stderr]     |
[INFO] [stderr] 199 | pub fn delete_item(table_name: &str, secret_name: &str, secret_number: &str) -> () {
[INFO] [stderr]     |                                                                              ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/secrets.rs:221:37
[INFO] [stderr]     |
[INFO] [stderr] 221 | pub fn list_items(table_name: &str) -> () {
[INFO] [stderr]     |                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:13:22
[INFO] [stderr]    |
[INFO] [stderr] 13 |         "default" => return Some(Region::default()),
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::default())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:14:29
[INFO] [stderr]    |
[INFO] [stderr] 14 |         "ap-northeast-1" => return Some(Region::ApNortheast1),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApNortheast1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:15:29
[INFO] [stderr]    |
[INFO] [stderr] 15 |         "ap-northeast-2" => return Some(Region::ApNortheast2),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApNortheast2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 |         "ap-south-1" => return Some(Region::ApSouth1),
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApSouth1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:17:29
[INFO] [stderr]    |
[INFO] [stderr] 17 |         "ap-southeast-1" => return Some(Region::ApSoutheast1),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApSoutheast1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:18:29
[INFO] [stderr]    |
[INFO] [stderr] 18 |         "ap-southeast-2" => return Some(Region::ApSoutheast2),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApSoutheast2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:19:27
[INFO] [stderr]    |
[INFO] [stderr] 19 |         "ca-central-1" => return Some(Region::CaCentral1),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::CaCentral1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:20:27
[INFO] [stderr]    |
[INFO] [stderr] 20 |         "eu-central-1" => return Some(Region::EuCentral1),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::EuCentral1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:21:24
[INFO] [stderr]    |
[INFO] [stderr] 21 |         "eu-west-1" => return Some(Region::EuWest1),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::EuWest1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:22:24
[INFO] [stderr]    |
[INFO] [stderr] 22 |         "eu-west-2" => return Some(Region::EuWest2),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::EuWest2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:23:24
[INFO] [stderr]    |
[INFO] [stderr] 23 |         "eu-west-3" => return Some(Region::EuWest3),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::EuWest3)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:24:24
[INFO] [stderr]    |
[INFO] [stderr] 24 |         "sa-east-1" => return Some(Region::SaEast1),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::SaEast1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:25:24
[INFO] [stderr]    |
[INFO] [stderr] 25 |         "us-east-1" => return Some(Region::UsEast1),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsEast1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 |         "us-east-2" => return Some(Region::UsEast2),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsEast2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:27:24
[INFO] [stderr]    |
[INFO] [stderr] 27 |         "us-west-1" => return Some(Region::UsWest1),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsWest1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:28:24
[INFO] [stderr]    |
[INFO] [stderr] 28 |         "us-west-2" => return Some(Region::UsWest2),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsWest2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:29:27
[INFO] [stderr]    |
[INFO] [stderr] 29 |         "us-govwest-1" => return Some(Region::UsGovWest1),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsGovWest1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |         "cn-north-1" => return Some(Region::CnNorth1),
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::CnNorth1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:31:29
[INFO] [stderr]    |
[INFO] [stderr] 31 |         "cn-northwest-1" => return Some(Region::CnNorthwest1),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::CnNorthwest1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/tables.rs:36:36
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn list_tables(region: Region) -> () {
[INFO] [stderr]    |                                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/tables.rs:64:47
[INFO] [stderr]    |
[INFO] [stderr] 64 | pub fn table_creator(reg: Region, name: &str) -> () {
[INFO] [stderr]    |                                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/tables.rs:89:47
[INFO] [stderr]    |
[INFO] [stderr] 89 | pub fn table_deleter(reg: Region, name: &str) -> () {
[INFO] [stderr]    |                                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/secrets.rs:23:11
[INFO] [stderr]    |
[INFO] [stderr] 23 |     data: &String,
[INFO] [stderr]    |           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:114:28
[INFO] [stderr]     |
[INFO] [stderr] 114 |             let got_name = got_item.get("name").unwrap().clone();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&got_item["name"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:116:31
[INFO] [stderr]     |
[INFO] [stderr] 116 |             let got_version = got_item.get("version").unwrap().clone();
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&got_item["version"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:119:30
[INFO] [stderr]     |
[INFO] [stderr] 119 |             let got_secret = got_item.get("secret").unwrap().clone();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&got_item["secret"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/secrets.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 | /     match scan_output.items {
[INFO] [stderr] 185 | |         Some(vector) => {
[INFO] [stderr] 186 | |             for secrets in vector {
[INFO] [stderr] 187 | |                 let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr] ...   |
[INFO] [stderr] 195 | |         None => {}
[INFO] [stderr] 196 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 184 |     if let Some(vector) = scan_output.items {
[INFO] [stderr] 185 |     for secrets in vector {
[INFO] [stderr] 186 |         let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr] 187 |         let secret_name = &*secret.s.unwrap();
[INFO] [stderr] 188 | 
[INFO] [stderr] 189 |         let mut versions = secrets.get("version").unwrap().clone();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:187:34
[INFO] [stderr]     |
[INFO] [stderr] 187 |                 let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&secrets["name"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:190:36
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 let mut versions = secrets.get("version").unwrap().clone();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&secrets["version"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/secrets.rs:238:5
[INFO] [stderr]     |
[INFO] [stderr] 238 | /     match scan_output.items {
[INFO] [stderr] 239 | |         Some(vector) => {
[INFO] [stderr] 240 | |             let mut count = 1;
[INFO] [stderr] 241 | |             for secrets in vector {
[INFO] [stderr] ...   |
[INFO] [stderr] 254 | |         None => {}
[INFO] [stderr] 255 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 238 |     if let Some(vector) = scan_output.items {
[INFO] [stderr] 239 |     let mut count = 1;
[INFO] [stderr] 240 |     for secrets in vector {
[INFO] [stderr] 241 |         let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr] 242 |         let secret_name = &*secret.s.unwrap();
[INFO] [stderr] 243 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:242:34
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&secrets["name"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:245:36
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 let mut versions = secrets.get("version").unwrap().clone();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&secrets["version"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/secrets.rs:251:17
[INFO] [stderr]     |
[INFO] [stderr] 251 |                 count = count + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/secrets.rs:43:90
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub fn put_item(table_name: &str, secret_name: &str, secret: &str, version_number: &str) -> () {
[INFO] [stderr]    |                                                                                          ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/secrets.rs:87:76
[INFO] [stderr]    |
[INFO] [stderr] 87 | pub fn get_item(table_name: &str, secret_name: &str, version_number: &str) -> () {
[INFO] [stderr]    |                                                                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/secrets.rs:166:34
[INFO] [stderr]     |
[INFO] [stderr] 166 | pub fn get_all(table_name: &str) -> () {
[INFO] [stderr]     |                                  ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/secrets.rs:199:78
[INFO] [stderr]     |
[INFO] [stderr] 199 | pub fn delete_item(table_name: &str, secret_name: &str, secret_number: &str) -> () {
[INFO] [stderr]     |                                                                              ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/secrets.rs:221:37
[INFO] [stderr]     |
[INFO] [stderr] 221 | pub fn list_items(table_name: &str) -> () {
[INFO] [stderr]     |                                     ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:13:22
[INFO] [stderr]    |
[INFO] [stderr] 13 |         "default" => return Some(Region::default()),
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::default())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:14:29
[INFO] [stderr]    |
[INFO] [stderr] 14 |         "ap-northeast-1" => return Some(Region::ApNortheast1),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApNortheast1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:15:29
[INFO] [stderr]    |
[INFO] [stderr] 15 |         "ap-northeast-2" => return Some(Region::ApNortheast2),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApNortheast2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:16:25
[INFO] [stderr]    |
[INFO] [stderr] 16 |         "ap-south-1" => return Some(Region::ApSouth1),
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApSouth1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:17:29
[INFO] [stderr]    |
[INFO] [stderr] 17 |         "ap-southeast-1" => return Some(Region::ApSoutheast1),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApSoutheast1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:18:29
[INFO] [stderr]    |
[INFO] [stderr] 18 |         "ap-southeast-2" => return Some(Region::ApSoutheast2),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::ApSoutheast2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:19:27
[INFO] [stderr]    |
[INFO] [stderr] 19 |         "ca-central-1" => return Some(Region::CaCentral1),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::CaCentral1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:20:27
[INFO] [stderr]    |
[INFO] [stderr] 20 |         "eu-central-1" => return Some(Region::EuCentral1),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::EuCentral1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:21:24
[INFO] [stderr]    |
[INFO] [stderr] 21 |         "eu-west-1" => return Some(Region::EuWest1),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::EuWest1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:22:24
[INFO] [stderr]    |
[INFO] [stderr] 22 |         "eu-west-2" => return Some(Region::EuWest2),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::EuWest2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:23:24
[INFO] [stderr]    |
[INFO] [stderr] 23 |         "eu-west-3" => return Some(Region::EuWest3),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::EuWest3)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:24:24
[INFO] [stderr]    |
[INFO] [stderr] 24 |         "sa-east-1" => return Some(Region::SaEast1),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::SaEast1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:25:24
[INFO] [stderr]    |
[INFO] [stderr] 25 |         "us-east-1" => return Some(Region::UsEast1),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsEast1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 |         "us-east-2" => return Some(Region::UsEast2),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsEast2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:27:24
[INFO] [stderr]    |
[INFO] [stderr] 27 |         "us-west-1" => return Some(Region::UsWest1),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsWest1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:28:24
[INFO] [stderr]    |
[INFO] [stderr] 28 |         "us-west-2" => return Some(Region::UsWest2),
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsWest2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:29:27
[INFO] [stderr]    |
[INFO] [stderr] 29 |         "us-govwest-1" => return Some(Region::UsGovWest1),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::UsGovWest1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:30:25
[INFO] [stderr]    |
[INFO] [stderr] 30 |         "cn-north-1" => return Some(Region::CnNorth1),
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::CnNorth1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/tables.rs:31:29
[INFO] [stderr]    |
[INFO] [stderr] 31 |         "cn-northwest-1" => return Some(Region::CnNorthwest1),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Region::CnNorthwest1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/tables.rs:36:36
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn list_tables(region: Region) -> () {
[INFO] [stderr]    |                                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/tables.rs:64:47
[INFO] [stderr]    |
[INFO] [stderr] 64 | pub fn table_creator(reg: Region, name: &str) -> () {
[INFO] [stderr]    |                                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/tables.rs:89:47
[INFO] [stderr]    |
[INFO] [stderr] 89 | pub fn table_deleter(reg: Region, name: &str) -> () {
[INFO] [stderr]    |                                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/secrets.rs:23:11
[INFO] [stderr]    |
[INFO] [stderr] 23 |     data: &String,
[INFO] [stderr]    |           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:114:28
[INFO] [stderr]     |
[INFO] [stderr] 114 |             let got_name = got_item.get("name").unwrap().clone();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&got_item["name"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:116:31
[INFO] [stderr]     |
[INFO] [stderr] 116 |             let got_version = got_item.get("version").unwrap().clone();
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&got_item["version"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:119:30
[INFO] [stderr]     |
[INFO] [stderr] 119 |             let got_secret = got_item.get("secret").unwrap().clone();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&got_item["secret"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/secrets.rs:184:5
[INFO] [stderr]     |
[INFO] [stderr] 184 | /     match scan_output.items {
[INFO] [stderr] 185 | |         Some(vector) => {
[INFO] [stderr] 186 | |             for secrets in vector {
[INFO] [stderr] 187 | |                 let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr] ...   |
[INFO] [stderr] 195 | |         None => {}
[INFO] [stderr] 196 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 184 |     if let Some(vector) = scan_output.items {
[INFO] [stderr] 185 |     for secrets in vector {
[INFO] [stderr] 186 |         let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr] 187 |         let secret_name = &*secret.s.unwrap();
[INFO] [stderr] 188 | 
[INFO] [stderr] 189 |         let mut versions = secrets.get("version").unwrap().clone();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:187:34
[INFO] [stderr]     |
[INFO] [stderr] 187 |                 let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&secrets["name"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:190:36
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 let mut versions = secrets.get("version").unwrap().clone();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&secrets["version"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/secrets.rs:238:5
[INFO] [stderr]     |
[INFO] [stderr] 238 | /     match scan_output.items {
[INFO] [stderr] 239 | |         Some(vector) => {
[INFO] [stderr] 240 | |             let mut count = 1;
[INFO] [stderr] 241 | |             for secrets in vector {
[INFO] [stderr] ...   |
[INFO] [stderr] 254 | |         None => {}
[INFO] [stderr] 255 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 238 |     if let Some(vector) = scan_output.items {
[INFO] [stderr] 239 |     let mut count = 1;
[INFO] [stderr] 240 |     for secrets in vector {
[INFO] [stderr] 241 |         let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr] 242 |         let secret_name = &*secret.s.unwrap();
[INFO] [stderr] 243 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:242:34
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 let mut secret = secrets.get("name").unwrap().clone();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&secrets["name"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/secrets.rs:245:36
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 let mut versions = secrets.get("version").unwrap().clone();
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&secrets["version"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/secrets.rs:251:17
[INFO] [stderr]     |
[INFO] [stderr] 251 |                 count = count + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 18s
[INFO] running `"docker" "inspect" "0a2373513fe08171303467d089c1b6ff9b4805837f35d894c8f8569784ddbbdc"`
[INFO] running `"docker" "rm" "-f" "0a2373513fe08171303467d089c1b6ff9b4805837f35d894c8f8569784ddbbdc"`
[INFO] [stdout] 0a2373513fe08171303467d089c1b6ff9b4805837f35d894c8f8569784ddbbdc