[INFO] updating cached repository SpinResearch/RustySecrets [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SpinResearch/RustySecrets [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SpinResearch/RustySecrets" "work/ex/clippy-test-run/sources/stable/gh/SpinResearch/RustySecrets"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SpinResearch/RustySecrets'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SpinResearch/RustySecrets" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SpinResearch/RustySecrets"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SpinResearch/RustySecrets'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 38f98ff87eb42c55056c89578f89a0ef97f32c20 [INFO] sha for GitHub repo SpinResearch/RustySecrets: 38f98ff87eb42c55056c89578f89a0ef97f32c20 [INFO] validating manifest of SpinResearch/RustySecrets on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SpinResearch/RustySecrets on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SpinResearch/RustySecrets [INFO] finished frobbing SpinResearch/RustySecrets [INFO] frobbed toml for SpinResearch/RustySecrets written to work/ex/clippy-test-run/sources/stable/gh/SpinResearch/RustySecrets/Cargo.toml [INFO] started frobbing SpinResearch/RustySecrets [INFO] finished frobbing SpinResearch/RustySecrets [INFO] frobbed toml for SpinResearch/RustySecrets written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SpinResearch/RustySecrets/Cargo.toml [INFO] crate SpinResearch/RustySecrets has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SpinResearch/RustySecrets against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SpinResearch/RustySecrets:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 68684a5f08967eab66f363b1a93a5906c291e53a8715f1fa1c973545dd9bea42 [INFO] running `"docker" "start" "-a" "68684a5f08967eab66f363b1a93a5906c291e53a8715f1fa1c973545dd9bea42"` [INFO] [stderr] Checking protobuf v1.5.1 [INFO] [stderr] Compiling rusty_secrets v0.2.3-pre (/opt/crater/workdir) [INFO] [stderr] Checking miniz-sys v0.1.10 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking lamport_sigs v0.5.0 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking quickcheck v0.4.1 [INFO] [stderr] Checking merkle v1.5.0 [INFO] [stderr] Checking merkle_sigs v1.4.0 [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/wrapped/secret.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/wrapped/share.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/version.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/wrapped/secret.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/wrapped/share.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/proto/version.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:45 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pow` [INFO] [stderr] --> src/gf256.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn pow(&self, mut exp: u8) -> Gf256 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `interpolate` [INFO] [stderr] --> src/lagrange.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | pub(crate) fn interpolate(points: &[(Gf256, Gf256)]) -> Poly { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `MAX_COEFFS` [INFO] [stderr] --> src/poly.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | static MAX_COEFFS: usize = 256; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Poly` [INFO] [stderr] --> src/poly.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub(crate) struct Poly { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/poly.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(coeffs: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `evaluate_at_zero` [INFO] [stderr] --> src/poly.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn evaluate_at_zero(&self) -> Gf256 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `evaluate_at` [INFO] [stderr] --> src/poly.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn evaluate_at(&self, x: Gf256) -> Gf256 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `u32_to_bytes` [INFO] [stderr] --> src/vol_hash.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn u32_to_bytes(x: u32) -> [u8; 4] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `VOLHash` [INFO] [stderr] --> src/vol_hash.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct VOLHash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/vol_hash.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(algorithm: &'static Algorithm) -> VOLHash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `process` [INFO] [stderr] --> src/vol_hash.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn process(&mut self, bytes: &[u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `finish` [INFO] [stderr] --> src/vol_hash.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn finish(self, dest: &mut [u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gf256.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn to_byte(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gf256.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn log(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gf256.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn pow(&self, mut exp: u8) -> Gf256 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/gf256.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | acc = acc * base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc *= base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/gf256.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | acc = acc * base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc *= base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/gf256.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | Gf256::from_byte(self.poly ^ rhs.poly) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/gf256.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | Gf256::from_byte(self.poly ^ rhs.poly) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/share/validation.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | shares: &Vec, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[S]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/share/validation.rs:25:51 [INFO] [stderr] | [INFO] [stderr] 25 | pub(crate) fn validate_shares(shares: &Vec) -> Result<(u8, usize)> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[S]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/errors.rs:152:57 [INFO] [stderr] | [INFO] [stderr] 152 | fn no_more_than_five(vec: &Vec) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/sss/share.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | raws.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sss/scheme.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sss/encode.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | for raw_x in 1..(u16::from(n) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/wrapped_secrets/scheme.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_secrets`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `evaluate_at_zero` [INFO] [stderr] --> src/poly.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn evaluate_at_zero(&self) -> Gf256 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `u32_to_bytes` [INFO] [stderr] --> src/vol_hash.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn u32_to_bytes(x: u32) -> [u8; 4] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `VOLHash` [INFO] [stderr] --> src/vol_hash.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct VOLHash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/vol_hash.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn new(algorithm: &'static Algorithm) -> VOLHash { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `process` [INFO] [stderr] --> src/vol_hash.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn process(&mut self, bytes: &[u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `finish` [INFO] [stderr] --> src/vol_hash.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn finish(self, dest: &mut [u8]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gf256.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn to_byte(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gf256.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn log(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gf256.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn pow(&self, mut exp: u8) -> Gf256 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/gf256.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | acc = acc * base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc *= base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/gf256.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | acc = acc * base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `acc *= base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/gf256.rs:73:36 [INFO] [stderr] | [INFO] [stderr] 73 | Gf256::from_byte(self.poly ^ rhs.poly) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/gf256.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | Gf256::from_byte(self.poly ^ rhs.poly) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/gf256.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | a + b == b + a [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/gf256.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | a * b == b * a [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/share/validation.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | shares: &Vec, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[S]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/share/validation.rs:25:51 [INFO] [stderr] | [INFO] [stderr] 25 | pub(crate) fn validate_shares(shares: &Vec) -> Result<(u8, usize)> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[S]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/errors.rs:152:57 [INFO] [stderr] | [INFO] [stderr] 152 | fn no_more_than_five(vec: &Vec) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/sss/share.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | raws.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sss/scheme.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sss/encode.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | for raw_x in 1..(u16::from(n) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/wrapped_secrets/scheme.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_secrets`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "68684a5f08967eab66f363b1a93a5906c291e53a8715f1fa1c973545dd9bea42"` [INFO] running `"docker" "rm" "-f" "68684a5f08967eab66f363b1a93a5906c291e53a8715f1fa1c973545dd9bea42"` [INFO] [stdout] 68684a5f08967eab66f363b1a93a5906c291e53a8715f1fa1c973545dd9bea42