[INFO] updating cached repository Speedy-Consoles/suffix_tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Speedy-Consoles/suffix_tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Speedy-Consoles/suffix_tree" "work/ex/clippy-test-run/sources/stable/gh/Speedy-Consoles/suffix_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Speedy-Consoles/suffix_tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Speedy-Consoles/suffix_tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Speedy-Consoles/suffix_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Speedy-Consoles/suffix_tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e0fad7bc01f569bdd59ac045efd8f5c1ca43282 [INFO] sha for GitHub repo Speedy-Consoles/suffix_tree: 7e0fad7bc01f569bdd59ac045efd8f5c1ca43282 [INFO] validating manifest of Speedy-Consoles/suffix_tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Speedy-Consoles/suffix_tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Speedy-Consoles/suffix_tree [INFO] finished frobbing Speedy-Consoles/suffix_tree [INFO] frobbed toml for Speedy-Consoles/suffix_tree written to work/ex/clippy-test-run/sources/stable/gh/Speedy-Consoles/suffix_tree/Cargo.toml [INFO] started frobbing Speedy-Consoles/suffix_tree [INFO] finished frobbing Speedy-Consoles/suffix_tree [INFO] frobbed toml for Speedy-Consoles/suffix_tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Speedy-Consoles/suffix_tree/Cargo.toml [INFO] crate Speedy-Consoles/suffix_tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Speedy-Consoles/suffix_tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Speedy-Consoles/suffix_tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da6ab76b5bc6df626e68500dc2c7a02790f899576c01cdb63fcaaf4c477aaf18 [INFO] running `"docker" "start" "-a" "da6ab76b5bc6df626e68500dc2c7a02790f899576c01cdb63fcaaf4c477aaf18"` [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Compiling rand v0.5.4 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking bytes v0.4.10 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking openssl-sys v0.9.39 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking openssl v0.10.14 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking native-tls v0.2.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.12 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.3 [INFO] [stderr] Checking suffix_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/suffix_tree.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return st; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `st` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sorted_vec.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/suffix_tree.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | let node_index = if threads.contains_key(&first_char) { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 48 | | let thread = threads.get_mut(&first_char).unwrap(); [INFO] [stderr] 49 | | let thread_string = &haystack[thread.thread_start..]; [INFO] [stderr] 50 | | let thread_offset = diff_pos(thread_string, rem_suffix); [INFO] [stderr] ... | [INFO] [stderr] 72 | | break; [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_________________^ help: consider using: `threads.entry(first_char)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/suffix_tree.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return st; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `st` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sorted_vec.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/suffix_tree.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | let node_index = if threads.contains_key(&first_char) { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 48 | | let thread = threads.get_mut(&first_char).unwrap(); [INFO] [stderr] 49 | | let thread_string = &haystack[thread.thread_start..]; [INFO] [stderr] 50 | | let thread_offset = diff_pos(thread_string, rem_suffix); [INFO] [stderr] ... | [INFO] [stderr] 72 | | break; [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_________________^ help: consider using: `threads.entry(first_char)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.44s [INFO] running `"docker" "inspect" "da6ab76b5bc6df626e68500dc2c7a02790f899576c01cdb63fcaaf4c477aaf18"` [INFO] running `"docker" "rm" "-f" "da6ab76b5bc6df626e68500dc2c7a02790f899576c01cdb63fcaaf4c477aaf18"` [INFO] [stdout] da6ab76b5bc6df626e68500dc2c7a02790f899576c01cdb63fcaaf4c477aaf18