[INFO] updating cached repository Spark-NF/rs-tracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Spark-NF/rs-tracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Spark-NF/rs-tracer" "work/ex/clippy-test-run/sources/stable/gh/Spark-NF/rs-tracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Spark-NF/rs-tracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Spark-NF/rs-tracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Spark-NF/rs-tracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Spark-NF/rs-tracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 200a7b2fec85c88c4ec5294a9623d221644dfdc3 [INFO] sha for GitHub repo Spark-NF/rs-tracer: 200a7b2fec85c88c4ec5294a9623d221644dfdc3 [INFO] validating manifest of Spark-NF/rs-tracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Spark-NF/rs-tracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Spark-NF/rs-tracer [INFO] finished frobbing Spark-NF/rs-tracer [INFO] frobbed toml for Spark-NF/rs-tracer written to work/ex/clippy-test-run/sources/stable/gh/Spark-NF/rs-tracer/Cargo.toml [INFO] started frobbing Spark-NF/rs-tracer [INFO] finished frobbing Spark-NF/rs-tracer [INFO] frobbed toml for Spark-NF/rs-tracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Spark-NF/rs-tracer/Cargo.toml [INFO] crate Spark-NF/rs-tracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Spark-NF/rs-tracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Spark-NF/rs-tracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b18c07d5648212e3f4df46d040f00603972c1f236832dfd2a11884b9eb190eaf [INFO] running `"docker" "start" "-a" "b18c07d5648212e3f4df46d040f00603972c1f236832dfd2a11884b9eb190eaf"` [INFO] [stderr] Checking serde_json v1.0.12 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / let mut light_power = 0.0; [INFO] [stderr] 69 | | if light_direction.x == 0.0 && light_direction.y == 0.0 && light_direction.z == 0.0 { [INFO] [stderr] 70 | | light_power = light.get_intensity(&hit); [INFO] [stderr] 71 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let light_power = if light_direction.x == 0.0 && light_direction.y == 0.0 && light_direction.z == 0.0 { light.get_intensity(&hit) } else { ..; 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / let mut light_power = 0.0; [INFO] [stderr] 69 | | if light_direction.x == 0.0 && light_direction.y == 0.0 && light_direction.z == 0.0 { [INFO] [stderr] 70 | | light_power = light.get_intensity(&hit); [INFO] [stderr] 71 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let light_power = if light_direction.x == 0.0 && light_direction.y == 0.0 && light_direction.z == 0.0 { light.get_intensity(&hit) } else { ..; 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.91s [INFO] running `"docker" "inspect" "b18c07d5648212e3f4df46d040f00603972c1f236832dfd2a11884b9eb190eaf"` [INFO] running `"docker" "rm" "-f" "b18c07d5648212e3f4df46d040f00603972c1f236832dfd2a11884b9eb190eaf"` [INFO] [stdout] b18c07d5648212e3f4df46d040f00603972c1f236832dfd2a11884b9eb190eaf