[INFO] updating cached repository SolidTux/durakserver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SolidTux/durakserver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SolidTux/durakserver" "work/ex/clippy-test-run/sources/stable/gh/SolidTux/durakserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SolidTux/durakserver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SolidTux/durakserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SolidTux/durakserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SolidTux/durakserver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b3202172ab3a4447b088bc05f68b884f60c5913e [INFO] sha for GitHub repo SolidTux/durakserver: b3202172ab3a4447b088bc05f68b884f60c5913e [INFO] validating manifest of SolidTux/durakserver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SolidTux/durakserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SolidTux/durakserver [INFO] finished frobbing SolidTux/durakserver [INFO] frobbed toml for SolidTux/durakserver written to work/ex/clippy-test-run/sources/stable/gh/SolidTux/durakserver/Cargo.toml [INFO] started frobbing SolidTux/durakserver [INFO] finished frobbing SolidTux/durakserver [INFO] frobbed toml for SolidTux/durakserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SolidTux/durakserver/Cargo.toml [INFO] crate SolidTux/durakserver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SolidTux/durakserver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SolidTux/durakserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d3d6a8704a2fe5dfb6c6a65ccbea839c1e0840859dfa9ca09c1fc5eb9fdda0a7 [INFO] running `"docker" "start" "-a" "d3d6a8704a2fe5dfb6c6a65ccbea839c1e0840859dfa9ca09c1fc5eb9fdda0a7"` [INFO] [stderr] Checking durakserver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | rules: rules, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | rules: rules, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:408:13 [INFO] [stderr] | [INFO] [stderr] 408 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | suite: suite, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `suite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:511:13 [INFO] [stderr] | [INFO] [stderr] 511 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | suite: suite, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `suite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | rules: rules, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | rules: rules, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:408:13 [INFO] [stderr] | [INFO] [stderr] 408 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | suite: suite, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `suite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:511:13 [INFO] [stderr] | [INFO] [stderr] 511 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:512:13 [INFO] [stderr] | [INFO] [stderr] 512 | suite: suite, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `suite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game.rs:416:16 [INFO] [stderr] | [INFO] [stderr] 416 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 417 | | if self.suite == trump { [INFO] [stderr] 418 | | Some(true) [INFO] [stderr] 419 | | } else if c.suite == trump { [INFO] [stderr] ... | [INFO] [stderr] 423 | | } [INFO] [stderr] 424 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 416 | } else if self.suite == trump { [INFO] [stderr] 417 | Some(true) [INFO] [stderr] 418 | } else if c.suite == trump { [INFO] [stderr] 419 | Some(false) [INFO] [stderr] 420 | } else { [INFO] [stderr] 421 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game.rs:416:16 [INFO] [stderr] | [INFO] [stderr] 416 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 417 | | if self.suite == trump { [INFO] [stderr] 418 | | Some(true) [INFO] [stderr] 419 | | } else if c.suite == trump { [INFO] [stderr] ... | [INFO] [stderr] 423 | | } [INFO] [stderr] 424 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 416 | } else if self.suite == trump { [INFO] [stderr] 417 | Some(true) [INFO] [stderr] 418 | } else if c.suite == trump { [INFO] [stderr] 419 | Some(false) [INFO] [stderr] 420 | } else { [INFO] [stderr] 421 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | client: &ClientHash, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClientHash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/game.rs:123:45 [INFO] [stderr] | [INFO] [stderr] 123 | self.players.entry(*client).or_insert(Player::new()).name = name; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Player::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | client: &ClientHash, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClientHash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/game.rs:172:33 [INFO] [stderr] | [INFO] [stderr] 172 | / if player.table.is_none() { [INFO] [stderr] 173 | | player.table = Some(tablehash); [INFO] [stderr] 174 | | table.players.push(*client); [INFO] [stderr] 175 | | None [INFO] [stderr] 176 | | } else { [INFO] [stderr] 177 | | direct_error!(GameError, "Already joined a table.") [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________________________________^ help: replace_it_with: `player.table?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | client: &ClientHash, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClientHash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | / match self { [INFO] [stderr] 443 | | &Suite::Diamonds => write!(f, "1"), [INFO] [stderr] 444 | | &Suite::Hearts => write!(f, "2"), [INFO] [stderr] 445 | | &Suite::Spades => write!(f, "3"), [INFO] [stderr] 446 | | &Suite::Clubs => write!(f, "4"), [INFO] [stderr] 447 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 442 | match *self { [INFO] [stderr] 443 | Suite::Diamonds => write!(f, "1"), [INFO] [stderr] 444 | Suite::Hearts => write!(f, "2"), [INFO] [stderr] 445 | Suite::Spades => write!(f, "3"), [INFO] [stderr] 446 | Suite::Clubs => write!(f, "4"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rules.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | fn apply(&self, &ClientHash, &mut GameState, &[ClientHash], GameAction) -> Result; [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClientHash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | if !(target == *origin) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `target != *origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules.rs:149:36 [INFO] [stderr] | [INFO] [stderr] 149 | if state.table_stacks.is_empty() && !(attack == *origin) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.table_stacks.is_empty() && attack != *origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/rules.rs:163:92 [INFO] [stderr] | [INFO] [stderr] 163 | if stacks.iter().fold(true, |mut acc, &(ref a, ref b)| { [INFO] [stderr] | ____________________________________________________________________________________________^ [INFO] [stderr] 164 | | acc = acc && !(card.value == a.value); [INFO] [stderr] 165 | | if let Some(ref x) = *b { [INFO] [stderr] 166 | | acc = acc && !(card.value == x.value); [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | acc [INFO] [stderr] 169 | | }) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | client: &ClientHash, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClientHash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/game.rs:123:45 [INFO] [stderr] | [INFO] [stderr] 123 | self.players.entry(*client).or_insert(Player::new()).name = name; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Player::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | client: &ClientHash, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClientHash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/game.rs:172:33 [INFO] [stderr] | [INFO] [stderr] 172 | / if player.table.is_none() { [INFO] [stderr] 173 | | player.table = Some(tablehash); [INFO] [stderr] 174 | | table.players.push(*client); [INFO] [stderr] 175 | | None [INFO] [stderr] 176 | | } else { [INFO] [stderr] 177 | | direct_error!(GameError, "Already joined a table.") [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________________________________^ help: replace_it_with: `player.table?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | client: &ClientHash, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClientHash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/game.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | / match self { [INFO] [stderr] 443 | | &Suite::Diamonds => write!(f, "1"), [INFO] [stderr] 444 | | &Suite::Hearts => write!(f, "2"), [INFO] [stderr] 445 | | &Suite::Spades => write!(f, "3"), [INFO] [stderr] 446 | | &Suite::Clubs => write!(f, "4"), [INFO] [stderr] 447 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 442 | match *self { [INFO] [stderr] 443 | Suite::Diamonds => write!(f, "1"), [INFO] [stderr] 444 | Suite::Hearts => write!(f, "2"), [INFO] [stderr] 445 | Suite::Spades => write!(f, "3"), [INFO] [stderr] 446 | Suite::Clubs => write!(f, "4"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rules.rs:12:21 [INFO] [stderr] | [INFO] [stderr] 12 | fn apply(&self, &ClientHash, &mut GameState, &[ClientHash], GameAction) -> Result; [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClientHash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules.rs:97:36 [INFO] [stderr] | [INFO] [stderr] 97 | if !(target == *origin) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `target != *origin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules.rs:149:36 [INFO] [stderr] | [INFO] [stderr] 149 | if state.table_stacks.is_empty() && !(attack == *origin) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.table_stacks.is_empty() && attack != *origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/rules.rs:163:92 [INFO] [stderr] | [INFO] [stderr] 163 | if stacks.iter().fold(true, |mut acc, &(ref a, ref b)| { [INFO] [stderr] | ____________________________________________________________________________________________^ [INFO] [stderr] 164 | | acc = acc && !(card.value == a.value); [INFO] [stderr] 165 | | if let Some(ref x) = *b { [INFO] [stderr] 166 | | acc = acc && !(card.value == x.value); [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | acc [INFO] [stderr] 169 | | }) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.91s [INFO] running `"docker" "inspect" "d3d6a8704a2fe5dfb6c6a65ccbea839c1e0840859dfa9ca09c1fc5eb9fdda0a7"` [INFO] running `"docker" "rm" "-f" "d3d6a8704a2fe5dfb6c6a65ccbea839c1e0840859dfa9ca09c1fc5eb9fdda0a7"` [INFO] [stdout] d3d6a8704a2fe5dfb6c6a65ccbea839c1e0840859dfa9ca09c1fc5eb9fdda0a7