[INFO] updating cached repository SodiumIodide/Golden-Ratio-Exponent-to-Integer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SodiumIodide/Golden-Ratio-Exponent-to-Integer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer" "work/ex/clippy-test-run/sources/stable/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bbb92b4d342e4a6a2e556ff709f0838c26307ec6 [INFO] sha for GitHub repo SodiumIodide/Golden-Ratio-Exponent-to-Integer: bbb92b4d342e4a6a2e556ff709f0838c26307ec6 [INFO] validating manifest of SodiumIodide/Golden-Ratio-Exponent-to-Integer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SodiumIodide/Golden-Ratio-Exponent-to-Integer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SodiumIodide/Golden-Ratio-Exponent-to-Integer [INFO] finished frobbing SodiumIodide/Golden-Ratio-Exponent-to-Integer [INFO] frobbed toml for SodiumIodide/Golden-Ratio-Exponent-to-Integer written to work/ex/clippy-test-run/sources/stable/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer/Cargo.toml [INFO] started frobbing SodiumIodide/Golden-Ratio-Exponent-to-Integer [INFO] finished frobbing SodiumIodide/Golden-Ratio-Exponent-to-Integer [INFO] frobbed toml for SodiumIodide/Golden-Ratio-Exponent-to-Integer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer/Cargo.toml [INFO] crate SodiumIodide/Golden-Ratio-Exponent-to-Integer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SodiumIodide/Golden-Ratio-Exponent-to-Integer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SodiumIodide/Golden-Ratio-Exponent-to-Integer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 10cb867a232abaecf6a76545ff6226ccfbb417d7ef577d35d2676d362d570bca [INFO] running `"docker" "start" "-a" "10cb867a232abaecf6a76545ff6226ccfbb417d7ef577d35d2676d362d570bca"` [INFO] [stderr] Checking argparse-rs v0.1.0 [INFO] [stderr] Checking goldenratio v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/common.rs:82:3 [INFO] [stderr] | [INFO] [stderr] 82 | self.term.as_ref().map(|t| { fg.set_terminal(&t[..], ""); }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | for x in 1..(numpoints + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=numpoints` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | Common::new().map(|c| plot(c, data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { plot(c, data) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/common.rs:82:3 [INFO] [stderr] | [INFO] [stderr] 82 | self.term.as_ref().map(|t| { fg.set_terminal(&t[..], ""); }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(t) = self.term.as_ref() { fg.set_terminal(&t[..], ""); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | for x in 1..(numpoints + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `1..=numpoints` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | Common::new().map(|c| plot(c, data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = Common::new() { plot(c, data) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "10cb867a232abaecf6a76545ff6226ccfbb417d7ef577d35d2676d362d570bca"` [INFO] running `"docker" "rm" "-f" "10cb867a232abaecf6a76545ff6226ccfbb417d7ef577d35d2676d362d570bca"` [INFO] [stdout] 10cb867a232abaecf6a76545ff6226ccfbb417d7ef577d35d2676d362d570bca