[INFO] updating cached repository Snnappie/game-dev-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Snnappie/game-dev-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Snnappie/game-dev-rs" "work/ex/clippy-test-run/sources/stable/gh/Snnappie/game-dev-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Snnappie/game-dev-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Snnappie/game-dev-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Snnappie/game-dev-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Snnappie/game-dev-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 00d0ee912c6ae31bf4a8ca4078ee4249e3a80d06 [INFO] sha for GitHub repo Snnappie/game-dev-rs: 00d0ee912c6ae31bf4a8ca4078ee4249e3a80d06 [INFO] validating manifest of Snnappie/game-dev-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Snnappie/game-dev-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Snnappie/game-dev-rs [INFO] finished frobbing Snnappie/game-dev-rs [INFO] frobbed toml for Snnappie/game-dev-rs written to work/ex/clippy-test-run/sources/stable/gh/Snnappie/game-dev-rs/Cargo.toml [INFO] started frobbing Snnappie/game-dev-rs [INFO] finished frobbing Snnappie/game-dev-rs [INFO] frobbed toml for Snnappie/game-dev-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Snnappie/game-dev-rs/Cargo.toml [INFO] crate Snnappie/game-dev-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Snnappie/game-dev-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Snnappie/game-dev-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6dfe0f3c3892806a4f2db62d6b5d29a729098e69f1d887135a677e843151403 [INFO] running `"docker" "start" "-a" "d6dfe0f3c3892806a4f2db62d6b5d29a729098e69f1d887135a677e843151403"` [INFO] [stderr] Compiling log v0.4.2 [INFO] [stderr] Compiling phf v0.7.22 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.1 [INFO] [stderr] Checking piston-gfx_texture v0.26.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.43.0 [INFO] [stderr] Checking piston_window v0.70.0 [INFO] [stderr] Checking game-dev-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | if let Some(args) = e.update_args() { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | args: &RenderArgs, [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:154:27 [INFO] [stderr] | [INFO] [stderr] 154 | fn get_key_index(key: &Key) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:164:22 [INFO] [stderr] | [INFO] [stderr] 164 | fn is_shift(key: &Key) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | if let Some(args) = e.update_args() { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | args: &RenderArgs, [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:154:27 [INFO] [stderr] | [INFO] [stderr] 154 | fn get_key_index(key: &Key) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:164:22 [INFO] [stderr] | [INFO] [stderr] 164 | fn is_shift(key: &Key) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `"docker" "inspect" "d6dfe0f3c3892806a4f2db62d6b5d29a729098e69f1d887135a677e843151403"` [INFO] running `"docker" "rm" "-f" "d6dfe0f3c3892806a4f2db62d6b5d29a729098e69f1d887135a677e843151403"` [INFO] [stdout] d6dfe0f3c3892806a4f2db62d6b5d29a729098e69f1d887135a677e843151403