[INFO] updating cached repository SirJson/pyedge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SirJson/pyedge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SirJson/pyedge" "work/ex/clippy-test-run/sources/stable/gh/SirJson/pyedge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SirJson/pyedge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SirJson/pyedge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SirJson/pyedge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SirJson/pyedge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1a444b276301e235314490981ffd535454d9a01f [INFO] sha for GitHub repo SirJson/pyedge: 1a444b276301e235314490981ffd535454d9a01f [INFO] validating manifest of SirJson/pyedge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SirJson/pyedge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SirJson/pyedge [INFO] finished frobbing SirJson/pyedge [INFO] frobbed toml for SirJson/pyedge written to work/ex/clippy-test-run/sources/stable/gh/SirJson/pyedge/Cargo.toml [INFO] started frobbing SirJson/pyedge [INFO] finished frobbing SirJson/pyedge [INFO] frobbed toml for SirJson/pyedge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SirJson/pyedge/Cargo.toml [INFO] crate SirJson/pyedge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SirJson/pyedge against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SirJson/pyedge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 406b8559f0a9c831a0b1c59352d5576789df68780c691660d3e7cf3aa45f195c [INFO] running `"docker" "start" "-a" "406b8559f0a9c831a0b1c59352d5576789df68780c691660d3e7cf3aa45f195c"` [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking pyedge v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:80:54 [INFO] [stderr] | [INFO] [stderr] 80 | let append_zero = *data_slice.last().unwrap() != '\0' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | let size = match append_zero { [INFO] [stderr] | ________________^ [INFO] [stderr] 83 | | true => in_size + 1, [INFO] [stderr] 84 | | false => in_size, [INFO] [stderr] 85 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if append_zero { in_size + 1 } else { in_size }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:106:32 [INFO] [stderr] | [INFO] [stderr] 106 | sys_paths.push(PathBuf::from(path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:80:54 [INFO] [stderr] | [INFO] [stderr] 80 | let append_zero = *data_slice.last().unwrap() != '\0' as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | let size = match append_zero { [INFO] [stderr] | ________________^ [INFO] [stderr] 83 | | true => in_size + 1, [INFO] [stderr] 84 | | false => in_size, [INFO] [stderr] 85 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if append_zero { in_size + 1 } else { in_size }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:106:32 [INFO] [stderr] | [INFO] [stderr] 106 | sys_paths.push(PathBuf::from(path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.85s [INFO] running `"docker" "inspect" "406b8559f0a9c831a0b1c59352d5576789df68780c691660d3e7cf3aa45f195c"` [INFO] running `"docker" "rm" "-f" "406b8559f0a9c831a0b1c59352d5576789df68780c691660d3e7cf3aa45f195c"` [INFO] [stdout] 406b8559f0a9c831a0b1c59352d5576789df68780c691660d3e7cf3aa45f195c