[INFO] updating cached repository Simonmoush/rust_wave
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Simonmoush/rust_wave
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Simonmoush/rust_wave" "work/ex/clippy-test-run/sources/stable/gh/Simonmoush/rust_wave"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Simonmoush/rust_wave'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Simonmoush/rust_wave" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Simonmoush/rust_wave"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Simonmoush/rust_wave'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a669908ea3cd537282a420479ca76c7b24976fed
[INFO] sha for GitHub repo Simonmoush/rust_wave: a669908ea3cd537282a420479ca76c7b24976fed
[INFO] validating manifest of Simonmoush/rust_wave on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Simonmoush/rust_wave on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Simonmoush/rust_wave
[INFO] finished frobbing Simonmoush/rust_wave
[INFO] frobbed toml for Simonmoush/rust_wave written to work/ex/clippy-test-run/sources/stable/gh/Simonmoush/rust_wave/Cargo.toml
[INFO] started frobbing Simonmoush/rust_wave
[INFO] finished frobbing Simonmoush/rust_wave
[INFO] frobbed toml for Simonmoush/rust_wave written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Simonmoush/rust_wave/Cargo.toml
[INFO] crate Simonmoush/rust_wave has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Simonmoush/rust_wave against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Simonmoush/rust_wave:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 39fad74f66dd7c8633ff7404e764104e3d58ffa435fea136f3bee8593a3ca669
[INFO] running `"docker" "start" "-a" "39fad74f66dd7c8633ff7404e764104e3d58ffa435fea136f3bee8593a3ca669"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] [stderr]    Compiling rand v0.3.16
[INFO] [stderr]     Checking shared_library v0.1.7
[INFO] [stderr]     Checking inflate v0.3.2
[INFO] [stderr]     Checking x11-dl v2.15.0
[INFO] [stderr]     Checking fs2 v0.2.5
[INFO] [stderr]     Checking piston2d-graphics v0.22.0
[INFO] [stderr]     Checking pistoncore-window v0.29.0
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking memmap v0.4.0
[INFO] [stderr]    Compiling phf_generator v0.7.21
[INFO] [stderr]     Checking rayon-core v1.2.1
[INFO] [stderr]     Checking tempfile v2.2.0
[INFO] [stderr]    Compiling phf_codegen v0.7.21
[INFO] [stderr]     Checking pistoncore-event_loop v0.34.0
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]    Compiling target_build_utils v0.3.1
[INFO] [stderr]     Checking piston v0.34.0
[INFO] [stderr]     Checking png v0.10.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking image v0.16.0
[INFO] [stderr]    Compiling libloading v0.3.4
[INFO] [stderr]     Checking piston-gfx_texture v0.27.0
[INFO] [stderr]     Checking dlib v0.3.1
[INFO] [stderr]     Checking wayland-sys v0.9.10
[INFO] [stderr]     Checking wayland-client v0.9.10
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.44.0
[INFO] [stderr]     Checking wayland-protocols v0.9.10
[INFO] [stderr]     Checking wayland-kbd v0.9.1
[INFO] [stderr]     Checking wayland-window v0.7.0
[INFO] [stderr]     Checking winit v0.7.6
[INFO] [stderr]     Checking glutin v0.9.2
[INFO] [stderr]     Checking pistoncore-glutin_window v0.40.1
[INFO] [stderr]     Checking piston_window v0.71.1
[INFO] [stderr]     Checking r_wave v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/model.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 | /         if check_x < width && check_x >= 0 {
[INFO] [stderr] 74 | |             if check_y < height && check_y >= 0 {
[INFO] [stderr] 75 | |                 return true
[INFO] [stderr] 76 | |             }
[INFO] [stderr] 77 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 73 |         if check_x < width && check_x >= 0 && check_y < height && check_y >= 0 {
[INFO] [stderr] 74 |     return true
[INFO] [stderr] 75 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/view.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         return new_color;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_color`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/view.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         return new_color;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_color`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/view.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return new_color;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_color`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/view.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     return new_color.color;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_color.color`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `r`
[INFO] [stderr]   --> src/main.rs:22:33
[INFO] [stderr]    |
[INFO] [stderr] 22 |             if let Loop::Render(r) = l {
[INFO] [stderr]    |                                 ^ help: consider using `_r` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `u`
[INFO] [stderr]   --> src/main.rs:24:40
[INFO] [stderr]    |
[INFO] [stderr] 24 |             } else if let Loop::Update(u) = l {
[INFO] [stderr]    |                                        ^ help: consider using `_u` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `with_dot`
[INFO] [stderr]   --> src/model.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     pub fn with_dot(width: usize, height: usize) -> PressureField {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/view.rs:62:47
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 let (h_unit, v_unit, i, j) = (h_unit as f64, v_unit as f64, i as f64, j as f64);
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^ help: try: `f64::from(h_unit)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/view.rs:62:62
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 let (h_unit, v_unit, i, j) = (h_unit as f64, v_unit as f64, i as f64, j as f64);
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^ help: try: `f64::from(v_unit)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:36:21
[INFO] [stderr]    |
[INFO] [stderr] 36 | /                     match mb {
[INFO] [stderr] 37 | |                         mouse::MouseButton::Left => {
[INFO] [stderr] 38 | |                             match b.state {
[INFO] [stderr] 39 | |                                 ButtonState::Press => drag = true,
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |                         _ =>(),
[INFO] [stderr] 44 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 |                     if let mouse::MouseButton::Left = mb {
[INFO] [stderr] 37 |     match b.state {
[INFO] [stderr] 38 |         ButtonState::Press => drag = true,
[INFO] [stderr] 39 |         ButtonState::Release => drag = false,
[INFO] [stderr] 40 |     }
[INFO] [stderr] 41 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/model.rs:73:9
[INFO] [stderr]    |
[INFO] [stderr] 73 | /         if check_x < width && check_x >= 0 {
[INFO] [stderr] 74 | |             if check_y < height && check_y >= 0 {
[INFO] [stderr] 75 | |                 return true
[INFO] [stderr] 76 | |             }
[INFO] [stderr] 77 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 73 |         if check_x < width && check_x >= 0 && check_y < height && check_y >= 0 {
[INFO] [stderr] 74 |     return true
[INFO] [stderr] 75 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/view.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         return new_color;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_color`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/view.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         return new_color;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_color`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/view.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return new_color;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_color`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/view.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     return new_color.color;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_color.color`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `r`
[INFO] [stderr]   --> src/main.rs:22:33
[INFO] [stderr]    |
[INFO] [stderr] 22 |             if let Loop::Render(r) = l {
[INFO] [stderr]    |                                 ^ help: consider using `_r` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `u`
[INFO] [stderr]   --> src/main.rs:24:40
[INFO] [stderr]    |
[INFO] [stderr] 24 |             } else if let Loop::Update(u) = l {
[INFO] [stderr]    |                                        ^ help: consider using `_u` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `with_dot`
[INFO] [stderr]   --> src/model.rs:40:5
[INFO] [stderr]    |
[INFO] [stderr] 40 |     pub fn with_dot(width: usize, height: usize) -> PressureField {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/view.rs:62:47
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 let (h_unit, v_unit, i, j) = (h_unit as f64, v_unit as f64, i as f64, j as f64);
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^ help: try: `f64::from(h_unit)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/view.rs:62:62
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 let (h_unit, v_unit, i, j) = (h_unit as f64, v_unit as f64, i as f64, j as f64);
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^ help: try: `f64::from(v_unit)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:36:21
[INFO] [stderr]    |
[INFO] [stderr] 36 | /                     match mb {
[INFO] [stderr] 37 | |                         mouse::MouseButton::Left => {
[INFO] [stderr] 38 | |                             match b.state {
[INFO] [stderr] 39 | |                                 ButtonState::Press => drag = true,
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |                         _ =>(),
[INFO] [stderr] 44 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 36 |                     if let mouse::MouseButton::Left = mb {
[INFO] [stderr] 37 |     match b.state {
[INFO] [stderr] 38 |         ButtonState::Press => drag = true,
[INFO] [stderr] 39 |         ButtonState::Release => drag = false,
[INFO] [stderr] 40 |     }
[INFO] [stderr] 41 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 59.04s
[INFO] running `"docker" "inspect" "39fad74f66dd7c8633ff7404e764104e3d58ffa435fea136f3bee8593a3ca669"`
[INFO] running `"docker" "rm" "-f" "39fad74f66dd7c8633ff7404e764104e3d58ffa435fea136f3bee8593a3ca669"`
[INFO] [stdout] 39fad74f66dd7c8633ff7404e764104e3d58ffa435fea136f3bee8593a3ca669