[INFO] updating cached repository SilentByte/wavedown [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SilentByte/wavedown [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SilentByte/wavedown" "work/ex/clippy-test-run/sources/stable/gh/SilentByte/wavedown"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SilentByte/wavedown'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SilentByte/wavedown" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SilentByte/wavedown"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SilentByte/wavedown'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fbf103ed491cb6bbe7bb020f84edb0a7b57f4cee [INFO] sha for GitHub repo SilentByte/wavedown: fbf103ed491cb6bbe7bb020f84edb0a7b57f4cee [INFO] validating manifest of SilentByte/wavedown on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SilentByte/wavedown on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SilentByte/wavedown [INFO] finished frobbing SilentByte/wavedown [INFO] frobbed toml for SilentByte/wavedown written to work/ex/clippy-test-run/sources/stable/gh/SilentByte/wavedown/Cargo.toml [INFO] started frobbing SilentByte/wavedown [INFO] finished frobbing SilentByte/wavedown [INFO] frobbed toml for SilentByte/wavedown written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SilentByte/wavedown/Cargo.toml [INFO] crate SilentByte/wavedown has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SilentByte/wavedown against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SilentByte/wavedown:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08fb3b9248b12e742e5394792fd762f6712488bd9042ead8ffbd1a1a2fc25003 [INFO] running `"docker" "start" "-a" "08fb3b9248b12e742e5394792fd762f6712488bd9042ead8ffbd1a1a2fc25003"` [INFO] [stderr] Checking wavedown v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the `input @ _` pattern can be written as just `input` [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | input @ _ => Box::new(File::open(input) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `output @ _` pattern can be written as just `output` [INFO] [stderr] --> src/main.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | output @ _ => Box::new(File::create(output) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | total_peak.min += local_peak.min as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(local_peak.min)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:157:31 [INFO] [stderr] | [INFO] [stderr] 157 | total_peak.max += local_peak.max as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(local_peak.max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut i16`) [INFO] [stderr] --> src/main.rs:199:32 [INFO] [stderr] | [INFO] [stderr] 199 | Ok(Vec::from_raw_parts(ptr as *mut i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | fn format_peak(peak: &MinMax, args: &AppArgs) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `MinMax` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | peak.min as f32 / 0xFFFF as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(peak.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:217:38 [INFO] [stderr] | [INFO] [stderr] 217 | peak.max as f32 / 0xFFFF as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(peak.max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wavedown`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the `input @ _` pattern can be written as just `input` [INFO] [stderr] --> src/main.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | input @ _ => Box::new(File::open(input) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `output @ _` pattern can be written as just `output` [INFO] [stderr] --> src/main.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | output @ _ => Box::new(File::create(output) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:156:31 [INFO] [stderr] | [INFO] [stderr] 156 | total_peak.min += local_peak.min as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(local_peak.min)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:157:31 [INFO] [stderr] | [INFO] [stderr] 157 | total_peak.max += local_peak.max as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(local_peak.max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut i16`) [INFO] [stderr] --> src/main.rs:199:32 [INFO] [stderr] | [INFO] [stderr] 199 | Ok(Vec::from_raw_parts(ptr as *mut i16, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | fn format_peak(peak: &MinMax, args: &AppArgs) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `MinMax` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | peak.min as f32 / 0xFFFF as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(peak.min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:217:38 [INFO] [stderr] | [INFO] [stderr] 217 | peak.max as f32 / 0xFFFF as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(peak.max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wavedown`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "08fb3b9248b12e742e5394792fd762f6712488bd9042ead8ffbd1a1a2fc25003"` [INFO] running `"docker" "rm" "-f" "08fb3b9248b12e742e5394792fd762f6712488bd9042ead8ffbd1a1a2fc25003"` [INFO] [stdout] 08fb3b9248b12e742e5394792fd762f6712488bd9042ead8ffbd1a1a2fc25003