[INFO] updating cached repository Shuternay/factorization_machine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Shuternay/factorization_machine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Shuternay/factorization_machine" "work/ex/clippy-test-run/sources/stable/gh/Shuternay/factorization_machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Shuternay/factorization_machine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Shuternay/factorization_machine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shuternay/factorization_machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shuternay/factorization_machine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f935feb6948591d30df2136b16576348f5c69c9b [INFO] sha for GitHub repo Shuternay/factorization_machine: f935feb6948591d30df2136b16576348f5c69c9b [INFO] validating manifest of Shuternay/factorization_machine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Shuternay/factorization_machine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Shuternay/factorization_machine [INFO] finished frobbing Shuternay/factorization_machine [INFO] frobbed toml for Shuternay/factorization_machine written to work/ex/clippy-test-run/sources/stable/gh/Shuternay/factorization_machine/Cargo.toml [INFO] started frobbing Shuternay/factorization_machine [INFO] finished frobbing Shuternay/factorization_machine [INFO] frobbed toml for Shuternay/factorization_machine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shuternay/factorization_machine/Cargo.toml [INFO] crate Shuternay/factorization_machine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Shuternay/factorization_machine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Shuternay/factorization_machine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7cc961dd054eb268456105b10db8463854def7c3ef0e00522440c3185856923 [INFO] running `"docker" "start" "-a" "a7cc961dd054eb268456105b10db8463854def7c3ef0e00522440c3185856923"` [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking factorization_machine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataset::Record` [INFO] [stderr] --> src/dataset.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Record { [INFO] [stderr] 35 | | Record { [INFO] [stderr] 36 | | target: 0., [INFO] [stderr] 37 | | features: Vec::new() [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataset::Dataset` [INFO] [stderr] --> src/dataset.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Dataset { [INFO] [stderr] 49 | | Dataset { [INFO] [stderr] 50 | | records: Vec::new() [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dataset.rs:73:56 [INFO] [stderr] | [INFO] [stderr] 73 | let mut feature_tokens = feature.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | / if let &Some(ref test_dataset) = test_dataset_option { [INFO] [stderr] 152 | | println!("Epoch: {}, loss on train: {}, loss on test: {}", epoch, [INFO] [stderr] 153 | | self.eval_loss(&dataset, loss), self.eval_loss(&test_dataset, loss)); [INFO] [stderr] 154 | | } else { [INFO] [stderr] 155 | | println!("Epoch: {}, loss on train: {}", epoch, self.eval_loss(&dataset, loss)); [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 151 | if let Some(ref test_dataset) = *test_dataset_option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `feature` is used to index `transposed_dataset` [INFO] [stderr] --> src/model.rs:206:28 [INFO] [stderr] | [INFO] [stderr] 206 | for feature in 0..(1 << self.hash_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 206 | for (feature, ) in transposed_dataset.iter().enumerate().take((1 << self.hash_bits)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | / if let &Some(ref test_dataset) = test_dataset_option { [INFO] [stderr] 281 | | println!("Epoch: {}, loss on train: {}, loss on test: {}", epoch, [INFO] [stderr] 282 | | self.eval_loss(&dataset, loss), self.eval_loss(&test_dataset, loss)); [INFO] [stderr] 283 | | } else { [INFO] [stderr] 284 | | println!("Epoch: {}, loss on train: {}", epoch, self.eval_loss(&dataset, loss)); [INFO] [stderr] 285 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 280 | if let Some(ref test_dataset) = *test_dataset_option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataset::Record` [INFO] [stderr] --> src/dataset.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Record { [INFO] [stderr] 35 | | Record { [INFO] [stderr] 36 | | target: 0., [INFO] [stderr] 37 | | features: Vec::new() [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dataset::Dataset` [INFO] [stderr] --> src/dataset.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Dataset { [INFO] [stderr] 49 | | Dataset { [INFO] [stderr] 50 | | records: Vec::new() [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dataset.rs:73:56 [INFO] [stderr] | [INFO] [stderr] 73 | let mut feature_tokens = feature.split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | / if let &Some(ref test_dataset) = test_dataset_option { [INFO] [stderr] 152 | | println!("Epoch: {}, loss on train: {}, loss on test: {}", epoch, [INFO] [stderr] 153 | | self.eval_loss(&dataset, loss), self.eval_loss(&test_dataset, loss)); [INFO] [stderr] 154 | | } else { [INFO] [stderr] 155 | | println!("Epoch: {}, loss on train: {}", epoch, self.eval_loss(&dataset, loss)); [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 151 | if let Some(ref test_dataset) = *test_dataset_option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `feature` is used to index `transposed_dataset` [INFO] [stderr] --> src/model.rs:206:28 [INFO] [stderr] | [INFO] [stderr] 206 | for feature in 0..(1 << self.hash_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 206 | for (feature, ) in transposed_dataset.iter().enumerate().take((1 << self.hash_bits)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/model.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | / if let &Some(ref test_dataset) = test_dataset_option { [INFO] [stderr] 281 | | println!("Epoch: {}, loss on train: {}, loss on test: {}", epoch, [INFO] [stderr] 282 | | self.eval_loss(&dataset, loss), self.eval_loss(&test_dataset, loss)); [INFO] [stderr] 283 | | } else { [INFO] [stderr] 284 | | println!("Epoch: {}, loss on train: {}", epoch, self.eval_loss(&dataset, loss)); [INFO] [stderr] 285 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 280 | if let Some(ref test_dataset) = *test_dataset_option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `eval_loss` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:109:64 [INFO] [stderr] | [INFO] [stderr] 109 | println!("Loss on test: {}", model.eval_loss(&dataset, &mut *loss)); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `fit_als` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:135:52 [INFO] [stderr] | [INFO] [stderr] 135 | model.fit_als(&dataset, &test_dataset, &mut *loss, epochs, l2_regularization); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `fit` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:138:48 [INFO] [stderr] | [INFO] [stderr] 138 | model.fit(&dataset, &test_dataset, &mut *loss, optimizer, epochs, l2_regularization); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `fit` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:141:48 [INFO] [stderr] | [INFO] [stderr] 141 | model.fit(&dataset, &test_dataset, &mut *loss, optimizer, epochs, l2_regularization); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `eval_loss` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:109:64 [INFO] [stderr] | [INFO] [stderr] 109 | println!("Loss on test: {}", model.eval_loss(&dataset, &mut *loss)); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `fit_als` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:135:52 [INFO] [stderr] | [INFO] [stderr] 135 | model.fit_als(&dataset, &test_dataset, &mut *loss, epochs, l2_regularization); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `fit` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:138:48 [INFO] [stderr] | [INFO] [stderr] 138 | model.fit(&dataset, &test_dataset, &mut *loss, optimizer, epochs, l2_regularization); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `fit` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:141:48 [INFO] [stderr] | [INFO] [stderr] 141 | model.fit(&dataset, &test_dataset, &mut *loss, optimizer, epochs, l2_regularization); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.45s [INFO] running `"docker" "inspect" "a7cc961dd054eb268456105b10db8463854def7c3ef0e00522440c3185856923"` [INFO] running `"docker" "rm" "-f" "a7cc961dd054eb268456105b10db8463854def7c3ef0e00522440c3185856923"` [INFO] [stdout] a7cc961dd054eb268456105b10db8463854def7c3ef0e00522440c3185856923