[INFO] updating cached repository ShotaroTsuji/add-noise [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ShotaroTsuji/add-noise [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ShotaroTsuji/add-noise" "work/ex/clippy-test-run/sources/stable/gh/ShotaroTsuji/add-noise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ShotaroTsuji/add-noise'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ShotaroTsuji/add-noise" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShotaroTsuji/add-noise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShotaroTsuji/add-noise'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4062c4fac50866d0b42783c653612bf09fbdbabc [INFO] sha for GitHub repo ShotaroTsuji/add-noise: 4062c4fac50866d0b42783c653612bf09fbdbabc [INFO] validating manifest of ShotaroTsuji/add-noise on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ShotaroTsuji/add-noise on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ShotaroTsuji/add-noise [INFO] finished frobbing ShotaroTsuji/add-noise [INFO] frobbed toml for ShotaroTsuji/add-noise written to work/ex/clippy-test-run/sources/stable/gh/ShotaroTsuji/add-noise/Cargo.toml [INFO] started frobbing ShotaroTsuji/add-noise [INFO] finished frobbing ShotaroTsuji/add-noise [INFO] frobbed toml for ShotaroTsuji/add-noise written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShotaroTsuji/add-noise/Cargo.toml [INFO] crate ShotaroTsuji/add-noise has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ShotaroTsuji/add-noise against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ShotaroTsuji/add-noise:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aca3260bbe909c3a38c06674a6712331badcb10d7d514a5401bf835e8948f598 [INFO] running `"docker" "start" "-a" "aca3260bbe909c3a38c06674a6712331badcb10d7d514a5401bf835e8948f598"` [INFO] [stderr] Checking add-noise v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | dists: dists, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `dists` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | dists: dists, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `dists` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | let mut x: Vec = x.as_ref().iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: this call to `as_mut` does nothing [INFO] [stderr] --> src/lib.rs:127:16 [INFO] [stderr] | [INFO] [stderr] 127 | for row in data.as_mut().iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | let mut x: Vec = x.as_ref().iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: this call to `as_mut` does nothing [INFO] [stderr] --> src/lib.rs:127:16 [INFO] [stderr] | [INFO] [stderr] 127 | for row in data.as_mut().iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.13s [INFO] running `"docker" "inspect" "aca3260bbe909c3a38c06674a6712331badcb10d7d514a5401bf835e8948f598"` [INFO] running `"docker" "rm" "-f" "aca3260bbe909c3a38c06674a6712331badcb10d7d514a5401bf835e8948f598"` [INFO] [stdout] aca3260bbe909c3a38c06674a6712331badcb10d7d514a5401bf835e8948f598