[INFO] updating cached repository ShaunKarran/cab403-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ShaunKarran/cab403-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ShaunKarran/cab403-rs" "work/ex/clippy-test-run/sources/stable/gh/ShaunKarran/cab403-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ShaunKarran/cab403-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ShaunKarran/cab403-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShaunKarran/cab403-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShaunKarran/cab403-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6b2d984ec05b6180360b84870ed5bfebad85607f [INFO] sha for GitHub repo ShaunKarran/cab403-rs: 6b2d984ec05b6180360b84870ed5bfebad85607f [INFO] validating manifest of ShaunKarran/cab403-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ShaunKarran/cab403-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ShaunKarran/cab403-rs [INFO] finished frobbing ShaunKarran/cab403-rs [INFO] frobbed toml for ShaunKarran/cab403-rs written to work/ex/clippy-test-run/sources/stable/gh/ShaunKarran/cab403-rs/Cargo.toml [INFO] started frobbing ShaunKarran/cab403-rs [INFO] finished frobbing ShaunKarran/cab403-rs [INFO] frobbed toml for ShaunKarran/cab403-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ShaunKarran/cab403-rs/Cargo.toml [INFO] crate ShaunKarran/cab403-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ShaunKarran/cab403-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ShaunKarran/cab403-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a17fb4e3352e0af1922632a2e708c149572afe9cb5c289427f321a32c65bcf20 [INFO] running `"docker" "start" "-a" "a17fb4e3352e0af1922632a2e708c149572afe9cb5c289427f321a32c65bcf20"` [INFO] [stderr] Checking bincode v0.9.2 [INFO] [stderr] Checking threadpool v1.7.0 [INFO] [stderr] Checking simplelog v0.4.2 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking cab403-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hangman.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | word: word, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hangman.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | word_character_set: word_character_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `word_character_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hangman.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | number_allowed_guesses: number_allowed_guesses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_allowed_guesses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hangman.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | word: word, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `word` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hangman.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | word_character_set: word_character_set, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `word_character_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hangman.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | number_allowed_guesses: number_allowed_guesses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_allowed_guesses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::Game` [INFO] [stderr] --> src/hangman.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | use super::Game; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `word_set` [INFO] [stderr] --> src/hangman.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | fn select_word(word_set: HashSet) -> String { [INFO] [stderr] | ^^^^^^^^ help: consider using `_word_set` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `word_set` [INFO] [stderr] --> src/hangman.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | fn select_word(word_set: HashSet) -> String { [INFO] [stderr] | ^^^^^^^^ help: consider using `_word_set` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `word` [INFO] [stderr] --> src/hangman.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | word: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `word_character_set` [INFO] [stderr] --> src/hangman.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | word_character_set: HashSet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `number_allowed_guesses` [INFO] [stderr] --> src/hangman.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | number_allowed_guesses: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/communication.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | stream.write(&encoded_data).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hangman.rs:32:47 [INFO] [stderr] | [INFO] [stderr] 32 | fn calculate_number_allowed_guesses(word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cab403-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: field is never used: `word` [INFO] [stderr] --> src/hangman.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | word: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `word_character_set` [INFO] [stderr] --> src/hangman.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | word_character_set: HashSet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `number_allowed_guesses` [INFO] [stderr] --> src/hangman.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | number_allowed_guesses: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/communication.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | stream.write(&encoded_data).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hangman.rs:32:47 [INFO] [stderr] | [INFO] [stderr] 32 | fn calculate_number_allowed_guesses(word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cab403-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a17fb4e3352e0af1922632a2e708c149572afe9cb5c289427f321a32c65bcf20"` [INFO] running `"docker" "rm" "-f" "a17fb4e3352e0af1922632a2e708c149572afe9cb5c289427f321a32c65bcf20"` [INFO] [stdout] a17fb4e3352e0af1922632a2e708c149572afe9cb5c289427f321a32c65bcf20