[INFO] updating cached repository Shadlock0133/snek [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Shadlock0133/snek [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Shadlock0133/snek" "work/ex/clippy-test-run/sources/stable/gh/Shadlock0133/snek"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Shadlock0133/snek'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Shadlock0133/snek" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shadlock0133/snek"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shadlock0133/snek'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3c3fc716dfb07d988e7fc387baaf8e99c114d143 [INFO] sha for GitHub repo Shadlock0133/snek: 3c3fc716dfb07d988e7fc387baaf8e99c114d143 [INFO] validating manifest of Shadlock0133/snek on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Shadlock0133/snek on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Shadlock0133/snek [INFO] finished frobbing Shadlock0133/snek [INFO] frobbed toml for Shadlock0133/snek written to work/ex/clippy-test-run/sources/stable/gh/Shadlock0133/snek/Cargo.toml [INFO] started frobbing Shadlock0133/snek [INFO] finished frobbing Shadlock0133/snek [INFO] frobbed toml for Shadlock0133/snek written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shadlock0133/snek/Cargo.toml [INFO] crate Shadlock0133/snek has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Shadlock0133/snek against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Shadlock0133/snek:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec3af2cac0090ed98b3dcbc6086f018affdbd3ce565e5e7ed64ff13f7e5b52b2 [INFO] running `"docker" "start" "-a" "ec3af2cac0090ed98b3dcbc6086f018affdbd3ce565e5e7ed64ff13f7e5b52b2"` [INFO] [stderr] Checking serde v1.0.16 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking nodrop v0.1.11 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling glutin v0.10.0 [INFO] [stderr] Checking x11-dl v2.16.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.16 [INFO] [stderr] Checking arrayvec v0.4.4 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking gfx_device_gl v0.14.4 [INFO] [stderr] Checking piston-gfx_texture v0.29.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.46.0 [INFO] [stderr] Checking piston_window v0.73.0 [INFO] [stderr] Checking snek v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `HEIGHT`, `WIDTH` [INFO] [stderr] --> src/apple.rs:4:6 [INFO] [stderr] | [INFO] [stderr] 4 | use {WIDTH, HEIGHT, SCALE}; [INFO] [stderr] | ^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/apple.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | let (x, y) = (self.pos.0 as f64, self.pos.1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pos.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/apple.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | let (x, y) = (self.pos.0 as f64, self.pos.1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/apple.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | let scale = SCALE as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/snek.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | let pos = self.body.back().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.body.back().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/snek.rs:88:30 [INFO] [stderr] | [INFO] [stderr] 88 | } else if speed > 20 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 89 | | 1 [INFO] [stderr] 90 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/snek.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | let speed = if speed == 0 { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 87 | | 1 [INFO] [stderr] 88 | | } else if speed > 20 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snek.rs:140:27 [INFO] [stderr] | [INFO] [stderr] 140 | let (x, y) = (x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snek.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | let (x, y) = (x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snek.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | let scale = SCALE as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let w = WINDOW_WIDTH as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | let h = WINDOW_HEIGHT as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let scale = SCALE as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `snek`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused imports: `HEIGHT`, `WIDTH` [INFO] [stderr] --> src/apple.rs:4:6 [INFO] [stderr] | [INFO] [stderr] 4 | use {WIDTH, HEIGHT, SCALE}; [INFO] [stderr] | ^^^^^ ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/apple.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | let (x, y) = (self.pos.0 as f64, self.pos.1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pos.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/apple.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | let (x, y) = (self.pos.0 as f64, self.pos.1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.pos.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/apple.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | let scale = SCALE as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/snek.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | let pos = self.body.back().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.body.back().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/snek.rs:88:30 [INFO] [stderr] | [INFO] [stderr] 88 | } else if speed > 20 { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 89 | | 1 [INFO] [stderr] 90 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/snek.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | let speed = if speed == 0 { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 87 | | 1 [INFO] [stderr] 88 | | } else if speed > 20 { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snek.rs:140:27 [INFO] [stderr] | [INFO] [stderr] 140 | let (x, y) = (x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snek.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | let (x, y) = (x as f64, y as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snek.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | let scale = SCALE as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | let w = WINDOW_WIDTH as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | let h = WINDOW_HEIGHT as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let scale = SCALE as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `snek`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ec3af2cac0090ed98b3dcbc6086f018affdbd3ce565e5e7ed64ff13f7e5b52b2"` [INFO] running `"docker" "rm" "-f" "ec3af2cac0090ed98b3dcbc6086f018affdbd3ce565e5e7ed64ff13f7e5b52b2"` [INFO] [stdout] ec3af2cac0090ed98b3dcbc6086f018affdbd3ce565e5e7ed64ff13f7e5b52b2