[INFO] updating cached repository Shadlock0133/dnd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Shadlock0133/dnd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Shadlock0133/dnd" "work/ex/clippy-test-run/sources/stable/gh/Shadlock0133/dnd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Shadlock0133/dnd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Shadlock0133/dnd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shadlock0133/dnd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shadlock0133/dnd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 19142318255b32e4394416db1abd81fd01c74de9 [INFO] sha for GitHub repo Shadlock0133/dnd: 19142318255b32e4394416db1abd81fd01c74de9 [INFO] validating manifest of Shadlock0133/dnd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Shadlock0133/dnd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Shadlock0133/dnd [INFO] finished frobbing Shadlock0133/dnd [INFO] frobbed toml for Shadlock0133/dnd written to work/ex/clippy-test-run/sources/stable/gh/Shadlock0133/dnd/Cargo.toml [INFO] started frobbing Shadlock0133/dnd [INFO] finished frobbing Shadlock0133/dnd [INFO] frobbed toml for Shadlock0133/dnd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Shadlock0133/dnd/Cargo.toml [INFO] crate Shadlock0133/dnd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Shadlock0133/dnd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Shadlock0133/dnd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1965e7529ec6b998c9aaf41e175d593cb12e1123f84a1371f27ae923f1a2e92b [INFO] running `"docker" "start" "-a" "1965e7529ec6b998c9aaf41e175d593cb12e1123f84a1371f27ae923f1a2e92b"` [INFO] [stderr] Checking either v1.3.0 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking petgraph v0.4.10 [INFO] [stderr] Compiling conrod_derive v0.1.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking x11-dl v2.16.0 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking libloading v0.3.4 [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking daggy v0.5.0 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking conrod v0.56.0 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking glutin v0.10.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.0 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking gfx_device_gl v0.14.4 [INFO] [stderr] Checking piston-gfx_texture v0.29.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.46.0 [INFO] [stderr] Checking piston_window v0.73.0 [INFO] [stderr] Checking dnd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/support/mod.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | rust_logo: rust_logo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rust_logo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/postac.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | pub bronie: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/postac.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / pub fn new>( [INFO] [stderr] 152 | | imie: S, [INFO] [stderr] 153 | | kasa: (u32, u32, u32, u32), [INFO] [stderr] 154 | | klasa: Klasa, [INFO] [stderr] ... | [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | let mut ui = UiBuilder::new([WIDTH as _, HEIGHT as _]) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | let mut ui = UiBuilder::new([WIDTH as _, HEIGHT as _]) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | let (w, h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:53 [INFO] [stderr] | [INFO] [stderr] 109 | let (w, h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/support/mod.rs:136:19 [INFO] [stderr] | [INFO] [stderr] 136 | const TITLE: &'static str = "All Widgets"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/support/mod.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | const INTRODUCTION: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/postac.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | pub bronie: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: for loop over `widget::XYPad::new(app.ball_xy[0], min_x, max_x, [INFO] [stderr] app.ball_xy[1], min_y, max_y) [INFO] [stderr] .label("BALL XY") [INFO] [stderr] .wh_of(ids.button) [INFO] [stderr] .align_middle_y_of(ids.button) [INFO] [stderr] .align_middle_x_of(ids.canvas) [INFO] [stderr] .parent(ids.canvas) [INFO] [stderr] .set(ids.xy_pad, ui)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> examples/support/mod.rs:280:19 [INFO] [stderr] | [INFO] [stderr] 280 | for (x, y) in widget::XYPad::new(app.ball_xy[0], min_x, max_x, [INFO] [stderr] | ___________________^ [INFO] [stderr] 281 | | app.ball_xy[1], min_y, max_y) [INFO] [stderr] 282 | | .label("BALL XY") [INFO] [stderr] 283 | | .wh_of(ids.button) [INFO] [stderr] ... | [INFO] [stderr] 286 | | .parent(ids.canvas) [INFO] [stderr] 287 | | .set(ids.xy_pad, ui) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for (x, y) in widget::XYPad::new(app.ball_xy[0], min_x, max_x, [INFO] [stderr] app.ball_xy[1], min_y, max_y) [INFO] [stderr] .label("BALL XY") [INFO] [stderr] .wh_of(ids.button) [INFO] [stderr] .align_middle_y_of(ids.button) [INFO] [stderr] .align_middle_x_of(ids.canvas) [INFO] [stderr] .parent(ids.canvas) [INFO] [stderr] .set(ids.xy_pad, ui)` with `if let Some((x, y)) = widget::XYPad::new(app.ball_xy[0], min_x, max_x, [INFO] [stderr] app.ball_xy[1], min_y, max_y) [INFO] [stderr] .label("BALL XY") [INFO] [stderr] .wh_of(ids.button) [INFO] [stderr] .align_middle_y_of(ids.button) [INFO] [stderr] .align_middle_x_of(ids.canvas) [INFO] [stderr] .parent(ids.canvas) [INFO] [stderr] .set(ids.xy_pad, ui)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: for loop over `widget::NumberDialer::new(app.sine_frequency, min, max, decimal_precision) [INFO] [stderr] .down(60.0) [INFO] [stderr] .align_middle_x_of(ids.canvas) [INFO] [stderr] .w_h(160.0, 40.0) [INFO] [stderr] .label("F R E Q") [INFO] [stderr] .set(ids.number_dialer, ui)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> examples/support/mod.rs:327:21 [INFO] [stderr] | [INFO] [stderr] 327 | for new_freq in widget::NumberDialer::new(app.sine_frequency, min, max, decimal_precision) [INFO] [stderr] | _____________________^ [INFO] [stderr] 328 | | .down(60.0) [INFO] [stderr] 329 | | .align_middle_x_of(ids.canvas) [INFO] [stderr] 330 | | .w_h(160.0, 40.0) [INFO] [stderr] 331 | | .label("F R E Q") [INFO] [stderr] 332 | | .set(ids.number_dialer, ui) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for new_freq in widget::NumberDialer::new(app.sine_frequency, min, max, decimal_precision) [INFO] [stderr] .down(60.0) [INFO] [stderr] .align_middle_x_of(ids.canvas) [INFO] [stderr] .w_h(160.0, 40.0) [INFO] [stderr] .label("F R E Q") [INFO] [stderr] .set(ids.number_dialer, ui)` with `if let Some(new_freq) = widget::NumberDialer::new(app.sine_frequency, min, max, decimal_precision) [INFO] [stderr] .down(60.0) [INFO] [stderr] .align_middle_x_of(ids.canvas) [INFO] [stderr] .w_h(160.0, 40.0) [INFO] [stderr] .label("F R E Q") [INFO] [stderr] .set(ids.number_dialer, ui)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/postac.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / pub fn new>( [INFO] [stderr] 152 | | imie: S, [INFO] [stderr] 153 | | kasa: (u32, u32, u32, u32), [INFO] [stderr] 154 | | klasa: Klasa, [INFO] [stderr] ... | [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/all_piston_window.rs:36:46 [INFO] [stderr] | [INFO] [stderr] 36 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/all_piston_window.rs:36:60 [INFO] [stderr] | [INFO] [stderr] 36 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/all_piston_window.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | let (win_w, win_h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/all_piston_window.rs:86:65 [INFO] [stderr] | [INFO] [stderr] 86 | let (win_w, win_h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | let mut ui = UiBuilder::new([WIDTH as _, HEIGHT as _]) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | let mut ui = UiBuilder::new([WIDTH as _, HEIGHT as _]) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:23 [INFO] [stderr] | [INFO] [stderr] 109 | let (w, h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:53 [INFO] [stderr] | [INFO] [stderr] 109 | let (w, h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `dnd`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "1965e7529ec6b998c9aaf41e175d593cb12e1123f84a1371f27ae923f1a2e92b"` [INFO] running `"docker" "rm" "-f" "1965e7529ec6b998c9aaf41e175d593cb12e1123f84a1371f27ae923f1a2e92b"` [INFO] [stdout] 1965e7529ec6b998c9aaf41e175d593cb12e1123f84a1371f27ae923f1a2e92b