[INFO] updating cached repository Sgeo/rwg_to_rwx [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Sgeo/rwg_to_rwx [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Sgeo/rwg_to_rwx" "work/ex/clippy-test-run/sources/stable/gh/Sgeo/rwg_to_rwx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Sgeo/rwg_to_rwx'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Sgeo/rwg_to_rwx" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/rwg_to_rwx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/rwg_to_rwx'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae06e34fe90fe388b12418cda9af5ce27d6432d4 [INFO] sha for GitHub repo Sgeo/rwg_to_rwx: ae06e34fe90fe388b12418cda9af5ce27d6432d4 [INFO] validating manifest of Sgeo/rwg_to_rwx on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Sgeo/rwg_to_rwx on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Sgeo/rwg_to_rwx [INFO] finished frobbing Sgeo/rwg_to_rwx [INFO] frobbed toml for Sgeo/rwg_to_rwx written to work/ex/clippy-test-run/sources/stable/gh/Sgeo/rwg_to_rwx/Cargo.toml [INFO] started frobbing Sgeo/rwg_to_rwx [INFO] finished frobbing Sgeo/rwg_to_rwx [INFO] frobbed toml for Sgeo/rwg_to_rwx written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/rwg_to_rwx/Cargo.toml [INFO] crate Sgeo/rwg_to_rwx has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Sgeo/rwg_to_rwx against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Sgeo/rwg_to_rwx:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e4b30bf971de76801e34e6253c91cdcb0e41bfdd901e48eb9ceddd5e1ecde88 [INFO] running `"docker" "start" "-a" "9e4b30bf971de76801e34e6253c91cdcb0e41bfdd901e48eb9ceddd5e1ecde88"` [INFO] [stderr] Checking rwg21_to_rwx v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | if chunkType == 0x5A5A5A5B { // ZZZ[, a header used by Worlds to list textures. [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5A5A_5A5B` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | if chunkType == 0x434C554D { // CLUM [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x434C_554D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:121:53 [INFO] [stderr] | [INFO] [stderr] 121 | let success = RwReadStreamChunk(stream, 0x434C554D, &mut clump, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x434C_554D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> src/main.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | if chunkType == 0x5A5A5A5B { // ZZZ[, a header used by Worlds to list textures. [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5A5A_5A5B` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | if chunkType == 0x434C554D { // CLUM [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x434C_554D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:121:53 [INFO] [stderr] | [INFO] [stderr] 121 | let success = RwReadStreamChunk(stream, 0x434C554D, &mut clump, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x434C_554D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: value assigned to `texture_header_data` is never read [INFO] [stderr] --> src/main.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | let mut texture_header_data: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `displayDevice` should have a snake case name such as `display_device` [INFO] [stderr] --> src/main.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let displayDevice = RwOpenDisplayDevice(cs("rwdl8d21"), ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `chunkType` should have a snake case name such as `chunk_type` [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | let mut chunkType: u32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:87 [INFO] [stderr] | [INFO] [stderr] 112 | let textures = texture_header_data.split(|&char| char == 0).filter(|&tex| tex.len() > 0).map(String::from_utf8_lossy); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable `chunkType` should have a snake case name such as `chunk_type` [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | let mut chunkType: u32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:126:31 [INFO] [stderr] | [INFO] [stderr] 126 | for vertex in 1 .. (num_vertices + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=num_vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: variable `writeResult` should have a snake case name such as `write_result` [INFO] [stderr] --> src/main.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | let writeResult = RwWriteShape(cs(&format!("{}.rwx", filename)), clump); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `texture_header_data` is never read [INFO] [stderr] --> src/main.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | let mut texture_header_data: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `displayDevice` should have a snake case name such as `display_device` [INFO] [stderr] --> src/main.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let displayDevice = RwOpenDisplayDevice(cs("rwdl8d21"), ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `chunkType` should have a snake case name such as `chunk_type` [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | let mut chunkType: u32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:112:87 [INFO] [stderr] | [INFO] [stderr] 112 | let textures = texture_header_data.split(|&char| char == 0).filter(|&tex| tex.len() > 0).map(String::from_utf8_lossy); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable `chunkType` should have a snake case name such as `chunk_type` [INFO] [stderr] --> src/main.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | let mut chunkType: u32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:126:31 [INFO] [stderr] | [INFO] [stderr] 126 | for vertex in 1 .. (num_vertices + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=num_vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: variable `writeResult` should have a snake case name such as `write_result` [INFO] [stderr] --> src/main.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | let writeResult = RwWriteShape(cs(&format!("{}.rwx", filename)), clump); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.47s [INFO] running `"docker" "inspect" "9e4b30bf971de76801e34e6253c91cdcb0e41bfdd901e48eb9ceddd5e1ecde88"` [INFO] running `"docker" "rm" "-f" "9e4b30bf971de76801e34e6253c91cdcb0e41bfdd901e48eb9ceddd5e1ecde88"` [INFO] [stdout] 9e4b30bf971de76801e34e6253c91cdcb0e41bfdd901e48eb9ceddd5e1ecde88