[INFO] updating cached repository Sgeo/propdump2cell42 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Sgeo/propdump2cell42 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Sgeo/propdump2cell42" "work/ex/clippy-test-run/sources/stable/gh/Sgeo/propdump2cell42"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Sgeo/propdump2cell42'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Sgeo/propdump2cell42" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/propdump2cell42"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/propdump2cell42'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b4724ae320e6a89adbbf264925d0b5f35b23ba2f [INFO] sha for GitHub repo Sgeo/propdump2cell42: b4724ae320e6a89adbbf264925d0b5f35b23ba2f [INFO] validating manifest of Sgeo/propdump2cell42 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Sgeo/propdump2cell42 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Sgeo/propdump2cell42 [INFO] finished frobbing Sgeo/propdump2cell42 [INFO] frobbed toml for Sgeo/propdump2cell42 written to work/ex/clippy-test-run/sources/stable/gh/Sgeo/propdump2cell42/Cargo.toml [INFO] started frobbing Sgeo/propdump2cell42 [INFO] finished frobbing Sgeo/propdump2cell42 [INFO] frobbed toml for Sgeo/propdump2cell42 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sgeo/propdump2cell42/Cargo.toml [INFO] crate Sgeo/propdump2cell42 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Sgeo/propdump2cell42 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Sgeo/propdump2cell42:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d231c3d157f579348cb99cba22b08d13e73835ae45cc149135775907e225316a [INFO] running `"docker" "start" "-a" "d231c3d157f579348cb99cba22b08d13e73835ae45cc149135775907e225316a"` [INFO] [stderr] Checking ctrlc v3.1.1 [INFO] [stderr] Checking regex v1.0.1 [INFO] [stderr] Checking propdump2cell42 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/propdump.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | v4: v4, [INFO] [stderr] | ^^^^^^ help: replace it with: `v4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/propdump.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/propdump.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | encoding: encoding [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/teleports.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | dat: dat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/propdump.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | v4: v4, [INFO] [stderr] | ^^^^^^ help: replace it with: `v4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/propdump.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/propdump.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | encoding: encoding [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/teleports.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | dat: dat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/teleports.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return Ok(integer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(integer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/teleports.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Ok(-integer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(-integer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/teleports.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/teleports.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return Ok(integer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(integer)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/teleports.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | return Ok(-integer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(-integer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/teleports.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ByteOrder` [INFO] [stderr] --> src/aw.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | use byteorder::{ByteOrder, LE, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/propdump.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{self, Read, BufRead}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Encoding` [INFO] [stderr] --> src/propdump.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | use encoding::{Encoding, DecoderTrap}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/propdump.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | if let Err(err) = maybe_citnum { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:102:34 [INFO] [stderr] | [INFO] [stderr] 102 | fn write_v_data(&self, addr: &DatAddr, data: &[u8]) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:108:33 [INFO] [stderr] | [INFO] [stderr] 108 | fn read_v_data(&self, addr: &DatAddr) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:116:36 [INFO] [stderr] | [INFO] [stderr] 116 | fn release_v_data(&self, addr: &DatAddr) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:157:44 [INFO] [stderr] | [INFO] [stderr] 157 | fn add_key(&self, key: &[u8], dataddr: &DatAddr) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:176:44 [INFO] [stderr] | [INFO] [stderr] 176 | fn delete_key(&self, key: &[u8], addr: &DatAddr) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused import: `ByteOrder` [INFO] [stderr] --> src/aw.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | use byteorder::{ByteOrder, LE, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/propdump.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{self, Read, BufRead}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Encoding` [INFO] [stderr] --> src/propdump.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | use encoding::{Encoding, DecoderTrap}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/propdump.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | if buffer.len() > 0 && buffer[0] == b'\x7F' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/propdump.rs:86:20 [INFO] [stderr] | [INFO] [stderr] 86 | if let Err(err) = maybe_citnum { [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/teleports.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | if min_x <= &location.cell_x && &location.cell_x <= max_x && min_z <= &location.cell_z && &location.cell_z <= max_z { [INFO] [stderr] | ^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `location.cell_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/teleports.rs:64:45 [INFO] [stderr] | [INFO] [stderr] 64 | if min_x <= &location.cell_x && &location.cell_x <= max_x && min_z <= &location.cell_z && &location.cell_z <= max_z { [INFO] [stderr] | ----------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `location.cell_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/teleports.rs:64:74 [INFO] [stderr] | [INFO] [stderr] 64 | if min_x <= &location.cell_x && &location.cell_x <= max_x && min_z <= &location.cell_z && &location.cell_z <= max_z { [INFO] [stderr] | ^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `location.cell_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/teleports.rs:64:103 [INFO] [stderr] | [INFO] [stderr] 64 | if min_x <= &location.cell_x && &location.cell_x <= max_x && min_z <= &location.cell_z && &location.cell_z <= max_z { [INFO] [stderr] | ----------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `location.cell_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:102:34 [INFO] [stderr] | [INFO] [stderr] 102 | fn write_v_data(&self, addr: &DatAddr, data: &[u8]) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:108:33 [INFO] [stderr] | [INFO] [stderr] 108 | fn read_v_data(&self, addr: &DatAddr) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:116:36 [INFO] [stderr] | [INFO] [stderr] 116 | fn release_v_data(&self, addr: &DatAddr) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:157:44 [INFO] [stderr] | [INFO] [stderr] 157 | fn add_key(&self, key: &[u8], dataddr: &DatAddr) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ctree.rs:176:44 [INFO] [stderr] | [INFO] [stderr] 176 | fn delete_key(&self, key: &[u8], addr: &DatAddr) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `DatAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/propdump.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | if buffer.len() > 0 && buffer[0] == b'\x7F' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/teleports.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | if min_x <= &location.cell_x && &location.cell_x <= max_x && min_z <= &location.cell_z && &location.cell_z <= max_z { [INFO] [stderr] | ^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `location.cell_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/teleports.rs:64:45 [INFO] [stderr] | [INFO] [stderr] 64 | if min_x <= &location.cell_x && &location.cell_x <= max_x && min_z <= &location.cell_z && &location.cell_z <= max_z { [INFO] [stderr] | ----------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `location.cell_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/teleports.rs:64:74 [INFO] [stderr] | [INFO] [stderr] 64 | if min_x <= &location.cell_x && &location.cell_x <= max_x && min_z <= &location.cell_z && &location.cell_z <= max_z { [INFO] [stderr] | ^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `location.cell_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/teleports.rs:64:103 [INFO] [stderr] | [INFO] [stderr] 64 | if min_x <= &location.cell_x && &location.cell_x <= max_x && min_z <= &location.cell_z && &location.cell_z <= max_z { [INFO] [stderr] | ----------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `location.cell_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.19s [INFO] running `"docker" "inspect" "d231c3d157f579348cb99cba22b08d13e73835ae45cc149135775907e225316a"` [INFO] running `"docker" "rm" "-f" "d231c3d157f579348cb99cba22b08d13e73835ae45cc149135775907e225316a"` [INFO] [stdout] d231c3d157f579348cb99cba22b08d13e73835ae45cc149135775907e225316a