[INFO] updating cached repository SergeevPavel/rtrace [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SergeevPavel/rtrace [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SergeevPavel/rtrace" "work/ex/clippy-test-run/sources/stable/gh/SergeevPavel/rtrace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SergeevPavel/rtrace'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SergeevPavel/rtrace" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SergeevPavel/rtrace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SergeevPavel/rtrace'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5d398b5647912fe1ee100cae527703e4c026b05f [INFO] sha for GitHub repo SergeevPavel/rtrace: 5d398b5647912fe1ee100cae527703e4c026b05f [INFO] validating manifest of SergeevPavel/rtrace on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SergeevPavel/rtrace on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SergeevPavel/rtrace [INFO] finished frobbing SergeevPavel/rtrace [INFO] frobbed toml for SergeevPavel/rtrace written to work/ex/clippy-test-run/sources/stable/gh/SergeevPavel/rtrace/Cargo.toml [INFO] started frobbing SergeevPavel/rtrace [INFO] finished frobbing SergeevPavel/rtrace [INFO] frobbed toml for SergeevPavel/rtrace written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SergeevPavel/rtrace/Cargo.toml [INFO] crate SergeevPavel/rtrace has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SergeevPavel/rtrace against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SergeevPavel/rtrace:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe11c33e2df7249fa327faccd56966dd3b78b469900903ac783eca52fec38a34 [INFO] running `"docker" "start" "-a" "fe11c33e2df7249fa327faccd56966dd3b78b469900903ac783eca52fec38a34"` [INFO] [stderr] Checking rayon-core v1.0.0 [INFO] [stderr] Checking rayon v0.7.0 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Checking rtrace v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | Ray {source: source, direction: direction.normalize()} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | n: n [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | Ray {source: source, direction: direction.normalize()} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/figures.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let p = ray.along(alpha); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/figures.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let n = (p - self.center).normalize(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | material: material, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/figures.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | n: n [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/figures.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let p = ray.along(alpha); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/figures.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let n = (p - self.center).normalize(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `I`, `J`, `K`, `O`, `Vector` [INFO] [stderr] --> src/main.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | use math::{Ray, Vector, I, J, K, O}; [INFO] [stderr] | ^^^^^^ ^ ^ ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/scene.rs:31:48 [INFO] [stderr] | [INFO] [stderr] 31 | let IntersectionPoint { alpha, color, material, n } = ip; [INFO] [stderr] | ^^^^^ help: try ignoring the field: `color: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `material` [INFO] [stderr] --> src/scene.rs:31:55 [INFO] [stderr] | [INFO] [stderr] 31 | let IntersectionPoint { alpha, color, material, n } = ip; [INFO] [stderr] | ^^^^^^^^ help: try ignoring the field: `material: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/scene.rs:31:65 [INFO] [stderr] | [INFO] [stderr] 31 | let IntersectionPoint { alpha, color, material, n } = ip; [INFO] [stderr] | ^ help: try ignoring the field: `n: _` [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | assert!(a * b == 12.0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider comparing them within some error: `(a * b - 12.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | assert!(a * b == 12.0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | assert!(c.length() == 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(c.length() - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | assert!(c.length() == 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | let alpha = (i as f64) / (x_res as f64) - 0.5; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | let alpha = (i as f64) / (x_res as f64) - 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(x_res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | let beta = (j as f64) / (y_res as f64) - 0.5; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | let beta = (j as f64) / (y_res as f64) - 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(y_res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:36:32 [INFO] [stderr] | [INFO] [stderr] 36 | let color = if let None = scene.trace(Ray::new(ray.along(alpha - EPS), to_light)) { [INFO] [stderr] | _________________________- ^^^^ [INFO] [stderr] 37 | | let diffuse_color = scene.spotlight.color.mix(color).bright((material.diffuse * (to_light * n)).max(0.0)); [INFO] [stderr] 38 | | let reflected = 2.0 * n * to_light * n - to_light; [INFO] [stderr] 39 | | let to_viewer = -1.0 * ray.direction; [INFO] [stderr] ... | [INFO] [stderr] 43 | | ambient_color [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_____________- help: try this: `if scene.trace(Ray::new(ray.along(alpha - EPS), to_light)).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rtrace`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused imports: `I`, `J`, `K`, `O`, `Vector` [INFO] [stderr] --> src/main.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | use math::{Ray, Vector, I, J, K, O}; [INFO] [stderr] | ^^^^^^ ^ ^ ^ ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color` [INFO] [stderr] --> src/scene.rs:31:48 [INFO] [stderr] | [INFO] [stderr] 31 | let IntersectionPoint { alpha, color, material, n } = ip; [INFO] [stderr] | ^^^^^ help: try ignoring the field: `color: _` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `material` [INFO] [stderr] --> src/scene.rs:31:55 [INFO] [stderr] | [INFO] [stderr] 31 | let IntersectionPoint { alpha, color, material, n } = ip; [INFO] [stderr] | ^^^^^^^^ help: try ignoring the field: `material: _` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/scene.rs:31:65 [INFO] [stderr] | [INFO] [stderr] 31 | let IntersectionPoint { alpha, color, material, n } = ip; [INFO] [stderr] | ^ help: try ignoring the field: `n: _` [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | let alpha = (i as f64) / (x_res as f64) - 0.5; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | let alpha = (i as f64) / (x_res as f64) - 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(x_res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | let beta = (j as f64) / (y_res as f64) - 0.5; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | let beta = (j as f64) / (y_res as f64) - 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(y_res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:36:32 [INFO] [stderr] | [INFO] [stderr] 36 | let color = if let None = scene.trace(Ray::new(ray.along(alpha - EPS), to_light)) { [INFO] [stderr] | _________________________- ^^^^ [INFO] [stderr] 37 | | let diffuse_color = scene.spotlight.color.mix(color).bright((material.diffuse * (to_light * n)).max(0.0)); [INFO] [stderr] 38 | | let reflected = 2.0 * n * to_light * n - to_light; [INFO] [stderr] 39 | | let to_viewer = -1.0 * ray.direction; [INFO] [stderr] ... | [INFO] [stderr] 43 | | ambient_color [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_____________- help: try this: `if scene.trace(Ray::new(ray.along(alpha - EPS), to_light)).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "fe11c33e2df7249fa327faccd56966dd3b78b469900903ac783eca52fec38a34"` [INFO] running `"docker" "rm" "-f" "fe11c33e2df7249fa327faccd56966dd3b78b469900903ac783eca52fec38a34"` [INFO] [stdout] fe11c33e2df7249fa327faccd56966dd3b78b469900903ac783eca52fec38a34