[INFO] updating cached repository Sekva/PAA [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Sekva/PAA [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Sekva/PAA" "work/ex/clippy-test-run/sources/stable/gh/Sekva/PAA"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Sekva/PAA'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Sekva/PAA" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sekva/PAA"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sekva/PAA'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e8a12719c3b32b7123af7e61ee78adfc07ebf48c [INFO] sha for GitHub repo Sekva/PAA: e8a12719c3b32b7123af7e61ee78adfc07ebf48c [INFO] validating manifest of Sekva/PAA on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Sekva/PAA on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Sekva/PAA [INFO] finished frobbing Sekva/PAA [INFO] frobbed toml for Sekva/PAA written to work/ex/clippy-test-run/sources/stable/gh/Sekva/PAA/Cargo.toml [INFO] started frobbing Sekva/PAA [INFO] finished frobbing Sekva/PAA [INFO] frobbed toml for Sekva/PAA written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sekva/PAA/Cargo.toml [INFO] crate Sekva/PAA has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Sekva/PAA against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Sekva/PAA:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ccb0cd9e1e102fcb3cb209d0bb6514d280b61c2702572a11a011ad99cd7bb6f2 [INFO] running `"docker" "start" "-a" "ccb0cd9e1e102fcb3cb209d0bb6514d280b61c2702572a11a011ad99cd7bb6f2"` [INFO] [stderr] Checking programacao_dinamica v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:16:88 [INFO] [stderr] | [INFO] [stderr] 16 | fn lookup_chain(p: &mut [i32], m: &mut [[i32; N]; N], s: &mut [[i32; N]; N], i: usize, j: usize) -> i32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let q = lookup_chain(p, m, s, i, k) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | let j = i + l - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let q = m[i][k] + m [k+1][j] + (p[i-1]*p[k]*p[j]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:16:88 [INFO] [stderr] | [INFO] [stderr] 16 | fn lookup_chain(p: &mut [i32], m: &mut [[i32; N]; N], s: &mut [[i32; N]; N], i: usize, j: usize) -> i32 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let q = lookup_chain(p, m, s, i, k) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | let j = i + l - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let q = m[i][k] + m [k+1][j] + (p[i-1]*p[k]*p[j]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return lookup_chain(p, m, s, 1, n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lookup_chain(p, m, s, 1, n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return m[i][j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `m[i][j]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `m` [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for i in 1..(n+1) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 7 | for (i, ) in m.iter_mut().enumerate().skip(1).take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for i in 1..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | for j in i..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `i..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s`. [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 1..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for in s.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `m` [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | for i in 1..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 5 | for (i, ) in m.iter_mut().enumerate().take(n).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | for i in 1..(n - l + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=n - l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | for k in i..(j - 1 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `i..=j - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s`. [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | for i in 1..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for in s.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return lookup_chain(p, m, s, 1, n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lookup_chain(p, m, s, 1, n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return m[i][j]; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `m[i][j]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `m` [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for i in 1..(n+1) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 7 | for (i, ) in m.iter_mut().enumerate().skip(1).take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for i in 1..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | for j in i..(n+1) { [INFO] [stderr] | ^^^^^^^^ help: use: `i..=n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s`. [INFO] [stderr] --> src/matrix_chain_top_down_mem/main.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | for i in 1..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for in s.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `m` [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | for i in 1..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 5 | for (i, ) in m.iter_mut().enumerate().take(n).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | for i in 1..(n - l + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=n - l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | for k in i..(j - 1 + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `i..=j - 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `s`. [INFO] [stderr] --> src/matrix_chain_bottom_up/main.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | for i in 1..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for in s.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "ccb0cd9e1e102fcb3cb209d0bb6514d280b61c2702572a11a011ad99cd7bb6f2"` [INFO] running `"docker" "rm" "-f" "ccb0cd9e1e102fcb3cb209d0bb6514d280b61c2702572a11a011ad99cd7bb6f2"` [INFO] [stdout] ccb0cd9e1e102fcb3cb209d0bb6514d280b61c2702572a11a011ad99cd7bb6f2