[INFO] updating cached repository Schlechtwetterfront/snippeteer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Schlechtwetterfront/snippeteer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Schlechtwetterfront/snippeteer" "work/ex/clippy-test-run/sources/stable/gh/Schlechtwetterfront/snippeteer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Schlechtwetterfront/snippeteer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Schlechtwetterfront/snippeteer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Schlechtwetterfront/snippeteer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Schlechtwetterfront/snippeteer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 53bcf7811a7577c4c040d7bf1457fbdd9c675a79 [INFO] sha for GitHub repo Schlechtwetterfront/snippeteer: 53bcf7811a7577c4c040d7bf1457fbdd9c675a79 [INFO] validating manifest of Schlechtwetterfront/snippeteer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Schlechtwetterfront/snippeteer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Schlechtwetterfront/snippeteer [INFO] finished frobbing Schlechtwetterfront/snippeteer [INFO] frobbed toml for Schlechtwetterfront/snippeteer written to work/ex/clippy-test-run/sources/stable/gh/Schlechtwetterfront/snippeteer/Cargo.toml [INFO] started frobbing Schlechtwetterfront/snippeteer [INFO] finished frobbing Schlechtwetterfront/snippeteer [INFO] frobbed toml for Schlechtwetterfront/snippeteer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Schlechtwetterfront/snippeteer/Cargo.toml [INFO] crate Schlechtwetterfront/snippeteer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Schlechtwetterfront/snippeteer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Schlechtwetterfront/snippeteer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8dd7847445a206ebd77a8ba54c121cd4dc92f66da07bd01d1eece5d8704ce76c [INFO] running `"docker" "start" "-a" "8dd7847445a206ebd77a8ba54c121cd4dc92f66da07bd01d1eece5d8704ce76c"` [INFO] [stderr] Checking snippeteer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gui/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gui/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gui/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gui/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/clipman/clip.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_content` [INFO] [stderr] --> src/clipman/clip.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn set_content(&mut self, content: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_title` [INFO] [stderr] --> src/clipman/clip.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn set_title(&mut self, title: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `title` [INFO] [stderr] --> src/clipman/clip.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn title(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `modified` [INFO] [stderr] --> src/clipman/clip.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn modified(&self) -> DateTime { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `add_column` [INFO] [stderr] --> src/gui/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn add_column(tree: &TreeView, id: i32, title: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/clipman/clip.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | self.created.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.created` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/clipman/clip.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | self.modified.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.modified` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clipman/mod.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(_) = self.clips.remove(&key) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 54 | | true [INFO] [stderr] 55 | | } else { [INFO] [stderr] 56 | | false [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________- help: try this: `if self.clips.remove(&key).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clipman/mod.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | if let Some(_) = self.named_clips.remove(&key) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 62 | | true [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | false [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________- help: try this: `if self.named_clips.remove(&key).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:155:72 [INFO] [stderr] | [INFO] [stderr] 155 | } else if locked.remove_named_clip(id.clone()) { [INFO] [stderr] | ________________________________________________________________________^ [INFO] [stderr] 156 | | status(format!("Deleted clip {:?}", id)); [INFO] [stderr] 157 | | } else { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:153:59 [INFO] [stderr] | [INFO] [stderr] 153 | if locked.remove_clip(id.clone()) { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 154 | | status(format!("Deleted clip {:?}", id)); [INFO] [stderr] 155 | | } else if locked.remove_named_clip(id.clone()) { [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/clipman/clip.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_content` [INFO] [stderr] --> src/clipman/clip.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn set_content(&mut self, content: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_title` [INFO] [stderr] --> src/clipman/clip.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn set_title(&mut self, title: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `title` [INFO] [stderr] --> src/clipman/clip.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn title(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `modified` [INFO] [stderr] --> src/clipman/clip.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn modified(&self) -> DateTime { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `add_column` [INFO] [stderr] --> src/gui/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn add_column(tree: &TreeView, id: i32, title: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/clipman/clip.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | self.created.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.created` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/clipman/clip.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | self.modified.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.modified` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: Could not compile `snippeteer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clipman/mod.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(_) = self.clips.remove(&key) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 54 | | true [INFO] [stderr] 55 | | } else { [INFO] [stderr] 56 | | false [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________- help: try this: `if self.clips.remove(&key).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clipman/mod.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | if let Some(_) = self.named_clips.remove(&key) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 62 | | true [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | false [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________- help: try this: `if self.named_clips.remove(&key).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:155:72 [INFO] [stderr] | [INFO] [stderr] 155 | } else if locked.remove_named_clip(id.clone()) { [INFO] [stderr] | ________________________________________________________________________^ [INFO] [stderr] 156 | | status(format!("Deleted clip {:?}", id)); [INFO] [stderr] 157 | | } else { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:153:59 [INFO] [stderr] | [INFO] [stderr] 153 | if locked.remove_clip(id.clone()) { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 154 | | status(format!("Deleted clip {:?}", id)); [INFO] [stderr] 155 | | } else if locked.remove_named_clip(id.clone()) { [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `snippeteer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8dd7847445a206ebd77a8ba54c121cd4dc92f66da07bd01d1eece5d8704ce76c"` [INFO] running `"docker" "rm" "-f" "8dd7847445a206ebd77a8ba54c121cd4dc92f66da07bd01d1eece5d8704ce76c"` [INFO] [stdout] 8dd7847445a206ebd77a8ba54c121cd4dc92f66da07bd01d1eece5d8704ce76c