[INFO] updating cached repository SamHH/osctf-native-experiment
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/SamHH/osctf-native-experiment
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/SamHH/osctf-native-experiment" "work/ex/clippy-test-run/sources/stable/gh/SamHH/osctf-native-experiment"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SamHH/osctf-native-experiment'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/SamHH/osctf-native-experiment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SamHH/osctf-native-experiment"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SamHH/osctf-native-experiment'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7e7fe35966b4e349b985df63d9edf041e0268f41
[INFO] sha for GitHub repo SamHH/osctf-native-experiment: 7e7fe35966b4e349b985df63d9edf041e0268f41
[INFO] validating manifest of SamHH/osctf-native-experiment on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of SamHH/osctf-native-experiment on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing SamHH/osctf-native-experiment
[INFO] finished frobbing SamHH/osctf-native-experiment
[INFO] frobbed toml for SamHH/osctf-native-experiment written to work/ex/clippy-test-run/sources/stable/gh/SamHH/osctf-native-experiment/Cargo.toml
[INFO] started frobbing SamHH/osctf-native-experiment
[INFO] finished frobbing SamHH/osctf-native-experiment
[INFO] frobbed toml for SamHH/osctf-native-experiment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SamHH/osctf-native-experiment/Cargo.toml
[INFO] crate SamHH/osctf-native-experiment has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting SamHH/osctf-native-experiment against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SamHH/osctf-native-experiment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ffe379c4c89d320dfda19e302d0ebabe3749ad5e3d7a8f8964712a32ef230c3d
[INFO] running `"docker" "start" "-a" "ffe379c4c89d320dfda19e302d0ebabe3749ad5e3d7a8f8964712a32ef230c3d"`
[INFO] [stderr]     Checking update_rate v2.0.0
[INFO] [stderr]     Checking x11-dl v2.17.5
[INFO] [stderr]    Compiling num-derive v0.2.2
[INFO] [stderr]     Checking rusttype v0.4.3
[INFO] [stderr]     Checking pistoncore-input v0.21.0
[INFO] [stderr]     Checking gfx_device_gl v0.15.3
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking piston2d-graphics v0.26.0
[INFO] [stderr]     Checking pistoncore-window v0.32.0
[INFO] [stderr]     Checking winit v0.12.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.37.0
[INFO] [stderr]     Checking piston v0.37.0
[INFO] [stderr]     Checking glutin v0.14.0
[INFO] [stderr]     Checking piston-gfx_texture v0.32.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.47.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.51.0
[INFO] [stderr]     Checking piston_window v0.80.0
[INFO] [stderr]     Checking osctf-native v0.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/config.rs:3:22
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub const APP_NAME: &'static str = "OSCTF Native Experiment";
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers/balls.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     return world.create_entity()
[INFO] [stderr] 12 | |         .with(Renderable { model: Ball, color: None })
[INFO] [stderr] 13 | |         .with(team)
[INFO] [stderr] 14 | |         .with(Pos { x: 200.0, y: 200.0 }) // TODO fetch these coords from map spawn points data
[INFO] [stderr] 15 | |         .with(Vel { x: 0.0, y: 0.0 })
[INFO] [stderr] 16 | |         .build();
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |     world.create_entity()
[INFO] [stderr] 12 |         .with(Renderable { model: Ball, color: None })
[INFO] [stderr] 13 |         .with(team)
[INFO] [stderr] 14 |         .with(Pos { x: 200.0, y: 200.0 }) // TODO fetch these coords from map spawn points data
[INFO] [stderr] 15 |         .with(Vel { x: 0.0, y: 0.0 })
[INFO] [stderr] 16 |         .build()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers/balls.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     return ball_entity;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ball_entity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers/glyphs.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return Glyphs::new(font, factory, TextureSettings::new()).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Glyphs::new(font, factory, TextureSettings::new()).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers/teams.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     return (std_team_1, std_team_2);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(std_team_1, std_team_2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/config.rs:3:22
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub const APP_NAME: &'static str = "OSCTF Native Experiment";
[INFO] [stderr]   |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers/balls.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     return world.create_entity()
[INFO] [stderr] 12 | |         .with(Renderable { model: Ball, color: None })
[INFO] [stderr] 13 | |         .with(team)
[INFO] [stderr] 14 | |         .with(Pos { x: 200.0, y: 200.0 }) // TODO fetch these coords from map spawn points data
[INFO] [stderr] 15 | |         .with(Vel { x: 0.0, y: 0.0 })
[INFO] [stderr] 16 | |         .build();
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 11 |     world.create_entity()
[INFO] [stderr] 12 |         .with(Renderable { model: Ball, color: None })
[INFO] [stderr] 13 |         .with(team)
[INFO] [stderr] 14 |         .with(Pos { x: 200.0, y: 200.0 }) // TODO fetch these coords from map spawn points data
[INFO] [stderr] 15 |         .with(Vel { x: 0.0, y: 0.0 })
[INFO] [stderr] 16 |         .build()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers/balls.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     return ball_entity;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ball_entity`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers/glyphs.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     return Glyphs::new(font, factory, TextureSettings::new()).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Glyphs::new(font, factory, TextureSettings::new()).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers/teams.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     return (std_team_1, std_team_2);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(std_team_1, std_team_2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/helpers/glyphs.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let ref font = assets.join("FiraSans-Regular.ttf");
[INFO] [stderr]    |     ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:129:33
[INFO] [stderr]     |
[INFO] [stderr] 129 |             dispatcher.dispatch(&mut world.res);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:134:17
[INFO] [stderr]     |
[INFO] [stderr] 134 | /                 if btn.state == ButtonState::Press { true }
[INFO] [stderr] 135 | |                 else { false };
[INFO] [stderr]     | |______________________________^ help: you can reduce it to: `btn.state == ButtonState::Press`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:137:13
[INFO] [stderr]     |
[INFO] [stderr] 137 | /             match btn.button {
[INFO] [stderr] 138 | |                 Button::Keyboard(key) => {
[INFO] [stderr] 139 | |                     let mut input = world.write_resource::<PlayerInput>();
[INFO] [stderr] 140 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |                 _ => {}
[INFO] [stderr] 162 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 137 |             if let Button::Keyboard(key) = btn.button {
[INFO] [stderr] 138 |     let mut input = world.write_resource::<PlayerInput>();
[INFO] [stderr] 139 | 
[INFO] [stderr] 140 |     match key {
[INFO] [stderr] 141 |         Key::W => {
[INFO] [stderr] 142 |             input.up = btn_active;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/helpers/glyphs.rs:11:9
[INFO] [stderr]    |
[INFO] [stderr] 11 |     let ref font = assets.join("FiraSans-Regular.ttf");
[INFO] [stderr]    |     ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:129:33
[INFO] [stderr]     |
[INFO] [stderr] 129 |             dispatcher.dispatch(&mut world.res);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:134:17
[INFO] [stderr]     |
[INFO] [stderr] 134 | /                 if btn.state == ButtonState::Press { true }
[INFO] [stderr] 135 | |                 else { false };
[INFO] [stderr]     | |______________________________^ help: you can reduce it to: `btn.state == ButtonState::Press`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:137:13
[INFO] [stderr]     |
[INFO] [stderr] 137 | /             match btn.button {
[INFO] [stderr] 138 | |                 Button::Keyboard(key) => {
[INFO] [stderr] 139 | |                     let mut input = world.write_resource::<PlayerInput>();
[INFO] [stderr] 140 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |                 _ => {}
[INFO] [stderr] 162 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 137 |             if let Button::Keyboard(key) = btn.button {
[INFO] [stderr] 138 |     let mut input = world.write_resource::<PlayerInput>();
[INFO] [stderr] 139 | 
[INFO] [stderr] 140 |     match key {
[INFO] [stderr] 141 |         Key::W => {
[INFO] [stderr] 142 |             input.up = btn_active;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 33.34s
[INFO] running `"docker" "inspect" "ffe379c4c89d320dfda19e302d0ebabe3749ad5e3d7a8f8964712a32ef230c3d"`
[INFO] running `"docker" "rm" "-f" "ffe379c4c89d320dfda19e302d0ebabe3749ad5e3d7a8f8964712a32ef230c3d"`
[INFO] [stdout] ffe379c4c89d320dfda19e302d0ebabe3749ad5e3d7a8f8964712a32ef230c3d