[INFO] updating cached repository Sam-Jeston/overdrive [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Sam-Jeston/overdrive [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Sam-Jeston/overdrive" "work/ex/clippy-test-run/sources/stable/gh/Sam-Jeston/overdrive"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Sam-Jeston/overdrive'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Sam-Jeston/overdrive" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sam-Jeston/overdrive"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sam-Jeston/overdrive'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bf71ecab7986cfbe534d476a146cd2ecdbe75707 [INFO] sha for GitHub repo Sam-Jeston/overdrive: bf71ecab7986cfbe534d476a146cd2ecdbe75707 [INFO] validating manifest of Sam-Jeston/overdrive on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Sam-Jeston/overdrive on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Sam-Jeston/overdrive [INFO] finished frobbing Sam-Jeston/overdrive [INFO] frobbed toml for Sam-Jeston/overdrive written to work/ex/clippy-test-run/sources/stable/gh/Sam-Jeston/overdrive/Cargo.toml [INFO] started frobbing Sam-Jeston/overdrive [INFO] finished frobbing Sam-Jeston/overdrive [INFO] frobbed toml for Sam-Jeston/overdrive written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Sam-Jeston/overdrive/Cargo.toml [INFO] crate Sam-Jeston/overdrive has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Sam-Jeston/overdrive against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Sam-Jeston/overdrive:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8361a43e8475f67101a2f903a89b194be7cb419ef53bb3e3bb336723470be3e1 [INFO] running `"docker" "start" "-a" "8361a43e8475f67101a2f903a89b194be7cb419ef53bb3e3bb336723470be3e1"` [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking overdrive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | thread::sleep_ms(10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `contractId` should have a snake case name such as `contract_id` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | contractId: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self.job_list.len() > 0 { [INFO] [stderr] 36 | | true => { [INFO] [stderr] 37 | | self.notify_next_in_line(); [INFO] [stderr] 38 | | }, [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 35 | if self.job_list.len() > 0 { [INFO] [stderr] 36 | self.notify_next_in_line(); [INFO] [stderr] 37 | } else { [INFO] [stderr] 38 | println!("Finished our queue, exiting"); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | match self.job_list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.job_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | if job.in_progress == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `job.in_progress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | thread::sleep_ms(10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `contractId` should have a snake case name such as `contract_id` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | contractId: i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self.job_list.len() > 0 { [INFO] [stderr] 36 | | true => { [INFO] [stderr] 37 | | self.notify_next_in_line(); [INFO] [stderr] 38 | | }, [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 35 | if self.job_list.len() > 0 { [INFO] [stderr] 36 | self.notify_next_in_line(); [INFO] [stderr] 37 | } else { [INFO] [stderr] 38 | println!("Finished our queue, exiting"); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | match self.job_list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.job_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | if job.in_progress == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `job.in_progress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.33s [INFO] running `"docker" "inspect" "8361a43e8475f67101a2f903a89b194be7cb419ef53bb3e3bb336723470be3e1"` [INFO] running `"docker" "rm" "-f" "8361a43e8475f67101a2f903a89b194be7cb419ef53bb3e3bb336723470be3e1"` [INFO] [stdout] 8361a43e8475f67101a2f903a89b194be7cb419ef53bb3e3bb336723470be3e1