[INFO] updating cached repository SachinMaharana/goc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SachinMaharana/goc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SachinMaharana/goc" "work/ex/clippy-test-run/sources/stable/gh/SachinMaharana/goc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SachinMaharana/goc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SachinMaharana/goc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SachinMaharana/goc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SachinMaharana/goc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8a8c500270deae05cb6983b36fabffe7978b6da6 [INFO] sha for GitHub repo SachinMaharana/goc: 8a8c500270deae05cb6983b36fabffe7978b6da6 [INFO] validating manifest of SachinMaharana/goc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SachinMaharana/goc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SachinMaharana/goc [INFO] finished frobbing SachinMaharana/goc [INFO] frobbed toml for SachinMaharana/goc written to work/ex/clippy-test-run/sources/stable/gh/SachinMaharana/goc/Cargo.toml [INFO] started frobbing SachinMaharana/goc [INFO] finished frobbing SachinMaharana/goc [INFO] frobbed toml for SachinMaharana/goc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SachinMaharana/goc/Cargo.toml [INFO] crate SachinMaharana/goc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SachinMaharana/goc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SachinMaharana/goc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bad2ac46f9b34a8f3ea58ff0797dc4f368502975e730982747ed77bc2fa8cd5b [INFO] running `"docker" "start" "-a" "bad2ac46f9b34a8f3ea58ff0797dc4f368502975e730982747ed77bc2fa8cd5b"` [INFO] [stderr] Checking goc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn create_dir(folder_name: &String) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 20 | pub fn create_dir(folder_name: &str) -> std::io::Result<()> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `folder_name.clone()` to [INFO] [stderr] | [INFO] [stderr] 21 | fs::create_dir(folder_name.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn write_data(folder: &String, data: &[u8], file: &str) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn create_dir(folder_name: &String) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 20 | pub fn create_dir(folder_name: &str) -> std::io::Result<()> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `folder_name.clone()` to [INFO] [stderr] | [INFO] [stderr] 21 | fs::create_dir(folder_name.to_string())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn write_data(folder: &String, data: &[u8], file: &str) -> std::io::Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.70s [INFO] running `"docker" "inspect" "bad2ac46f9b34a8f3ea58ff0797dc4f368502975e730982747ed77bc2fa8cd5b"` [INFO] running `"docker" "rm" "-f" "bad2ac46f9b34a8f3ea58ff0797dc4f368502975e730982747ed77bc2fa8cd5b"` [INFO] [stdout] bad2ac46f9b34a8f3ea58ff0797dc4f368502975e730982747ed77bc2fa8cd5b