[INFO] updating cached repository SLMT/rust-ogldev [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SLMT/rust-ogldev [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SLMT/rust-ogldev" "work/ex/clippy-test-run/sources/stable/gh/SLMT/rust-ogldev"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SLMT/rust-ogldev'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SLMT/rust-ogldev" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/rust-ogldev"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/rust-ogldev'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 014e9a1c9260a898d44ea36a11f62c0a92b126b2 [INFO] sha for GitHub repo SLMT/rust-ogldev: 014e9a1c9260a898d44ea36a11f62c0a92b126b2 [INFO] validating manifest of SLMT/rust-ogldev on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SLMT/rust-ogldev on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SLMT/rust-ogldev [INFO] finished frobbing SLMT/rust-ogldev [INFO] frobbed toml for SLMT/rust-ogldev written to work/ex/clippy-test-run/sources/stable/gh/SLMT/rust-ogldev/Cargo.toml [INFO] started frobbing SLMT/rust-ogldev [INFO] finished frobbing SLMT/rust-ogldev [INFO] frobbed toml for SLMT/rust-ogldev written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/rust-ogldev/Cargo.toml [INFO] crate SLMT/rust-ogldev has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SLMT/rust-ogldev against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SLMT/rust-ogldev:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c141170cbb89e03bc7b841861a01bf3527570df490cef8ed814f7f61c0dc8964 [INFO] running `"docker" "start" "-a" "c141170cbb89e03bc7b841861a01bf3527570df490cef8ed814f7f61c0dc8964"` [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Checking num_cpus v1.2.0 [INFO] [stderr] Checking cgmath v0.12.0 [INFO] [stderr] Compiling glium v0.15.0 [INFO] [stderr] Checking libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking rayon v0.5.0 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking wayland-client v0.5.12 [INFO] [stderr] Checking jpeg-decoder v0.1.9 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking glutin v0.6.2 [INFO] [stderr] Checking ogldev v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | fov: fov, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fov` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | z_near: z_near, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `z_near` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | z_far: z_far [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `z_far` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | fov: fov, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fov` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | z_near: z_near, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `z_near` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pipeline.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | z_far: z_far [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `z_far` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/camera.rs:151:16 [INFO] [stderr] | [INFO] [stderr] 151 | } else if self.on_lower_edge { [INFO] [stderr] | ________________^ [INFO] [stderr] 152 | | if self.angle_v < 90.0 { [INFO] [stderr] 153 | | self.angle_v += 0.1; [INFO] [stderr] 154 | | should_update = true; [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | } else if self.on_lower_edge && self.angle_v < 90.0 { [INFO] [stderr] 152 | self.angle_v += 0.1; [INFO] [stderr] 153 | should_update = true; [INFO] [stderr] 154 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/camera.rs:172:16 [INFO] [stderr] | [INFO] [stderr] 172 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 173 | | if h_target.x >= 0.0 { [INFO] [stderr] 174 | | self.angle_h = (-h_target.z).asin().to_degrees(); [INFO] [stderr] 175 | | } else { [INFO] [stderr] 176 | | self.angle_h = 90.0 + (-h_target.z).asin().to_degrees(); [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 172 | } else if h_target.x >= 0.0 { [INFO] [stderr] 173 | self.angle_h = (-h_target.z).asin().to_degrees(); [INFO] [stderr] 174 | } else { [INFO] [stderr] 175 | self.angle_h = 90.0 + (-h_target.z).asin().to_degrees(); [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `pipeline::Pipeline` [INFO] [stderr] --> src/pipeline.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Pipeline { [INFO] [stderr] 34 | | Pipeline { [INFO] [stderr] 35 | | scale: Vector3::new(1.0, 1.0, 1.0), [INFO] [stderr] 36 | | world_pos: Vector3::new(0.0, 0.0, 0.0), [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for pipeline::Pipeline { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/camera.rs:151:16 [INFO] [stderr] | [INFO] [stderr] 151 | } else if self.on_lower_edge { [INFO] [stderr] | ________________^ [INFO] [stderr] 152 | | if self.angle_v < 90.0 { [INFO] [stderr] 153 | | self.angle_v += 0.1; [INFO] [stderr] 154 | | should_update = true; [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 151 | } else if self.on_lower_edge && self.angle_v < 90.0 { [INFO] [stderr] 152 | self.angle_v += 0.1; [INFO] [stderr] 153 | should_update = true; [INFO] [stderr] 154 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/camera.rs:172:16 [INFO] [stderr] | [INFO] [stderr] 172 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 173 | | if h_target.x >= 0.0 { [INFO] [stderr] 174 | | self.angle_h = (-h_target.z).asin().to_degrees(); [INFO] [stderr] 175 | | } else { [INFO] [stderr] 176 | | self.angle_h = 90.0 + (-h_target.z).asin().to_degrees(); [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 172 | } else if h_target.x >= 0.0 { [INFO] [stderr] 173 | self.angle_h = (-h_target.z).asin().to_degrees(); [INFO] [stderr] 174 | } else { [INFO] [stderr] 175 | self.angle_h = 90.0 + (-h_target.z).asin().to_degrees(); [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `pipeline::Pipeline` [INFO] [stderr] --> src/pipeline.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Pipeline { [INFO] [stderr] 34 | | Pipeline { [INFO] [stderr] 35 | | scale: Vector3::new(1.0, 1.0, 1.0), [INFO] [stderr] 36 | | world_pos: Vector3::new(0.0, 0.0, 0.0), [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | impl Default for pipeline::Pipeline { [INFO] [stderr] 33 | fn default() -> Self { [INFO] [stderr] 34 | Self::new() [INFO] [stderr] 35 | } [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_12.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_12.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_12.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_12.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_12.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / match event { [INFO] [stderr] 130 | | Event::Closed => return, [INFO] [stderr] 131 | | _ => () [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_01.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | / match event { [INFO] [stderr] 24 | | Event::Closed => return, [INFO] [stderr] 25 | | _ => () [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_03.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_03.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_03.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_03.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_03.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match event { [INFO] [stderr] 87 | | Event::Closed => return, [INFO] [stderr] 88 | | _ => () [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_03.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match event { [INFO] [stderr] 87 | | Event::Closed => return, [INFO] [stderr] 88 | | _ => () [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_11.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_11.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_11.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_11.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_15.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_15.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_15.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_15.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_08.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_08.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_11.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | / match event { [INFO] [stderr] 127 | | Event::Closed => return, [INFO] [stderr] 128 | | _ => () [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_08.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | / match event { [INFO] [stderr] 112 | | Event::Closed => return, [INFO] [stderr] 113 | | _ => () [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_16.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_16.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_16.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_16.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/bin/tutorial_16.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | / fn render_scene(display: &GlutinFacade, vertex_buffer: &VertexBuffer, [INFO] [stderr] 88 | | index_buffer: &IndexBuffer, program: &Program, camera: &mut Camera, scale: f32, [INFO] [stderr] 89 | | texture: &Texture2d, params: &DrawParameters) { [INFO] [stderr] 90 | | [INFO] [stderr] ... | [INFO] [stderr] 110 | | frame.finish().unwrap(); [INFO] [stderr] 111 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_13.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_13.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_13.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_13.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_13.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / match event { [INFO] [stderr] 136 | | Event::Closed => return, [INFO] [stderr] 137 | | _ => () [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_07.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_07.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_12.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_12.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_12.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_12.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_07.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | / match event { [INFO] [stderr] 113 | | Event::Closed => return, [INFO] [stderr] 114 | | _ => () [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_12.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / match event { [INFO] [stderr] 130 | | Event::Closed => return, [INFO] [stderr] 131 | | _ => () [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_11.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_11.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_11.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_11.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_06.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_06.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_05.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_05.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_11.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | / match event { [INFO] [stderr] 127 | | Event::Closed => return, [INFO] [stderr] 128 | | _ => () [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_10.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_10.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_10.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_10.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_06.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | / match event { [INFO] [stderr] 111 | | Event::Closed => return, [INFO] [stderr] 112 | | _ => () [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_05.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / match event { [INFO] [stderr] 99 | | Event::Closed => return, [INFO] [stderr] 100 | | _ => () [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_10.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | / match event { [INFO] [stderr] 131 | | Event::Closed => return, [INFO] [stderr] 132 | | _ => () [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_04.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_04.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_04.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / match event { [INFO] [stderr] 91 | | Event::Closed => return, [INFO] [stderr] 92 | | _ => () [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_02.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_02.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | let vertex_buffer = VertexBuffer::new(display, &point).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_02.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / match event { [INFO] [stderr] 84 | | Event::Closed => return, [INFO] [stderr] 85 | | _ => () [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_01.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | / match event { [INFO] [stderr] 24 | | Event::Closed => return, [INFO] [stderr] 25 | | _ => () [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_08.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_08.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_08.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | / match event { [INFO] [stderr] 112 | | Event::Closed => return, [INFO] [stderr] 113 | | _ => () [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_07.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_07.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_04.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_04.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_07.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | / match event { [INFO] [stderr] 113 | | Event::Closed => return, [INFO] [stderr] 114 | | _ => () [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_14.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_14.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_14.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_14.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_04.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / match event { [INFO] [stderr] 91 | | Event::Closed => return, [INFO] [stderr] 92 | | _ => () [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_09.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_09.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_09.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match event { [INFO] [stderr] 117 | | Event::Closed => return, [INFO] [stderr] 118 | | _ => () [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_16.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_16.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_16.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_16.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/bin/tutorial_16.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | / fn render_scene(display: &GlutinFacade, vertex_buffer: &VertexBuffer, [INFO] [stderr] 88 | | index_buffer: &IndexBuffer, program: &Program, camera: &mut Camera, scale: f32, [INFO] [stderr] 89 | | texture: &Texture2d, params: &DrawParameters) { [INFO] [stderr] 90 | | [INFO] [stderr] ... | [INFO] [stderr] 110 | | frame.finish().unwrap(); [INFO] [stderr] 111 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_14.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_14.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_14.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_14.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_10.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_10.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_10.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_10.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_10.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | / match event { [INFO] [stderr] 131 | | Event::Closed => return, [INFO] [stderr] 132 | | _ => () [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_02.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_02.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | let vertex_buffer = VertexBuffer::new(display, &point).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_02.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / match event { [INFO] [stderr] 84 | | Event::Closed => return, [INFO] [stderr] 85 | | _ => () [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_09.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_09.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_09.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match event { [INFO] [stderr] 117 | | Event::Closed => return, [INFO] [stderr] 118 | | _ => () [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_15.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_15.rs:32:25 [INFO] [stderr] | [INFO] [stderr] 32 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_15.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_15.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_06.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_06.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_06.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | / match event { [INFO] [stderr] 111 | | Event::Closed => return, [INFO] [stderr] 112 | | _ => () [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_13.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_13.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_13.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | index_buffer [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_13.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | let index_buffer = IndexBuffer::new(display, PrimitiveType::TrianglesList, &indcies).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_13.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / match event { [INFO] [stderr] 136 | | Event::Closed => return, [INFO] [stderr] 137 | | _ => () [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/tutorial_05.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | vertex_buffer [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/tutorial_05.rs:24:25 [INFO] [stderr] | [INFO] [stderr] 24 | let vertex_buffer = VertexBuffer::new(display, &vertices).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/tutorial_05.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | / match event { [INFO] [stderr] 99 | | Event::Closed => return, [INFO] [stderr] 100 | | _ => () [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 24s [INFO] running `"docker" "inspect" "c141170cbb89e03bc7b841861a01bf3527570df490cef8ed814f7f61c0dc8964"` [INFO] running `"docker" "rm" "-f" "c141170cbb89e03bc7b841861a01bf3527570df490cef8ed814f7f61c0dc8964"` [INFO] [stdout] c141170cbb89e03bc7b841861a01bf3527570df490cef8ed814f7f61c0dc8964