[INFO] updating cached repository SLMT/fancy-go [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SLMT/fancy-go [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SLMT/fancy-go" "work/ex/clippy-test-run/sources/stable/gh/SLMT/fancy-go"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SLMT/fancy-go'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SLMT/fancy-go" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/fancy-go"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/fancy-go'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 616fa70fa5e47e566c145708829cf912a4709fe1 [INFO] sha for GitHub repo SLMT/fancy-go: 616fa70fa5e47e566c145708829cf912a4709fe1 [INFO] validating manifest of SLMT/fancy-go on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SLMT/fancy-go on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SLMT/fancy-go [INFO] finished frobbing SLMT/fancy-go [INFO] frobbed toml for SLMT/fancy-go written to work/ex/clippy-test-run/sources/stable/gh/SLMT/fancy-go/Cargo.toml [INFO] started frobbing SLMT/fancy-go [INFO] finished frobbing SLMT/fancy-go [INFO] frobbed toml for SLMT/fancy-go written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SLMT/fancy-go/Cargo.toml [INFO] crate SLMT/fancy-go has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SLMT/fancy-go against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SLMT/fancy-go:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0954159bc024681fa8b78731943a512ff3759a4f1f098d56f5a69eca2fdbb45e [INFO] running `"docker" "start" "-a" "0954159bc024681fa8b78731943a512ff3759a4f1f098d56f5a69eca2fdbb45e"` [INFO] [stderr] Compiling bitflags v0.3.3 [INFO] [stderr] Checking piston-texture v0.4.0 [INFO] [stderr] Checking draw_state v0.4.0 [INFO] [stderr] Checking gif v0.8.0 [INFO] [stderr] Compiling wayland-scanner v0.5.11 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Checking pistoncore-input v0.10.0 [INFO] [stderr] Compiling glutin v0.5.2 [INFO] [stderr] Compiling xml-rs v0.2.2 [INFO] [stderr] Checking piston2d-graphics v0.16.0 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Checking gfx_core v0.2.1 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Compiling wayland-client v0.5.12 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking pistoncore-window v0.17.0 [INFO] [stderr] Checking image v0.9.1 [INFO] [stderr] Compiling gl_generator v0.4.2 [INFO] [stderr] Checking pistoncore-event_loop v0.20.1 [INFO] [stderr] Checking piston v0.20.1 [INFO] [stderr] Compiling gl v0.5.2 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking gfx v0.10.2 [INFO] [stderr] Checking gfx_device_gl v0.9.0 [INFO] [stderr] Checking piston-gfx_texture v0.14.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.24.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.27.0 [INFO] [stderr] Checking piston_window v0.44.0 [INFO] [stderr] Checking fancy-go v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/board.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | let h = STAR_POINT_RADIUS; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stone.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | hexes: hexes [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hexes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stone.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stone.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | color: color [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/board.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | let h = STAR_POINT_RADIUS; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stone.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | hexes: hexes [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hexes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stone.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stone.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | color: color [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | const WINDOW_TITLE: &'static str = "Fancy Go"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | const WINDOW_TITLE: &'static str = "Fancy Go"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arg` [INFO] [stderr] --> src/main.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | event.update(|arg| { [INFO] [stderr] | ^^^ help: consider using `_arg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arg` [INFO] [stderr] --> src/main.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | event.update(|arg| { [INFO] [stderr] | ^^^ help: consider using `_arg` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/board.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | (point[0] as f64) * POINT_SPACING; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(point[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/board.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | (point[1] as f64) * POINT_SPACING; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(point[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/board.rs:154:32 [INFO] [stderr] | [INFO] [stderr] 154 | for (radius, color) in vec![(BORDER_RADIUS + 2.0, BORDER1_COLOR), (BORDER_RADIUS, BORDER2_COLOR)] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[(BORDER_RADIUS + 2.0, BORDER1_COLOR), (BORDER_RADIUS, BORDER2_COLOR)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/board.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | line(color, radius, l.clone(), con.transform, g); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/stone.rs:70:40 [INFO] [stderr] | [INFO] [stderr] 70 | let base: f64 = PI / 6.0 * (1 + 2 * i) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 + 2 * i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/board.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | (point[0] as f64) * POINT_SPACING; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(point[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/board.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | (point[1] as f64) * POINT_SPACING; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(point[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/board.rs:154:32 [INFO] [stderr] | [INFO] [stderr] 154 | for (radius, color) in vec![(BORDER_RADIUS + 2.0, BORDER1_COLOR), (BORDER_RADIUS, BORDER2_COLOR)] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[(BORDER_RADIUS + 2.0, BORDER1_COLOR), (BORDER_RADIUS, BORDER2_COLOR)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/board.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | line(color, radius, l.clone(), con.transform, g); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/stone.rs:70:40 [INFO] [stderr] | [INFO] [stderr] 70 | let base: f64 = PI / 6.0 * (1 + 2 * i) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 + 2 * i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.90s [INFO] running `"docker" "inspect" "0954159bc024681fa8b78731943a512ff3759a4f1f098d56f5a69eca2fdbb45e"` [INFO] running `"docker" "rm" "-f" "0954159bc024681fa8b78731943a512ff3759a4f1f098d56f5a69eca2fdbb45e"` [INFO] [stdout] 0954159bc024681fa8b78731943a512ff3759a4f1f098d56f5a69eca2fdbb45e