[INFO] updating cached repository SHAKOTN/whatever_rs_bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SHAKOTN/whatever_rs_bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SHAKOTN/whatever_rs_bot" "work/ex/clippy-test-run/sources/stable/gh/SHAKOTN/whatever_rs_bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SHAKOTN/whatever_rs_bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SHAKOTN/whatever_rs_bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SHAKOTN/whatever_rs_bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SHAKOTN/whatever_rs_bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8b666ebb2170ff95de9de2e56f61bad524f76bfd [INFO] sha for GitHub repo SHAKOTN/whatever_rs_bot: 8b666ebb2170ff95de9de2e56f61bad524f76bfd [INFO] validating manifest of SHAKOTN/whatever_rs_bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SHAKOTN/whatever_rs_bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SHAKOTN/whatever_rs_bot [INFO] finished frobbing SHAKOTN/whatever_rs_bot [INFO] frobbed toml for SHAKOTN/whatever_rs_bot written to work/ex/clippy-test-run/sources/stable/gh/SHAKOTN/whatever_rs_bot/Cargo.toml [INFO] started frobbing SHAKOTN/whatever_rs_bot [INFO] finished frobbing SHAKOTN/whatever_rs_bot [INFO] frobbed toml for SHAKOTN/whatever_rs_bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SHAKOTN/whatever_rs_bot/Cargo.toml [INFO] crate SHAKOTN/whatever_rs_bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SHAKOTN/whatever_rs_bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SHAKOTN/whatever_rs_bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a388230526033fd41159da9a8f5d184923d70c9879cffe64856a65f6fc2f3b64 [INFO] running `"docker" "start" "-a" "a388230526033fd41159da9a8f5d184923d70c9879cffe64856a65f6fc2f3b64"` [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking openssl-sys v0.9.35 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-reactor v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.7 [INFO] [stderr] Checking whatever v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bot.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / return match env::var("TELEGRAM_BOT_TOKEN") { [INFO] [stderr] 49 | | Ok(token) => token, [INFO] [stderr] 50 | | Err(e) => panic!("Couldn't read TELEGRAM_BOT_TOKEN ({})", e), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | match env::var("TELEGRAM_BOT_TOKEN") { [INFO] [stderr] 49 | Ok(token) => token, [INFO] [stderr] 50 | Err(e) => panic!("Couldn't read TELEGRAM_BOT_TOKEN ({})", e), [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bot.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | parsed_response [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bot.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | let parsed_response = parse::parse_response(raw_response.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bot.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / return match env::var("TELEGRAM_BOT_TOKEN") { [INFO] [stderr] 49 | | Ok(token) => token, [INFO] [stderr] 50 | | Err(e) => panic!("Couldn't read TELEGRAM_BOT_TOKEN ({})", e), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | match env::var("TELEGRAM_BOT_TOKEN") { [INFO] [stderr] 49 | Ok(token) => token, [INFO] [stderr] 50 | Err(e) => panic!("Couldn't read TELEGRAM_BOT_TOKEN ({})", e), [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bot.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | parsed_response [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bot.rs:74:31 [INFO] [stderr] | [INFO] [stderr] 74 | let parsed_response = parse::parse_response(raw_response.as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bot.rs:20:35 [INFO] [stderr] | [INFO] [stderr] 20 | fn get_updates(&self, offset: &i32) -> Result; [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bot.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | / match text.as_ref() { [INFO] [stderr] 121 | | "/say_hello" => { [INFO] [stderr] 122 | | let mut request_body = HashMap::new(); [INFO] [stderr] 123 | | request_body.insert("chat_id", TValue::Int64(&chat_id)); [INFO] [stderr] ... | [INFO] [stderr] 127 | | _ => {} [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | if let "/say_hello" = text.as_ref() { [INFO] [stderr] 121 | let mut request_body = HashMap::new(); [INFO] [stderr] 122 | request_body.insert("chat_id", TValue::Int64(&chat_id)); [INFO] [stderr] 123 | request_body.insert("text", TValue::String("Hello!")); [INFO] [stderr] 124 | self.api_req("sendMessage", request_body); [INFO] [stderr] 125 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bot.rs:20:35 [INFO] [stderr] | [INFO] [stderr] 20 | fn get_updates(&self, offset: &i32) -> Result; [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bot.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | / match text.as_ref() { [INFO] [stderr] 121 | | "/say_hello" => { [INFO] [stderr] 122 | | let mut request_body = HashMap::new(); [INFO] [stderr] 123 | | request_body.insert("chat_id", TValue::Int64(&chat_id)); [INFO] [stderr] ... | [INFO] [stderr] 127 | | _ => {} [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | if let "/say_hello" = text.as_ref() { [INFO] [stderr] 121 | let mut request_body = HashMap::new(); [INFO] [stderr] 122 | request_body.insert("chat_id", TValue::Int64(&chat_id)); [INFO] [stderr] 123 | request_body.insert("text", TValue::String("Hello!")); [INFO] [stderr] 124 | self.api_req("sendMessage", request_body); [INFO] [stderr] 125 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 56.21s [INFO] running `"docker" "inspect" "a388230526033fd41159da9a8f5d184923d70c9879cffe64856a65f6fc2f3b64"` [INFO] running `"docker" "rm" "-f" "a388230526033fd41159da9a8f5d184923d70c9879cffe64856a65f6fc2f3b64"` [INFO] [stdout] a388230526033fd41159da9a8f5d184923d70c9879cffe64856a65f6fc2f3b64