[INFO] updating cached repository SCOTPAUL/email_to_image [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SCOTPAUL/email_to_image [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SCOTPAUL/email_to_image" "work/ex/clippy-test-run/sources/stable/gh/SCOTPAUL/email_to_image"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SCOTPAUL/email_to_image'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SCOTPAUL/email_to_image" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SCOTPAUL/email_to_image"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SCOTPAUL/email_to_image'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 47eb0fdca206fb06b9ed4fae9310484b16dae420 [INFO] sha for GitHub repo SCOTPAUL/email_to_image: 47eb0fdca206fb06b9ed4fae9310484b16dae420 [INFO] validating manifest of SCOTPAUL/email_to_image on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SCOTPAUL/email_to_image on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SCOTPAUL/email_to_image [INFO] finished frobbing SCOTPAUL/email_to_image [INFO] frobbed toml for SCOTPAUL/email_to_image written to work/ex/clippy-test-run/sources/stable/gh/SCOTPAUL/email_to_image/Cargo.toml [INFO] started frobbing SCOTPAUL/email_to_image [INFO] finished frobbing SCOTPAUL/email_to_image [INFO] frobbed toml for SCOTPAUL/email_to_image written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SCOTPAUL/email_to_image/Cargo.toml [INFO] crate SCOTPAUL/email_to_image has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SCOTPAUL/email_to_image against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SCOTPAUL/email_to_image:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e341f5f6f9b4d0009d84bbe5c47c344b5fc1a761e0da622f240aee7d4fdeda9f [INFO] running `"docker" "start" "-a" "e341f5f6f9b4d0009d84bbe5c47c344b5fc1a761e0da622f240aee7d4fdeda9f"` [INFO] [stderr] Checking podio v0.1.5 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking itertools v0.6.2 [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Compiling bzip2-sys v0.1.5 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Checking num-bigint v0.1.40 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking nalgebra v0.11.2 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking bzip2 v0.3.2 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking zip v0.2.6 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking quickcheck v0.2.27 [INFO] [stderr] Checking imageproc v0.10.0 [INFO] [stderr] Checking email_to_image v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:179:46 [INFO] [stderr] | [INFO] [stderr] 179 | match get_content(&RenderConfig {email: email, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:180:46 [INFO] [stderr] | [INFO] [stderr] 180 | output_file: output_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:181:46 [INFO] [stderr] | [INFO] [stderr] 181 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:179:46 [INFO] [stderr] | [INFO] [stderr] 179 | match get_content(&RenderConfig {email: email, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `email` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:180:46 [INFO] [stderr] | [INFO] [stderr] 180 | output_file: output_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:181:46 [INFO] [stderr] | [INFO] [stderr] 181 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | Either::B(err((hyper::error::Error::Io(std::io::Error::new(ErrorKind::NotFound, format!("Font {} not found", config.font)))))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | Either::B(err((hyper::error::Error::Io(std::io::Error::new(ErrorKind::NotFound, format!("Font {} not found", config.font)))))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:62:61 [INFO] [stderr] | [INFO] [stderr] 62 | let font = FontCollection::from_bytes(font).into_font().ok_or(std::io::Error::new(ErrorKind::Other, "Error loading font"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| std::io::Error::new(ErrorKind::Other, "Error loading font"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | Either::B(err((hyper::error::Error::Io(std::io::Error::new(ErrorKind::NotFound, format!("Font {} not found", config.font)))))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | Either::B(err((hyper::error::Error::Io(std::io::Error::new(ErrorKind::NotFound, format!("Font {} not found", config.font)))))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:62:61 [INFO] [stderr] | [INFO] [stderr] 62 | let font = FontCollection::from_bytes(font).into_font().ok_or(std::io::Error::new(ErrorKind::Other, "Error loading font"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| std::io::Error::new(ErrorKind::Other, "Error loading font"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.09s [INFO] running `"docker" "inspect" "e341f5f6f9b4d0009d84bbe5c47c344b5fc1a761e0da622f240aee7d4fdeda9f"` [INFO] running `"docker" "rm" "-f" "e341f5f6f9b4d0009d84bbe5c47c344b5fc1a761e0da622f240aee7d4fdeda9f"` [INFO] [stdout] e341f5f6f9b4d0009d84bbe5c47c344b5fc1a761e0da622f240aee7d4fdeda9f