[INFO] updating cached repository SCAII/Sky-install [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SCAII/Sky-install [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SCAII/Sky-install" "work/ex/clippy-test-run/sources/stable/gh/SCAII/Sky-install"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SCAII/Sky-install'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SCAII/Sky-install" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SCAII/Sky-install"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SCAII/Sky-install'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a7b04b26676983ab88580624b43f3114e4c36606 [INFO] sha for GitHub repo SCAII/Sky-install: a7b04b26676983ab88580624b43f3114e4c36606 [INFO] validating manifest of SCAII/Sky-install on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SCAII/Sky-install on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SCAII/Sky-install [INFO] finished frobbing SCAII/Sky-install [INFO] frobbed toml for SCAII/Sky-install written to work/ex/clippy-test-run/sources/stable/gh/SCAII/Sky-install/Cargo.toml [INFO] started frobbing SCAII/Sky-install [INFO] finished frobbing SCAII/Sky-install [INFO] frobbed toml for SCAII/Sky-install written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SCAII/Sky-install/Cargo.toml [INFO] crate SCAII/Sky-install has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SCAII/Sky-install against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SCAII/Sky-install:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3acfc6087ad1ac0ff24201a653cc2f6c7389d9d4ffb0447937f764f44687dd74 [INFO] running `"docker" "start" "-a" "3acfc6087ad1ac0ff24201a653cc2f6c7389d9d4ffb0447937f764f44687dd74"` [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.2 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Compiling openssl-sys v0.9.25 [INFO] [stderr] Checking miniz_oxide v0.1.2 [INFO] [stderr] Checking socket2 v0.3.1 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Checking bzip2 v0.3.2 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking zip v0.3.0 [INFO] [stderr] Checking curl v0.4.11 [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stderr] Checking sky-install v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/platform/linux.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/platform/linux.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `copy_built_core` [INFO] [stderr] --> src/platform/unix.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | use os_specific::{run_command, copy_built_core}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::git2::Repository` [INFO] [stderr] --> src/platform/unix.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | use self::git2::Repository; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::git2::Repository` [INFO] [stderr] --> src/platform/unix.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | use self::git2::Repository; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/platform/common/mod.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/platform/common/mod.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return Err(Box::new(InstallError::new(format!( [INFO] [stderr] 40 | | "ERROR - problem checking out branch {} : {}", [INFO] [stderr] 41 | | branch, result_string [INFO] [stderr] 42 | | )))); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | Err(Box::new(InstallError::new(format!( [INFO] [stderr] 40 | "ERROR - problem checking out branch {} : {}", [INFO] [stderr] 41 | branch, result_string [INFO] [stderr] 42 | )))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `Path` [INFO] [stderr] --> src/platform/linux.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs` [INFO] [stderr] --> src/platform/linux.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | use std::fs; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `copy_built_core` [INFO] [stderr] --> src/platform/unix.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | use os_specific::{run_command, copy_built_core}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::git2::Repository` [INFO] [stderr] --> src/platform/unix.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | use self::git2::Repository; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::git2::Repository` [INFO] [stderr] --> src/platform/unix.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | use self::git2::Repository; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/platform/common/mod.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/platform/common/mod.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return Err(Box::new(InstallError::new(format!( [INFO] [stderr] 40 | | "ERROR - problem checking out branch {} : {}", [INFO] [stderr] 41 | | branch, result_string [INFO] [stderr] 42 | | )))); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | Err(Box::new(InstallError::new(format!( [INFO] [stderr] 40 | "ERROR - problem checking out branch {} : {}", [INFO] [stderr] 41 | branch, result_string [INFO] [stderr] 42 | )))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:352:35 [INFO] [stderr] | [INFO] [stderr] 352 | let result: Option = env::home_dir(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:352:35 [INFO] [stderr] | [INFO] [stderr] 352 | let result: Option = env::home_dir(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `copy_built_rts` [INFO] [stderr] --> src/platform/linux.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn copy_built_rts(source_dir: PathBuf, target: PathBuf) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_sky_rts` [INFO] [stderr] --> src/platform/unix.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn get_sky_rts(install_dir: PathBuf, command_args: &Args) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | .expect(&format!("failed to launch command {}", command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to launch command {}", command))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: function is never used: `copy_built_rts` [INFO] [stderr] --> src/platform/linux.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn copy_built_rts(source_dir: PathBuf, target: PathBuf) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_sky_rts` [INFO] [stderr] --> src/platform/unix.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn get_sky_rts(install_dir: PathBuf, command_args: &Args) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/platform/linux.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | .expect(&format!("failed to launch command {}", command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to launch command {}", command))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/platform/unix.rs:112:8 [INFO] [stderr] | [INFO] [stderr] 112 | if !(result_string == "".to_string()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result_string != "".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/platform/unix.rs:112:27 [INFO] [stderr] | [INFO] [stderr] 112 | if !(result_string == "".to_string()) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/platform/unix.rs:112:8 [INFO] [stderr] | [INFO] [stderr] 112 | if !(result_string == "".to_string()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result_string != "".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/platform/unix.rs:112:27 [INFO] [stderr] | [INFO] [stderr] 112 | if !(result_string == "".to_string()) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/platform/common/mod.rs:184:29 [INFO] [stderr] | [INFO] [stderr] 184 | fn download_using_curl(url: &String, target_path: &PathBuf) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/platform/common/mod.rs:212:35 [INFO] [stderr] | [INFO] [stderr] 212 | let parts_iter = subdir.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/platform/common/mod.rs:272:35 [INFO] [stderr] | [INFO] [stderr] 272 | let parts_iter = subdir.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/platform/common/mod.rs:184:29 [INFO] [stderr] | [INFO] [stderr] 184 | fn download_using_curl(url: &String, target_path: &PathBuf) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | fn parse_args(arguments: &Vec) -> Args { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | fn try_command(command: &String, args: Args) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/platform/common/mod.rs:212:35 [INFO] [stderr] | [INFO] [stderr] 212 | let parts_iter = subdir.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/platform/common/mod.rs:272:35 [INFO] [stderr] | [INFO] [stderr] 272 | let parts_iter = subdir.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | shallow_clean(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | shallow_clean(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | fn parse_args(arguments: &Vec) -> Args { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | fn try_command(command: &String, args: Args) -> Result<(), Box> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | shallow_clean(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | shallow_clean(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | count = count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 33s [INFO] running `"docker" "inspect" "3acfc6087ad1ac0ff24201a653cc2f6c7389d9d4ffb0447937f764f44687dd74"` [INFO] running `"docker" "rm" "-f" "3acfc6087ad1ac0ff24201a653cc2f6c7389d9d4ffb0447937f764f44687dd74"` [INFO] [stdout] 3acfc6087ad1ac0ff24201a653cc2f6c7389d9d4ffb0447937f764f44687dd74