[INFO] updating cached repository SANDRAProject/service-rss [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SANDRAProject/service-rss [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SANDRAProject/service-rss" "work/ex/clippy-test-run/sources/stable/gh/SANDRAProject/service-rss"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SANDRAProject/service-rss'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SANDRAProject/service-rss" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SANDRAProject/service-rss"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SANDRAProject/service-rss'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 93e82422a93cb1a285e4e0981f101365948bdfa0 [INFO] sha for GitHub repo SANDRAProject/service-rss: 93e82422a93cb1a285e4e0981f101365948bdfa0 [INFO] validating manifest of SANDRAProject/service-rss on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SANDRAProject/service-rss on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SANDRAProject/service-rss [INFO] finished frobbing SANDRAProject/service-rss [INFO] frobbed toml for SANDRAProject/service-rss written to work/ex/clippy-test-run/sources/stable/gh/SANDRAProject/service-rss/Cargo.toml [INFO] started frobbing SANDRAProject/service-rss [INFO] finished frobbing SANDRAProject/service-rss [INFO] frobbed toml for SANDRAProject/service-rss written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SANDRAProject/service-rss/Cargo.toml [INFO] crate SANDRAProject/service-rss has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SANDRAProject/service-rss against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SANDRAProject/service-rss:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7493998632a07bf454fe0ca0984c7cfc94ef725be9102ab8a01e85dc59b14fd0 [INFO] running `"docker" "start" "-a" "7493998632a07bf454fe0ca0984c7cfc94ef725be9102ab8a01e85dc59b14fd0"` [INFO] [stderr] Compiling syn v0.9.2 [INFO] [stderr] Compiling syntex_fmt_macros v0.5.0 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling string_cache_codegen v0.3.1 [INFO] [stderr] Compiling string_cache v0.2.29 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Compiling string_cache v0.3.0 [INFO] [stderr] Compiling html5ever-atoms v0.1.3 [INFO] [stderr] Compiling html5ever v0.9.0 [INFO] [stderr] Checking rss v1.5.0 [INFO] [stderr] Compiling derive-error-chain v0.11.1 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling serde_derive v1.0.42 [INFO] [stderr] Checking dotenv v0.11.0 [INFO] [stderr] Checking html2text v0.1.7 [INFO] [stderr] Checking service-rss v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | ref api_endpoint: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | ref deploy_token: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | ref metadata: types::ServiceMetadata, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/api/client.rs:70:46 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn create_message(&self, channel_id: &'a String, message: &'a types::Message<'a>) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/store.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | Ok(to_writer(file, self).map_err(Box::new)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 30 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/store.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn get(&self, channel_id: &String) -> Option<&DateTime> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/store.rs:35:39 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn set(&mut self, channel_id: &String, data: DateTime) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:58:60 [INFO] [stderr] | [INFO] [stderr] 58 | .map_or(true, |saved_time| &time.with_timezone(&Utc) > saved_time) [INFO] [stderr] | -------------------------^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `time.with_timezone(&Utc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | .unwrap_or(item.description().unwrap_or("no content")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.description().unwrap_or("no content"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | .unwrap_or(Utc.timestamp(0, 0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Utc.timestamp(0, 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | ref api_endpoint: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | ref deploy_token: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | ref metadata: types::ServiceMetadata, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/api/client.rs:70:46 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn create_message(&self, channel_id: &'a String, message: &'a types::Message<'a>) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/store.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | Ok(to_writer(file, self).map_err(Box::new)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 30 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/store.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn get(&self, channel_id: &String) -> Option<&DateTime> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/store.rs:35:39 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn set(&mut self, channel_id: &String, data: DateTime) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:58:60 [INFO] [stderr] | [INFO] [stderr] 58 | .map_or(true, |saved_time| &time.with_timezone(&Utc) > saved_time) [INFO] [stderr] | -------------------------^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `time.with_timezone(&Utc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | .unwrap_or(item.description().unwrap_or("no content")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| item.description().unwrap_or("no content"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | .unwrap_or(Utc.timestamp(0, 0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Utc.timestamp(0, 0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.50s [INFO] running `"docker" "inspect" "7493998632a07bf454fe0ca0984c7cfc94ef725be9102ab8a01e85dc59b14fd0"` [INFO] running `"docker" "rm" "-f" "7493998632a07bf454fe0ca0984c7cfc94ef725be9102ab8a01e85dc59b14fd0"` [INFO] [stdout] 7493998632a07bf454fe0ca0984c7cfc94ef725be9102ab8a01e85dc59b14fd0