[INFO] updating cached repository SANDRAProject/service-hello-world [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/SANDRAProject/service-hello-world [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/SANDRAProject/service-hello-world" "work/ex/clippy-test-run/sources/stable/gh/SANDRAProject/service-hello-world"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/SANDRAProject/service-hello-world'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/SANDRAProject/service-hello-world" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SANDRAProject/service-hello-world"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SANDRAProject/service-hello-world'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7bb338140a58e565734a13f32b7e913713005a1d [INFO] sha for GitHub repo SANDRAProject/service-hello-world: 7bb338140a58e565734a13f32b7e913713005a1d [INFO] validating manifest of SANDRAProject/service-hello-world on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of SANDRAProject/service-hello-world on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing SANDRAProject/service-hello-world [INFO] finished frobbing SANDRAProject/service-hello-world [INFO] frobbed toml for SANDRAProject/service-hello-world written to work/ex/clippy-test-run/sources/stable/gh/SANDRAProject/service-hello-world/Cargo.toml [INFO] started frobbing SANDRAProject/service-hello-world [INFO] finished frobbing SANDRAProject/service-hello-world [INFO] frobbed toml for SANDRAProject/service-hello-world written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/SANDRAProject/service-hello-world/Cargo.toml [INFO] crate SANDRAProject/service-hello-world has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting SANDRAProject/service-hello-world against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/SANDRAProject/service-hello-world:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43cc7fe99ff1bb1d26c96a84ef18bb9f4cd4938f8d43eaefdb532d37102cd46c [INFO] running `"docker" "start" "-a" "43cc7fe99ff1bb1d26c96a84ef18bb9f4cd4938f8d43eaefdb532d37102cd46c"` [INFO] [stderr] Compiling derive_builder v0.5.1 [INFO] [stderr] Compiling derive_builder_core v0.2.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.42 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Checking dotenv v0.11.0 [INFO] [stderr] Checking rss v1.5.0 [INFO] [stderr] Checking service-hello-world v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!("Hello, world!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | ref api_endpoint: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/main.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | println!("Hello, world!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | ref deploy_token: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | ref metadata: types::ServiceMetadata, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/api/client.rs:70:46 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn create_message(&self, channel_id: &'a String, message: &'a types::Message<'a>) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | ref api_endpoint: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | ref deploy_token: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/api/client.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | ref metadata: types::ServiceMetadata, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/api/client.rs:70:46 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn create_message(&self, channel_id: &'a String, message: &'a types::Message<'a>) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.96s [INFO] running `"docker" "inspect" "43cc7fe99ff1bb1d26c96a84ef18bb9f4cd4938f8d43eaefdb532d37102cd46c"` [INFO] running `"docker" "rm" "-f" "43cc7fe99ff1bb1d26c96a84ef18bb9f4cd4938f8d43eaefdb532d37102cd46c"` [INFO] [stdout] 43cc7fe99ff1bb1d26c96a84ef18bb9f4cd4938f8d43eaefdb532d37102cd46c