[INFO] updating cached repository S2Lab/messycanvas
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/S2Lab/messycanvas
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/S2Lab/messycanvas" "work/ex/clippy-test-run/sources/stable/gh/S2Lab/messycanvas"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/S2Lab/messycanvas'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/S2Lab/messycanvas" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/S2Lab/messycanvas"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/S2Lab/messycanvas'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ccfcdc28d1f82dc1a550c957a55b69e32fae75b8
[INFO] sha for GitHub repo S2Lab/messycanvas: ccfcdc28d1f82dc1a550c957a55b69e32fae75b8
[INFO] validating manifest of S2Lab/messycanvas on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of S2Lab/messycanvas on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing S2Lab/messycanvas
[INFO] finished frobbing S2Lab/messycanvas
[INFO] frobbed toml for S2Lab/messycanvas written to work/ex/clippy-test-run/sources/stable/gh/S2Lab/messycanvas/Cargo.toml
[INFO] started frobbing S2Lab/messycanvas
[INFO] finished frobbing S2Lab/messycanvas
[INFO] frobbed toml for S2Lab/messycanvas written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/S2Lab/messycanvas/Cargo.toml
[INFO] crate S2Lab/messycanvas has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting S2Lab/messycanvas against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/S2Lab/messycanvas:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4b324c2ca21ca9819a06a0f7fdc47555485534eeb67d7f049b6ae673d1a8047b
[INFO] running `"docker" "start" "-a" "4b324c2ca21ca9819a06a0f7fdc47555485534eeb67d7f049b6ae673d1a8047b"`
[INFO] [stderr]     Checking simple_logger v0.5.0
[INFO] [stderr]     Checking http v0.1.8
[INFO] [stderr]     Checking cookie v0.11.0
[INFO] [stderr]     Checking tokio-signal v0.2.1
[INFO] [stderr]     Checking trust-dns-proto v0.4.0
[INFO] [stderr]     Checking trust-dns-resolver v0.9.0
[INFO] [stderr]     Checking h2 v0.1.10
[INFO] [stderr]     Checking actix v0.7.2
[INFO] [stderr]     Checking actix-web v0.7.2
[INFO] [stderr]     Checking messycanvas v0.0.0-dev.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cfg.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             listen_addr: listen_addr,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cfg.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             listen_addr: listen_addr,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cli.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return DEFAULT_CONFIG_PATH.as_ref();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DEFAULT_CONFIG_PATH.as_ref()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cli.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return DEFAULT_CONFIG_PATH.as_ref();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DEFAULT_CONFIG_PATH.as_ref()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `AddressChanged`
[INFO] [stderr]   --> src/srv.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     AddressChanged,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/cfg.rs:58:29
[INFO] [stderr]    |
[INFO] [stderr] 58 |             _ => return Err(Error::type_mismatch("(root)", "table", &v).into()),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::type_mismatch("(root)", "table", &v)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cfg.rs:65:18
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 .ok_or(Error::entry_required("general"))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::entry_required("general"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cfg.rs:68:26
[INFO] [stderr]    |
[INFO] [stderr] 68 |                         .ok_or(Error::type_mismatch("general", "table", m))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::type_mismatch("general", "table", m))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cfg.rs:73:18
[INFO] [stderr]    |
[INFO] [stderr] 73 |                 .ok_or(Error::entry_required("general.listen_addr"))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::entry_required("general.listen_addr"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cfg.rs:76:26
[INFO] [stderr]    |
[INFO] [stderr] 76 |                         .ok_or(Error::type_mismatch("general.listen_addr", "string", m))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::type_mismatch("general.listen_addr", "string", m))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/cli.rs:94:18
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 .unwrap_or(get_default_config_path())
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(get_default_config_path)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/cli.rs:140:18
[INFO] [stderr]     |
[INFO] [stderr] 140 |                 .unwrap_or(get_default_config_path())
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(get_default_config_path)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `AddressChanged`
[INFO] [stderr]   --> src/srv.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     AddressChanged,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/cfg.rs:58:29
[INFO] [stderr]    |
[INFO] [stderr] 58 |             _ => return Err(Error::type_mismatch("(root)", "table", &v).into()),
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::type_mismatch("(root)", "table", &v)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cfg.rs:65:18
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 .ok_or(Error::entry_required("general"))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::entry_required("general"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cfg.rs:68:26
[INFO] [stderr]    |
[INFO] [stderr] 68 |                         .ok_or(Error::type_mismatch("general", "table", m))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::type_mismatch("general", "table", m))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cfg.rs:73:18
[INFO] [stderr]    |
[INFO] [stderr] 73 |                 .ok_or(Error::entry_required("general.listen_addr"))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::entry_required("general.listen_addr"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/cfg.rs:76:26
[INFO] [stderr]    |
[INFO] [stderr] 76 |                         .ok_or(Error::type_mismatch("general.listen_addr", "string", m))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::type_mismatch("general.listen_addr", "string", m))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/cli.rs:94:18
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 .unwrap_or(get_default_config_path())
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(get_default_config_path)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/cli.rs:140:18
[INFO] [stderr]     |
[INFO] [stderr] 140 |                 .unwrap_or(get_default_config_path())
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(get_default_config_path)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 51.84s
[INFO] running `"docker" "inspect" "4b324c2ca21ca9819a06a0f7fdc47555485534eeb67d7f049b6ae673d1a8047b"`
[INFO] running `"docker" "rm" "-f" "4b324c2ca21ca9819a06a0f7fdc47555485534eeb67d7f049b6ae673d1a8047b"`
[INFO] [stdout] 4b324c2ca21ca9819a06a0f7fdc47555485534eeb67d7f049b6ae673d1a8047b