[INFO] updating cached repository RyanRiddle/rust-vm
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/RyanRiddle/rust-vm
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/RyanRiddle/rust-vm" "work/ex/clippy-test-run/sources/stable/gh/RyanRiddle/rust-vm"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RyanRiddle/rust-vm'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/RyanRiddle/rust-vm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanRiddle/rust-vm"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanRiddle/rust-vm'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] dfae1bde161ceab0a77b427162092c557d08b183
[INFO] sha for GitHub repo RyanRiddle/rust-vm: dfae1bde161ceab0a77b427162092c557d08b183
[INFO] validating manifest of RyanRiddle/rust-vm on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of RyanRiddle/rust-vm on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing RyanRiddle/rust-vm
[INFO] finished frobbing RyanRiddle/rust-vm
[INFO] frobbed toml for RyanRiddle/rust-vm written to work/ex/clippy-test-run/sources/stable/gh/RyanRiddle/rust-vm/Cargo.toml
[INFO] started frobbing RyanRiddle/rust-vm
[INFO] finished frobbing RyanRiddle/rust-vm
[INFO] frobbed toml for RyanRiddle/rust-vm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanRiddle/rust-vm/Cargo.toml
[INFO] crate RyanRiddle/rust-vm has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting RyanRiddle/rust-vm against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RyanRiddle/rust-vm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 13652e93aabe6c11afc2e9f4aba5b338ff3776525dd685daf0bf94aab5781371
[INFO] running `"docker" "start" "-a" "13652e93aabe6c11afc2e9f4aba5b338ff3776525dd685daf0bf94aab5781371"`
[INFO] [stderr]     Checking vm v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:17:15
[INFO] [stderr]    |
[INFO] [stderr] 17 |         "POP" => if stack.len() > 0
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: denote infinite loops with `loop { ... }`
[INFO] [stderr]   --> src/main.rs:34:2
[INFO] [stderr]    |
[INFO] [stderr] 34 |     while true
[INFO] [stderr]    |     ^^^^^^^^^^ help: use `loop`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(while_true)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:40:3
[INFO] [stderr]    |
[INFO] [stderr] 40 |           io::stdin().read_line(&mut instruction)
[INFO] [stderr]    |  _________^
[INFO] [stderr] 41 | |             .ok()
[INFO] [stderr] 42 | |             .expect("Could not read instruction.");
[INFO] [stderr]    | |__________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:45:51
[INFO] [stderr]    |
[INFO] [stderr] 45 |             let toks: Vec<&str> = instruction.trim().split(" ").collect();
[INFO] [stderr]    |                                                            ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:17:15
[INFO] [stderr]    |
[INFO] [stderr] 17 |         "POP" => if stack.len() > 0
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: denote infinite loops with `loop { ... }`
[INFO] [stderr]   --> src/main.rs:34:2
[INFO] [stderr]    |
[INFO] [stderr] 34 |     while true
[INFO] [stderr]    |     ^^^^^^^^^^ help: use `loop`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(while_true)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:40:3
[INFO] [stderr]    |
[INFO] [stderr] 40 |           io::stdin().read_line(&mut instruction)
[INFO] [stderr]    |  _________^
[INFO] [stderr] 41 | |             .ok()
[INFO] [stderr] 42 | |             .expect("Could not read instruction.");
[INFO] [stderr]    | |__________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:45:51
[INFO] [stderr]    |
[INFO] [stderr] 45 |             let toks: Vec<&str> = instruction.trim().split(" ").collect();
[INFO] [stderr]    |                                                            ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.56s
[INFO] running `"docker" "inspect" "13652e93aabe6c11afc2e9f4aba5b338ff3776525dd685daf0bf94aab5781371"`
[INFO] running `"docker" "rm" "-f" "13652e93aabe6c11afc2e9f4aba5b338ff3776525dd685daf0bf94aab5781371"`
[INFO] [stdout] 13652e93aabe6c11afc2e9f4aba5b338ff3776525dd685daf0bf94aab5781371