[INFO] updating cached repository RyanDurk/csv_to_db
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/RyanDurk/csv_to_db
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/RyanDurk/csv_to_db" "work/ex/clippy-test-run/sources/stable/gh/RyanDurk/csv_to_db"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RyanDurk/csv_to_db'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/RyanDurk/csv_to_db" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanDurk/csv_to_db"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanDurk/csv_to_db'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 254b3a0b00c1a822e177fd323d35afbad2bc51d0
[INFO] sha for GitHub repo RyanDurk/csv_to_db: 254b3a0b00c1a822e177fd323d35afbad2bc51d0
[INFO] validating manifest of RyanDurk/csv_to_db on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of RyanDurk/csv_to_db on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing RyanDurk/csv_to_db
[INFO] finished frobbing RyanDurk/csv_to_db
[INFO] frobbed toml for RyanDurk/csv_to_db written to work/ex/clippy-test-run/sources/stable/gh/RyanDurk/csv_to_db/Cargo.toml
[INFO] started frobbing RyanDurk/csv_to_db
[INFO] finished frobbing RyanDurk/csv_to_db
[INFO] frobbed toml for RyanDurk/csv_to_db written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanDurk/csv_to_db/Cargo.toml
[INFO] crate RyanDurk/csv_to_db has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting RyanDurk/csv_to_db against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RyanDurk/csv_to_db:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f6e25bff69bd1ba42a7d958ed8b4114a70dd8becf29f616bc43d606423177f58
[INFO] running `"docker" "start" "-a" "f6e25bff69bd1ba42a7d958ed8b4114a70dd8becf29f616bc43d606423177f58"`
[INFO] [stderr]     Checking csv_to_db v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/main.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     write!(&mut writer, "{}\n", new_header).expect("can't write new_header");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/main.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 |     write!(&mut writer, "{}\n", new_header).expect("can't write new_header");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:19:32
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let filename = argv.get(1).expect(&format!("Usage: {} [filename] [table_name]", argv[0]));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Usage: {} [filename] [table_name]", argv[0]))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:20:34
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let table_name = argv.get(2).expect(&format!("Usage: {} [filename] [table_name]", argv[0]));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Usage: {} [filename] [table_name]", argv[0]))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:30:31
[INFO] [stderr]    |
[INFO] [stderr] 30 | fn write_insert(column_pairs: &ColumnPairs, table_name: &str) {
[INFO] [stderr]    |                               ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:42:31
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn write_schema(column_pairs: &ColumnPairs, table_name: &str) {
[INFO] [stderr]    |                               ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 | fn write_csv(column_pairs: &ColumnPairs, raw_filename: &str, table_name: &str) {
[INFO] [stderr]    |                            ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:75:24
[INFO] [stderr]    |
[INFO] [stderr] 75 | fn get_new_cols(pairs: &ColumnPairs) -> Vec<String> {
[INFO] [stderr]    |                        ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/main.rs:76:11
[INFO] [stderr]    |
[INFO] [stderr] 76 |     pairs.into_iter().map(|pair| {
[INFO] [stderr]    |           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:82:49
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn get_schema(table_name: &str, column_mapping: &ColumnPairs) -> String {
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:19:32
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let filename = argv.get(1).expect(&format!("Usage: {} [filename] [table_name]", argv[0]));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Usage: {} [filename] [table_name]", argv[0]))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:20:34
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let table_name = argv.get(2).expect(&format!("Usage: {} [filename] [table_name]", argv[0]));
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Usage: {} [filename] [table_name]", argv[0]))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:30:31
[INFO] [stderr]    |
[INFO] [stderr] 30 | fn write_insert(column_pairs: &ColumnPairs, table_name: &str) {
[INFO] [stderr]    |                               ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:42:31
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn write_schema(column_pairs: &ColumnPairs, table_name: &str) {
[INFO] [stderr]    |                               ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 | fn write_csv(column_pairs: &ColumnPairs, raw_filename: &str, table_name: &str) {
[INFO] [stderr]    |                            ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:75:24
[INFO] [stderr]    |
[INFO] [stderr] 75 | fn get_new_cols(pairs: &ColumnPairs) -> Vec<String> {
[INFO] [stderr]    |                        ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]   --> src/main.rs:76:11
[INFO] [stderr]    |
[INFO] [stderr] 76 |     pairs.into_iter().map(|pair| {
[INFO] [stderr]    |           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:82:49
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn get_schema(table_name: &str, column_mapping: &ColumnPairs) -> String {
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.29s
[INFO] running `"docker" "inspect" "f6e25bff69bd1ba42a7d958ed8b4114a70dd8becf29f616bc43d606423177f58"`
[INFO] running `"docker" "rm" "-f" "f6e25bff69bd1ba42a7d958ed8b4114a70dd8becf29f616bc43d606423177f58"`
[INFO] [stdout] f6e25bff69bd1ba42a7d958ed8b4114a70dd8becf29f616bc43d606423177f58