[INFO] updating cached repository RyanBluth/todo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RyanBluth/todo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RyanBluth/todo" "work/ex/clippy-test-run/sources/stable/gh/RyanBluth/todo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RyanBluth/todo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RyanBluth/todo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanBluth/todo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanBluth/todo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5ad879185f0284862d3594d52f96cf0e4dca9aca [INFO] sha for GitHub repo RyanBluth/todo: 5ad879185f0284862d3594d52f96cf0e4dca9aca [INFO] validating manifest of RyanBluth/todo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RyanBluth/todo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RyanBluth/todo [INFO] finished frobbing RyanBluth/todo [INFO] frobbed toml for RyanBluth/todo written to work/ex/clippy-test-run/sources/stable/gh/RyanBluth/todo/Cargo.toml [INFO] started frobbing RyanBluth/todo [INFO] finished frobbing RyanBluth/todo [INFO] frobbed toml for RyanBluth/todo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanBluth/todo/Cargo.toml [INFO] crate RyanBluth/todo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RyanBluth/todo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RyanBluth/todo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 44d1ffb4ee715c9f45650f6f455e27194945b8e25d98ecc16cd992e65d9e8e30 [INFO] running `"docker" "start" "-a" "44d1ffb4ee715c9f45650f6f455e27194945b8e25d98ecc16cd992e65d9e8e30"` [INFO] [stderr] Checking wcwidth v1.0.1 [INFO] [stderr] Checking term-table v0.1.6 [INFO] [stderr] Checking todo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/todo/types.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/todo/types.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Serialize` [INFO] [stderr] --> src/todo/types.rs:2:13 [INFO] [stderr] | [INFO] [stderr] 2 | use serde::{Serialize, Deserialize}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `metadata` [INFO] [stderr] --> src/todo/types.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::{metadata, File, OpenOptions}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / return ToDo{ [INFO] [stderr] 18 | | content: content, [INFO] [stderr] 19 | | created: Local::now() [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | ToDo{ [INFO] [stderr] 18 | content: content, [INFO] [stderr] 19 | created: Local::now() [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / return ToDoCollection{ [INFO] [stderr] 33 | | store: Vec::new() [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | ToDoCollection{ [INFO] [stderr] 33 | store: Vec::new() [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return Ok(collection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(collection)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return Ok(ToDoCollection::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ToDoCollection::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return self.store.iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.store.iter()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | const CONTENT_KEY: &'static str = "Content"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deserialize`, `Serialize` [INFO] [stderr] --> src/todo/types.rs:2:13 [INFO] [stderr] | [INFO] [stderr] 2 | use serde::{Serialize, Deserialize}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `metadata` [INFO] [stderr] --> src/todo/types.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::{metadata, File, OpenOptions}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / return ToDo{ [INFO] [stderr] 18 | | content: content, [INFO] [stderr] 19 | | created: Local::now() [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | ToDo{ [INFO] [stderr] 18 | content: content, [INFO] [stderr] 19 | created: Local::now() [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / return ToDoCollection{ [INFO] [stderr] 33 | | store: Vec::new() [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | ToDoCollection{ [INFO] [stderr] 33 | store: Vec::new() [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | return Ok(collection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(collection)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return Ok(ToDoCollection::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ToDoCollection::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/todo/types.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return self.store.iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.store.iter()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | const CONTENT_KEY: &'static str = "Content"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.43s [INFO] running `"docker" "inspect" "44d1ffb4ee715c9f45650f6f455e27194945b8e25d98ecc16cd992e65d9e8e30"` [INFO] running `"docker" "rm" "-f" "44d1ffb4ee715c9f45650f6f455e27194945b8e25d98ecc16cd992e65d9e8e30"` [INFO] [stdout] 44d1ffb4ee715c9f45650f6f455e27194945b8e25d98ecc16cd992e65d9e8e30